Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 10 Oct 2023 13:13:49 -0500
From:   Rob Herring <robh@kernel.org>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/3] regulator: dt-bindings: fixed-regulator: Add
 under-voltage interrupt support
Message-ID: <20231010181349.GA1183365-robh@kernel.org>
References: <20231010085906.3440452-1-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231010085906.3440452-1-o.rempel@pengutronix.de>
Precedence: bulk

On Tue, Oct 10, 2023 at 10:59:04AM +0200, Oleksij Rempel wrote:
> Add under-voltage interrupt support. This can be used with simple
> regulators having no other way to communicate an under-voltage event
> except as by toggling some GPIO line.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> 
> diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> index ac0281b1cceb..0f8760ed2fb1 100644
> --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> @@ -100,6 +100,14 @@ properties:
>    vin-supply:
>      description: Input supply phandle.
> 
> +  interrupts:
> +    maxItems: 1
> +    description:
> +      Under-voltage interrupt
> +
> +  interrupt-names:
> +    const: under-voltage

No need for a name. If there's ever a 2nd, it should be a specific 
binding, not fixed-regulator.

> +
>  required:
>    - compatible
>    - regulator-name
> ---
>  .../devicetree/bindings/regulator/fixed-regulator.yaml    | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> index ac0281b1cceb..0f8760ed2fb1 100644
> --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml

I think you've got some problems with your setup...

> @@ -100,6 +100,14 @@ properties:
>    vin-supply:
>      description: Input supply phandle.
>  
> +  interrupts:
> +    maxItems: 1
> +    description:
> +      Under-voltage interrupt
> +
> +  interrupt-names:
> +    const: under-voltage
> +
>  required:
>    - compatible
>    - regulator-name
> -- 
> 2.39.2
>