Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Tue, 10 Oct 2023 21:34:20 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Jian Zhang <zhangjian.3032@bytedance.com>
Cc:     brendan.higgins@linux.dev, benh@kernel.crashing.org,
        joel@jms.id.au, andrew@aj.id.au, zhangjian3032@gmail.com,
        yulei.sh@bytedance.com, xiexinnan@bytedance.com,
        Andi Shyti <andi.shyti@kernel.org>,
        Andrew Jeffery <andrew@codeconstruct.com.au>,
        Tommy Huang <tommy_huang@aspeedtech.com>,
        "open list:ARM/ASPEED I2C DRIVER" <linux-i2c@vger.kernel.org>,
        "moderated list:ARM/ASPEED I2C DRIVER" <openbmc@lists.ozlabs.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" 
        <linux-aspeed@lists.ozlabs.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] i2c: aspeed: Fix i2c bus hang in slave read
Message-ID: <ZSWnPG6oIxrVFmbg@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Jian Zhang <zhangjian.3032@bytedance.com>,
        brendan.higgins@linux.dev, benh@kernel.crashing.org, joel@jms.id.au,
        andrew@aj.id.au, zhangjian3032@gmail.com, yulei.sh@bytedance.com,
        xiexinnan@bytedance.com, Andi Shyti <andi.shyti@kernel.org>,
        Andrew Jeffery <andrew@codeconstruct.com.au>,
        Tommy Huang <tommy_huang@aspeedtech.com>,
        "open list:ARM/ASPEED I2C DRIVER" <linux-i2c@vger.kernel.org>,
        "moderated list:ARM/ASPEED I2C DRIVER" <openbmc@lists.ozlabs.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/ASPEED MACHINE SUPPORT" <linux-aspeed@lists.ozlabs.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20231006022233.3963590-1-zhangjian.3032@bytedance.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="h+tNCvmT9ovOY6AN"
Content-Disposition: inline
In-Reply-To: <20231006022233.3963590-1-zhangjian.3032@bytedance.com>
Precedence: bulk


--h+tNCvmT9ovOY6AN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 06, 2023 at 10:22:33AM +0800, Jian Zhang wrote:
> When the `CONFIG_I2C_SLAVE` option is enabled and the device operates
> as a slave, a situation arises where the master sends a START signal
> without the accompanying STOP signal. This action results in a
> persistent I2C bus timeout. The core issue stems from the fact that
> the i2c controller remains in a slave read state without a timeout
> mechanism. As a consequence, the bus perpetually experiences timeouts.
>=20
> In this case, the i2c bus will be reset, but the slave_state reset is
> missing.
>=20
> Fixes: fee465150b45 ("i2c: aspeed: Reset the i2c controller when timeout =
occurs")
> Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
> Acked-by: Andi Shyti <andi.shyti@kernel.org>
> Tested-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
>=20

Applied to for-current, thanks!


--h+tNCvmT9ovOY6AN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmUlpzgACgkQFA3kzBSg
KbZ/7RAAihe3k0z4CpvqtiXFm+M8WD2j0iyfOzn0Q3Rv+NN+Y7hVMAxsDs0hTUiJ
81zj8PMMrBkMnEPhv0ytT7QKrv8N65H2ONXGmWtOPLinn2UsMSMtM53zNLg2iR5M
ASKLLr5gSqaTjJao9FCYKWP7G5rwYqF8gEcmp/S0aA2ElyGfkvOf9J3n92iwMRaV
CO859fdKlSaINuHIEw1Uh7q8ThdXAdON94vVDAREXPWax3Qle2fAMFjxEQQaBrbL
uUlBJuRwExDegv56w6RPmbA0CQ6M/BxEviFm2thICeg6Q94UAFXTQWg6Wyirdhrz
ufVHS8JZf1481aK4iUw3IFrIgRV7tTFfO8WVoQUn5EJZTZ2K1KB16RUgPdrUJebg
9sAxLJ6u4H+Hu0FeL/k8zd7IcQJkoJlUm3IkEsHSWGc/tGQ0kolAAKbQjLs8778/
LLo6c9qyVnhFyh60WaOAzppRyK/R1+UmJWYZYSozwk8lZ8OkUsrWHLH5hWa7tMyW
ZkoBrjSvGWjAfib9kLvpgtalcNwlOLr//RP9bT27IblhWiz63VUT8p2G1gqND5p8
jcyodY25zHqFDIpy/AdMVjzqupmSw3upInMOgnJqyeMCEigh2OdL8voL6dxBAQ0m
2rhGFIrH4BzpaUun1KA3zSjwuY84qDYGB54Rz9ng01MTh/9G1bs=
=VdsG
-----END PGP SIGNATURE-----

--h+tNCvmT9ovOY6AN--