Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <0db37cd0-9cb9-41bc-c2aa-0a01c0295ed0@nvidia.com>
Date:   Tue, 10 Oct 2023 12:36:31 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH v1 4/4] hte: tegra194: Switch to LATE_SIMPLE_DEV_PM_OPS()
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        timestamp@lists.linux.dev, linux-tegra@vger.kernel.org
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Andy Shevchenko <andy@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>
References: <20231010151709.4104747-1-andriy.shevchenko@linux.intel.com>
 <20231010151709.4104747-5-andriy.shevchenko@linux.intel.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20231010151709.4104747-5-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHpXVEcyQlpzcnBrbVlBcjRSaGt6dmhJV2d1bWsyTmgyNTZhM0R4SUZ0bXl2?=
 =?utf-8?B?RnpqNzc1Nll2aWdkNzRUZ1ZFVWpwaDN5Z0tPZExvZjljMGhGL0pDcGNRT3dB?=
 =?utf-8?B?RVZGUnVLM0VsT1dzbzE4VUwzQWQ3aWt0TFRiZk5BWjk1OUZ0ZVJVWW1jZVAy?=
 =?utf-8?B?OXRFUGNIbFdlYlJLZG9YeDdMWDlJWTErY0Z5WW9ieW5Hc25hYTZ1NDdtbWx3?=
 =?utf-8?B?WkJIQ0w2eWl6dEIrV3NMTWJ3RC9GOWgrUHJqZlVGMFg5YjdtWi9zMlYyNDc4?=
 =?utf-8?B?ZUNSaDZndnVWMzN0RlBqOUE3QWxSbUU3MjJQSmFnUGZDK0NUcVNya1RwMENw?=
 =?utf-8?B?WjA4SjFucDBmaEVJc21VcEpKNlczMU45Njl0MFg5TUpxZ1RnOTg0TEtBKzho?=
 =?utf-8?B?dDRRQUlGU0pnN2laUzB3d0pxSmppN3lvdVlKR3M5bkJUM083U3ZWd2JUbGdD?=
 =?utf-8?B?Vng0MEtRdDErWUtGZEVnZHlWQ2xqSUhKQjAvbGVkeWtpYUdVeGpNdmV4VFRs?=
 =?utf-8?B?bkJObm9HMEo2dlRVVnczelo3THhJVTJzVkI0dmZFYWFqVHFFRURRVXpybWNB?=
 =?utf-8?B?cGZUQ0hHYVdxS1A2ampEY2ZmOVJJYk9hRi91WmtQZEszbjJTUzZBQk1zQ2ll?=
 =?utf-8?B?UzltY1k2OHE3K1pDMWVJRUFRbktKd2dTenF6aVVta3ArUzNRS3BQblRyN1c1?=
 =?utf-8?B?REFpNG1Beko1RktNOC9SSGNjRG9CT1ZPbFN3bHE2YVliUG9GQzNqZDMwRUhC?=
 =?utf-8?B?R1JkV3g0V1doWFpqUjIwcGNaQ3EwbERJUnBiQ0JSWks3NkxrQUV0dHBWWGVT?=
 =?utf-8?B?UXhuNU9VTHROYUpua0doRHZnU3hXWkxCTmRrcFpqSkpVeDVOaEczVExlcGVq?=
 =?utf-8?B?TUpGa3VISGxLR0ozN0FmNWxKRjVINElqMldFQ3NWQnE2VDNYZ1lnWkJVRkpD?=
 =?utf-8?B?L3ppWEZNWDZLcFFySTZFYXFVbUVKaGVQVURJeDZlblJEbUhONzhBSUZMOEx3?=
 =?utf-8?B?TkdQTFpPczVvb3d3MktXZ3oycmdONDRzZDYrSHRzeHk0OEl0a28waEFoY3M1?=
 =?utf-8?B?REFhWFBSUXFZdXlkRjcybGdGR0piWVBYRGlkbm1UL05QWGNZSGVRZkphOWdR?=
 =?utf-8?B?K0hTbXFTM2NSV0tJS1hybFptRm1sS0xmai9RNDhEK0htSWVpN0FTRGF3NEhz?=
 =?utf-8?B?Q045dnZvTWNNN3BweVlQaHZrWWpiK3VqTWluV3NVYmZjQXpNN1ZrUy9VQzN6?=
 =?utf-8?B?eU9uVkhpbDk0UHhSRnkrWEIxY1haTEVacklTNWZ6KzBqZVFRSm9FdDhIc2Ju?=
 =?utf-8?B?TC9KMXZ2WXN2aVI4a1N1YkZxR0E2dzR1UmFmVEZJSThSUDJwdUx0WE9EMEZV?=
 =?utf-8?B?eW1WM0lnRTFkL3BZUDMySGlRY3ZqcXM1Lzdib2k0MDRhMjhTZUgzbFkwYmNC?=
 =?utf-8?B?Yk9jam9aZDYxdGZVN1NFRzc5NFRaaDNyekpxbWs0YU5HMEMzOG03cFl1WW5h?=
 =?utf-8?B?ZWRMQzhET0RXYUNDSkRmSm1lUGE0WlgzM1ZyQlZyajNJcXJ2eE8xYzVsM1FQ?=
 =?utf-8?B?aHlNbmkvYVFJWlV3K0tMSG5CSGtsd3BLWGl2ekl1ZUQ1M0hUcUlmRVJMVEEx?=
 =?utf-8?B?bUVzT3FyN1JzOXloM0hZdzVlZDB2RG9ZaDFqSGdyR0NRODMyQjdmcnV3NDk4?=
 =?utf-8?B?K3RQalVjK1Y1d0lnYXZUK1h4TE1kNkV3OUd1c0loZkxjMUUxcld2QWJnSDFl?=
 =?utf-8?B?SmVXejZ6OFo1bWo3QUtVa1NxR0RLNVM5MjZwcEFjQjlCY002UUhMYmZDRDNC?=
 =?utf-8?B?STdNSVNrNmxNR3lYdS8ycThwTmQ4VHRPOUNndmFUaXdKeEc2OUlrRjNUSGdS?=
 =?utf-8?B?aFBlc3hFWmFaMnZMdHdIam8xYmFoM081bG1ENTRuYnZiK21UeW16OUpFb3I4?=
 =?utf-8?B?eW5EV0w2R1o4dWhKck9FbklaVkorTS9EVlBJWjBnZzl1amVJUzU1WlQ5TCsr?=
 =?utf-8?B?cUFPdVgzR2p3N0JkdE14c0tQSXd3OWNLU2lHME5IaXpGTzhUekFaUHpHbUlD?=
 =?utf-8?B?NVRncjJUcE11eERTWGQyNDQzcUI1eWVxVXc0RndJUGxkb0lqMzdPczF3NCtN?=
 =?utf-8?Q?rpSDGaFcB8Fna6AFig2X6agmf?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8552ffe6-e341-4c89-35ea-08dbc9c8364a
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 19:36:34.6174
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f3Y+Uu5leruoJuBj4v3OaM2LMICERVJ588ECJpG0/xKQpNzkgwLmeCpsC3mu6yg8A+o9zRW+NigJQ5uODsUswg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7630
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 10 Oct 2023 12:37:05 -0700 (PDT)

On 10/10/23 8:17 AM, Andy Shevchenko wrote:
> SET_LATE_SYSTEM_SLEEP_PM_OPS is deprecated, replace it with
> LATE_SYSTEM_SLEEP_PM_OPS() and use pm_sleep_ptr() for setting
> the driver's pm routines. We can now remove the __maybe_unused
> qualifier in the suspend and resume functions.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/hte/hte-tegra194.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> index 30ef1750a9fa..30fa7c0a555e 100644
> --- a/drivers/hte/hte-tegra194.c
> +++ b/drivers/hte/hte-tegra194.c
> @@ -815,7 +815,7 @@ static int tegra_hte_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static int __maybe_unused tegra_hte_resume_early(struct device *dev)
> +static int tegra_hte_resume_early(struct device *dev)
>  {
>  	u32 i;
>  	struct tegra_hte_soc *gs = dev_get_drvdata(dev);
> @@ -836,7 +836,7 @@ static int __maybe_unused tegra_hte_resume_early(struct device *dev)
>  	return 0;
>  }
>  
> -static int __maybe_unused tegra_hte_suspend_late(struct device *dev)
> +static int tegra_hte_suspend_late(struct device *dev)
>  {
>  	u32 i;
>  	struct tegra_hte_soc *gs = dev_get_drvdata(dev);
> @@ -856,15 +856,14 @@ static int __maybe_unused tegra_hte_suspend_late(struct device *dev)
>  }
>  
>  static const struct dev_pm_ops tegra_hte_pm = {
> -	SET_LATE_SYSTEM_SLEEP_PM_OPS(tegra_hte_suspend_late,
> -				     tegra_hte_resume_early)
> +	LATE_SYSTEM_SLEEP_PM_OPS(tegra_hte_suspend_late, tegra_hte_resume_early)
>  };
>  
>  static struct platform_driver tegra_hte_driver = {
>  	.probe = tegra_hte_probe,
>  	.driver = {
>  		.name = "tegra_hte",
> -		.pm = &tegra_hte_pm,
> +		.pm = pm_slee_ptr(&tegra_hte_pm),

typo, pm_sleep_ptr instead?

>  		.of_match_table = tegra_hte_of_match,
>  	},
>  };