Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 10 Oct 2023 13:20:11 -0700 (PDT)
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     Will Deacon <will@kernel.org>
cc:     Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the arm-perf tree
In-Reply-To: <20231010181434.GA10072@willie-the-truck>
Message-ID: <751b969c-b37f-f8e0-5983-98352d7c88c3@os.amperecomputing.com>
References: <20231010095601.1443903c@canb.auug.org.au> <98ffbcf6-a646-ac2-5785-f78644f7cbe@os.amperecomputing.com> <20231010175013.GA10036@willie-the-truck> <20231010181434.GA10072@willie-the-truck>
Content-Type: text/plain; charset=US-ASCII; format=flowed
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3U4/anN6t15OWCPw99X/KkyLNfiA35Ohd3P6Ywx1Ww/X7NBp/k8l7qe0qoFy?=
 =?us-ascii?Q?nVELNsAkFpS9IehslzcqIE5rWmwIM4a1X/YquovUEE5au+FJAZsRPtDKasu+?=
 =?us-ascii?Q?IPS54BVlxduH+Qmg/eNlvdN8VBZBGc14XrUNgsak/sO4YTp3rlgtkJ7Bxwkm?=
 =?us-ascii?Q?It3WFzfJA4t7Zmiol9uZPm+1R0cWk9JYtubloFQUoGedbGGyHDgaxwATgZnz?=
 =?us-ascii?Q?uHRrP5fQtNgbTFBG1J2IKU3An8tawWqZX1U8J0VTFa4PaDKW/0JVzPlt2vYD?=
 =?us-ascii?Q?qelkBfI37rmPMpdSoO3SkLzziyDnbhA4GaZjwhfYwDqjDOedeLehYJ2EJQcy?=
 =?us-ascii?Q?fiGUv9o/e5bzWjwOUrN4oo0zLoWu5+hOH524UfTB+BwSZilT+YN6e2y0CenG?=
 =?us-ascii?Q?tgmdYUksuQDW3hvDzhVtNcbVBiiNYPDu+yZFHAEDJpqJskRILFM36vOWIyTS?=
 =?us-ascii?Q?9U17BhDI++yty23F9+DbmpvSSWvePXDUyLBWuI/5/3atWpbUGeOLNrN9X+zD?=
 =?us-ascii?Q?7yzzjBD6jQzzRrfKzVKU+19h3gQbq3fyr0yZVpmUT57BEy2LH7gzcijqylbF?=
 =?us-ascii?Q?iclHXHA0m9mX63VUGE+TUbvD2Mxotx9QZ7ejiasbI2bivNwqZq38yoqL9oIK?=
 =?us-ascii?Q?TAs74MPustbQedGEAn1QUbRTlylmNaFk/uzsRXteXdkXwz2negh4mCk7vX+F?=
 =?us-ascii?Q?7+h6vdGScetcdGn4xEd/geMl/sUWuBwVjtOvYdMJSEDBrFgRFDn1Un4eyjnB?=
 =?us-ascii?Q?wp/LX51kkamPXUfUM7DQB+TFFzRzp29UiY6vCAVGXMw/QDUXc16Th+nHHyb9?=
 =?us-ascii?Q?6YkJxlitq3QmduphuX0ds1tUsB/ruvMcMRpFc40V1YEbiZ0vcC5UZqZ16vgD?=
 =?us-ascii?Q?sa6g/cuk8gdG9yTavNDV0qfT/+GElaCU2lyML070UtgDA3zixkqE2C/IhoaQ?=
 =?us-ascii?Q?n2I7WS4Xi1SNpJ+zNbCi0TDdK80FaYbdultVC4Zynm2/a1i7ZyPkDIQLG0/8?=
 =?us-ascii?Q?aLY1vlGDxtz0jDYOwglxP8ujP763RwNQXdxF8BEameldThpF06F1wXDISQbe?=
 =?us-ascii?Q?jZIf9Lv9CeqXCnJbaS2rhfHQkvc8TdmwkoKyNpFA3vQ0u4OZo28Ye8IA21pU?=
 =?us-ascii?Q?VK57reagNXq8+xGEsTB5YMiHKyElWSIM/tNo2PX5YML4mxcY4dgK4T8eZ3r0?=
 =?us-ascii?Q?eIYT86pjRt7+/deVQ9/ZzlG2z1go1LFxL6fznl+mMUmtaDYxym4waD4rYUXq?=
 =?us-ascii?Q?N+s4CKcDMOJiwabhNJHBxbobWs00c/JqX2FuPah85dqLMCMsUn5oB8VMB3Q5?=
 =?us-ascii?Q?S3MwlLDR2IPNzfbyiGK1hhc2iD9Xd8NY0/CV4ExOAphoSzoPNV2IUk6wf5EE?=
 =?us-ascii?Q?/bGMesppATb3JRF1y9dqEi84gUtRy+kEjSDOpWOzUOPvvF51kf034FXFAZGp?=
 =?us-ascii?Q?pmVFfiSuPIKT4O6kOaxzxKP7zm9mpPucqqZD2igw7aT989IpdiwFy/YoxX3i?=
 =?us-ascii?Q?6up7TI5HujEYiQng1gCr9RL/XUGI6tFJ4nKdFSvc5vYazbYBSlIHYXN9FwFW?=
 =?us-ascii?Q?eyVSLzr11ExzjYz5NUlFzsNObpEb3BoKZ80ublBaatoxgXefFzIBuLfdHaRj?=
 =?us-ascii?Q?1dH03wyyl7bOcFl38b+3yvo=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76c58e21-2f4a-4cc0-075c-08dbc9ce572b
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 20:20:26.9818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RamSunKU3syEYAQzElfMzQOxErilGmUFrjfUTd9YIu1uRnUNll37JMdTeITZlx2PbgOdmaXGe/XSt8wrJW2OoZsg3yBAYvL4gzeKKZVRHG+2cR0WUOWIF/0cJ/CL6N4x
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR01MB6108
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 10 Oct 2023 13:20:41 -0700 (PDT)
X-Spam-Level: **


On Tue, 10 Oct 2023, Will Deacon wrote:
> On Tue, Oct 10, 2023 at 06:50:13PM +0100, Will Deacon wrote:
>> On Mon, Oct 09, 2023 at 10:45:18PM -0700, Ilkka Koskinen wrote:
>>> On Mon, 9 Oct 2023, Stephen Rothwell wrote:
>>>> After merging the arm-perf tree, today's linux-next build (x86_64
>>>> allmodconfig) failed like this:
>>>>
>>>> drivers/perf/arm_cspmu/ampere_cspmu.c: In function 'ampere_cspmu_set_ev_filter':
>>>> drivers/perf/arm_cspmu/ampere_cspmu.c:164:9: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
>>>>  164 |         writel(threshold, cspmu->base0 + PMAUXR0);
>>>>      |         ^~~~~~
>>>> cc1: all warnings being treated as errors
>>>>
>>>> Caused by commit
>>>>
>>>>  290a9c0e55f8 ("perf: arm_cspmu: ampere_cspmu: Add support for Ampere SoC PMU")
>>>>
>>>> I have used the arm-perf tree from next-20231009 for today.
>>>
>>> Thanks for catching the bug! It doesn't seem to happen on arm64 build but I
>>> can reproduce it on x86_64 build indeed.
>>>
>>>
>>> Will, it seems that "#include <linux/io.h>" is missing from ampere_cspmu.c.
>>> After that also x86_64 build goes through. How would you like to get the bug
>>> fixed? Shall I submit a new version of the patch, and you would replace the
>>> old patch with the new one or is it better to
>>> create a completely new patch that only adds the missing include line?
>>
>> If it's just a missing include, I can chuck a patch on top to fix it myself.
>> I'll double-check it resolves the problem and then update the branch.
>
> In the end I just fixed up your commit, as it was still on the HEAD of the
> branch. Update now pushed out!
>
> Cheers,
>
> Will

Sounds perfect! Thank you Will, much appreciated!

Cheers, Ilkka