Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp398130rdg; Tue, 10 Oct 2023 13:44:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHrQcOD+7ih06vhgNYpYvbqOFs0yinK2GPP1iPZm+I9DArLXs5Z5bDthDTiKQYURQYu0D7s X-Received: by 2002:a05:6a21:7784:b0:173:318:b1ec with SMTP id bd4-20020a056a21778400b001730318b1ecmr926238pzc.35.1696970648390; Tue, 10 Oct 2023 13:44:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696970648; cv=none; d=google.com; s=arc-20160816; b=vepJCMtqM9sq1YkxgbF13hhNOsucr8+9m5flWVyjgieezOcKVwQ4LqldOZ9kuK6qaQ zAv2vjXMX+BvviX8YpigB89AEzOYEm1Rs3CRfDxnIqofb6ay0rl9vluLoSzkZ5J3NU56 UVQj2XbHBu1ZQ3kFsHN5q2BCS4FYvAKGXNinAszdZpQLqec3kBuKLqjw3JaX0bieD4Ln Q3opv26tfitkYeQZAKy60ejstYh7sdmaLABbfV8Llr36Rou8nyacWzAbAmOzFOz6DLGK ALtVVDij1BaqWNkaFGLYWPOuHydirRV2gpQC3HxpRIyMqRE+UOvBGYiPoN6JcSnSJR9V /4Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=81cjp26ZLCRfVdmuI0tOydwXQofr1yefS0BzwFdHnbc=; fh=ycsv2EpYFL92UsX/ZKoSuZ0hqbG8/yOlJlzcQh+eV4s=; b=sdsnb09hWaHC0sppFEj9yiYtarH3pLWR3abiZ+XJpdvtCwQW3RBJXBgQ7Kt6TWOS/u xtyGZe+0Al65yHCwRYiEw8Ub0g+fd+F7Hcy3pIJ2rpA/OZfhezBS0p05vneSN+damtF4 Jbbcmj2H+SarrmwzvL6o3DBJchjCuxdsmlnhBEbnDxDoyL3/Mc5zAQdxngKGWD7BrkQH 5HAFefMYJfRBw1kK5bzMzPlBaFVibAABZtR3UZiiTu9FJcGgXa88P1GOA/CNMd9Ogx7E HCYGKMG9FLwhdGCza3sypZPQqvZHQg9pG7GMyG9ld8iQTdCxUHmCVkg3EJUsJWCD7Sv9 q1iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=nKvdWABE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id f9-20020a056a00228900b0068fbd3713desi11011978pfe.107.2023.10.10.13.44.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 13:44:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=nKvdWABE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 970DC80BC52C; Tue, 10 Oct 2023 13:44:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbjJJUnw (ORCPT + 99 others); Tue, 10 Oct 2023 16:43:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbjJJUnv (ORCPT ); Tue, 10 Oct 2023 16:43:51 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B54A28E for ; Tue, 10 Oct 2023 13:43:49 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2c012232792so75978401fa.0 for ; Tue, 10 Oct 2023 13:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1696970628; x=1697575428; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=81cjp26ZLCRfVdmuI0tOydwXQofr1yefS0BzwFdHnbc=; b=nKvdWABEN2E/p+8e6xdih23nMkhHt/EEho9DFMoMngoY6PT3yU2veyMKdaSh8Ow8Gb T6Aot2iThVy86Y17cM8Ugu3fv38HrwbNYLIHTNgWqYTbXMJIyxQWUE+0zXPiBSI+Ys4I /ETGlpyJV+KiXSKmhjS0MeIZRnrj6mkoXLMx0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696970628; x=1697575428; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=81cjp26ZLCRfVdmuI0tOydwXQofr1yefS0BzwFdHnbc=; b=lFvWOGOru53FSY9N1y+vedqVfHYytn8SBY5C3r8dsKKIA7sdA8AzcMAoiMhnZcaNtM J8IBMAFQfIytt79nj6UBaJgEPHi6iAc1LXUcyyyppgvhK2gZFUS7/+40kroK9yC/nprc ndBCxLMjXLH7MkFxxhD3scNt3cCedyl+O9rz3q+b/o5dk1xLwljEkKOnUC4tQ3YBRGSY bI/xL4whQNPaUujwODFNhX9wLjPBYfkIWYkI10H95piudVlcziVywBBFf5LFEi5aoVEY nn7tKk72ztLmqwvt3lbd/vx2liRYuOSLGee4cnPToGRG9tGOii8daXujXE1Y1mulaZwu XzWg== X-Gm-Message-State: AOJu0YxHw+9M3ktmxRLtRYN+coeq5r8eNhi0Q2j+Lhy7pbFG1OTGApE8 pdI12Fv78RC9PEXGsR9Ugii3/qr1q4zRiGYZx0J1vw== X-Received: by 2002:a2e:9d0e:0:b0:2c2:966f:8cc with SMTP id t14-20020a2e9d0e000000b002c2966f08ccmr13106920lji.0.1696970627979; Tue, 10 Oct 2023 13:43:47 -0700 (PDT) MIME-Version: 1.0 References: <20230929021213.2364883-1-joel@joelfernandes.org> <87bkdl55qm.fsf@email.froward.int.ebiederm.org> <20231009100155.6d71490f@gandalf.local.home> In-Reply-To: <20231009100155.6d71490f@gandalf.local.home> From: Joel Fernandes Date: Tue, 10 Oct 2023 16:43:37 -0400 Message-ID: Subject: Re: [PATCH] kexec: Fix reboot race during device_shutdown() To: Steven Rostedt Cc: "Eric W. Biederman" , linux-kernel@vger.kernel.org, Ricardo Ribalda , Ross Zwisler , Rob Clark , Linus Torvalds , kexec@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 10 Oct 2023 13:44:05 -0700 (PDT) X-Spam-Level: ** On Mon, Oct 9, 2023 at 10:00=E2=80=AFAM Steven Rostedt wrote: > > On Sat, 7 Oct 2023 21:30:42 -0400 > Joel Fernandes wrote: > > > Just checking how we want to proceed, is the consensus that we should > > prevent kernel crashes without relying on userspace stopping all > > processes? Should we fix regular reboot syscall as well and not just > > kexec reboot? > > If you can show that we can trigger the crash on normal reboot, then I > don't see why not. That is, if you have a program that does the reboot > (without the SIGSTOP/SIGKILL calls) and triggers this crash, I think that= 's > a legitimate reason to fix it on normal reboot too. Ok, Sounds good, thanks for sharing your thoughts. - Joel