Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <5dc78e2f-62c1-083a-387f-9afabac02007@intel.com>
Date:   Tue, 10 Oct 2023 14:20:28 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH] igbvf: replace deprecated strncpy with strscpy
Content-Language: en-US
To:     Justin Stitt <justinstitt@google.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>
References: <20231010-strncpy-drivers-net-ethernet-intel-igbvf-netdev-c-v1-1-69ccfb2c2aa5@google.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20231010-strncpy-drivers-net-ethernet-intel-igbvf-netdev-c-v1-1-69ccfb2c2aa5@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STdLVjUxU3VlbHFmRU8rdzNwRHo4TXNXYk10bkhRQ2RBVlpoamZmTXl5aHps?=
 =?utf-8?B?aVJLcU9ETmRHRzRvalkwOWpqSzNvRGpBc1NKUSt6YytZWWF2alJGZHdqWjhs?=
 =?utf-8?B?bVkzajJla0ZsRVNKWUtuTFJ3dDdGQ2tUTXQwNG1aUEhEQkVjLzd6RGQ1L1Y2?=
 =?utf-8?B?c0FXVjVUQzVXUjRsejRqMVdYSXRncHhoRm50bTk5RVVoRXFaaVRYNmRUbE45?=
 =?utf-8?B?aUFXaXhMQ0xZcWUralNTaXNwcWxpYW44cjViL2pYV0ptSytocFowOFNTUFE1?=
 =?utf-8?B?ZmFKNDBLVE5ESmwxQ3NGM2ZKZWs4L1NzQWFCRXZTL1NQcnRoOGk0Wjdiamt4?=
 =?utf-8?B?ZDVaKzhhTldGS0lRUE5lT0tHV2I3UXpTMGNSZ0k1SnJ5RTVaWXFKS3VvNFR0?=
 =?utf-8?B?ZFlSa1BKYWxsc1prcHN6WXdMN3dPQW1DYnZhOEg0R2Y2NC9VdGl5ZUsraXEv?=
 =?utf-8?B?bkVhTElxbytIRDlLM29vaURSSVQ2eFlJMVYzb2lOQTdNSTBNMFJwVFdxdCsr?=
 =?utf-8?B?Q3FsY3N4UlpycXJaNGpFUDBoR0E1UlB5aXFIOGpDekR4ZGxML2t3TGVMODFv?=
 =?utf-8?B?SWdZRE1iRWloaUpDdmNReS9ZdlRhWkMrVHROdXBOVkhFc3ZjVnZsY2JPQlBz?=
 =?utf-8?B?VUlqOHNoOC9yclVFSE5wVE96UHkzekdEOXRKeTJ1S3pYYnBzaXJjWEk4ejVk?=
 =?utf-8?B?STFyZWhFN3R0VGZJTmMyTHlDNGZjdFo5SVp5bUJQS3N5cGU0aWdIS0xqZWRG?=
 =?utf-8?B?cndSdjBHVU84Tm5qbjFFR3pjYjhPTXZRamJhek1ueEpZOTRHOFZrRG1ia043?=
 =?utf-8?B?T0psNk1zd1BNelRndXlmTjhWazh5dnJka1VRSmVKaVBidDlXTksyVkl1OWdK?=
 =?utf-8?B?TkFhZ05zR0FOU24wQzVpKzZVWTViWFg5MUVWS21FZEtrZXBFc2hvQjk0c1Fi?=
 =?utf-8?B?S29qYzBLWHEyQWhHMEYwSlNlK0xsdDJhdlc1dnZyR0oxbHdNdGM5dnJFc2cv?=
 =?utf-8?B?dUJUMWZWMmtjS0NLSEkyS3QxNXRsNlE2OXRqRXd3VU5Pd3VpWndwSXAwZ3ho?=
 =?utf-8?B?R3RPdGt3eGhNeFlVSlFocVFGeDJSVkIzdzRpZ0F6b3RZbHF4UXJlQWIweVpN?=
 =?utf-8?B?RnFSblVYanVKOWFYMDVXcFZ1bGZoSWV4RE9NOXM4NGd2Wk5JK1FHYUdNYmhm?=
 =?utf-8?B?N01KT3lScktSRzU3OExlZW44L1J1cThlbmNZby9tWnRtYXFDbjAwa25IWkN1?=
 =?utf-8?B?Q1ZTV0I3QkF2Nmx4T2YrcDd2MGJPamNidXQ2eDBSVFVLMVBZS3BSNy9pNFd5?=
 =?utf-8?B?TG1QWkVOWldIL203NXczYmtYbnVDMjRnUmliZGhBTjJpYkd6WVVrRDlwQVAw?=
 =?utf-8?B?dk9MYnpha0hXY0trQ2sxaUhIYk1ZYXFnV3J1UlVldk1PWDF0ZUs0c3lVUmk5?=
 =?utf-8?B?ZkIyMWMrazVvbGVySWs1dDl4N21DWE04UGNJWU00elhGc0VaSnVDL2dYenVY?=
 =?utf-8?B?QWJYTXBtbitldU4zT01hWjhHNkkvOCt4NHJqMWJKTFA3YmNFa2VmUExaczIy?=
 =?utf-8?B?NzY0VUVKcGJsUVh0Vzl6S0VCVXo5Ly9DZ1I5dlRoQnBsT2tvSUFuTmpkb3lE?=
 =?utf-8?B?NWJQVW1QcitpeHBEbnhuN1JwVWhlcHVDdzg0Wlo0TSs1VU9qQ29FN3JJYjI1?=
 =?utf-8?B?NEZhTWlHM2VYY2crcHIxNkphdWNweFNIbTVYWEpuRzBHSnh0enRqWGxDbXRC?=
 =?utf-8?B?QWNpME0vSjhrdGYrVUF5a29ZT0ZyQXFvY2FqSTBkYkJsNWs5MzJ4RVA5TjZW?=
 =?utf-8?B?NXdjc2p3L2ZFMWZUWlFSZkNwUldkNlRuUW55YTMxSmozaUVObVFoN20ybUdE?=
 =?utf-8?B?SnpMWE9lRElMWUFENWc3VXNzdGsrdGRSc0N1a21LRkxic0hqdmJCVDVZYmlC?=
 =?utf-8?B?djJtMm5pRTF1cm0vK1F1V25tUDA3Sk5NZVpyUm9PVFBaUHJjZy9DVHFLL21W?=
 =?utf-8?B?TWxDNmcyMDJHeXJqMmY2dndUbkhHeFBIMEh6c0xKenRaTnEwRHRJT0V5T2Jp?=
 =?utf-8?B?SlBaVnFMYzBYcUk4QlRpdEhKOWlIMkIyM2doQzQ1WWUzdzBNVHZHeUhDbkNO?=
 =?utf-8?B?MEp1enBLYnd2ajJ4UVRsQ25hQmxoWDlmM1VEcU95V2tIeUgxdEN2NzFkNlVt?=
 =?utf-8?B?Z1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a048c498-7724-4cc9-ec02-08dbc9d6bb7f
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 21:20:31.0258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YBYQdi5ngCzEedjBjX/0R/8yA2cyQAx6ieIJOTrF/nBXCAu5pURylof6/p2uqjkPCtL4F9nPjteuRrokKSI2MVwT7ekrN3ecZK+OFqKFENo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7286
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 10 Oct 2023 14:20:58 -0700 (PDT)

On 10/10/2023 2:12 PM, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> We expect netdev->name to be NUL-terminated based on its usage with
> `strlen` and format strings:
> |       if (strlen(netdev->name) < (IFNAMSIZ - 5)) {
> |               sprintf(adapter->tx_ring->name, "%s-tx-0", netdev->name);
> 
> Moreover, we do not need NUL-padding as netdev is already
> zero-allocated:
> |       netdev = alloc_etherdev(sizeof(struct igbvf_adapter));
> ...
> alloc_etherdev() -> alloc_etherdev_mq() -> alloc_etherdev_mqs() ->
> alloc_netdev_mqs() ...
> |       p = kvzalloc(alloc_size, GFP_KERNEL_ACCOUNT | __GFP_RETRY_MAYFAIL);
> 
> Considering the above, a suitable replacement is `strscpy` [2] due to
> the fact that it guarantees NUL-termination on the destination buffer
> without unnecessarily NUL-padding.
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>
> ---

Thanks Justin for these patches, please make sure you mark the subject
line as per the netdev rules:
[PATCH net-next v1] etc etc

I'd also prefer they came in as part of one series with a good cover
letter, at the very least for the Intel drivers, and you probably could
combine any others (netdev) together up to the 15 patch limit.

Please mention how you found these issues, via automated tool or via
coccinelle script, manual grepping, etc?

Thanks,
Jesse