Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <d84f2d4d-40d7-af15-0049-f8e1efed1eba@intel.com>
Date:   Tue, 10 Oct 2023 16:19:06 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH net-next 0/7] net: intel: replace deprecated strncpy uses
Content-Language: en-US
To:     Justin Stitt <justinstitt@google.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     <linux-hardening@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20231010-netdev-replace-strncpy-resend-as-series-v1-0-caf9f0f2f021@google.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20231010-netdev-replace-strncpy-resend-as-series-v1-0-caf9f0f2f021@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFJDT0NoSisvcm9wZFplZDBiVVhxdGNsS2tESHVTMk1XbWI4eGJyMTZGaHVU?=
 =?utf-8?B?YXp0b0dneXNJU0xNeWJ1Y0hWN0pHWUYyZ2hTOUlHTnB0NmxpbDUvSGJOSTNN?=
 =?utf-8?B?S1lMOFVJQ0NTQy82eitDTzdXeVE2bkhwb0hPTXluNzBPMjRjNHh3MzVNRkJs?=
 =?utf-8?B?L1dLa3lvUEFXSzhmbkJzRlY3cUY0aDFvNzMvQnJyR2hxNjJNMkY1OVBoQ3Rm?=
 =?utf-8?B?elM0cXdwWVd1TnpuUHY3ZzJVeHJaVnlLaGNtRDZPa1RmT1JWNUZaVy9mNkRP?=
 =?utf-8?B?MC9QRHMyWWljd1hMRTE3NXJDZ0xtU2xTa2FTRUhZaG1Gdk1NaDAveTM4bUJw?=
 =?utf-8?B?VDFlbHpGYi81SFBRcXAyRXFyZE4vVjFTcDY1YWhpN2ZtbG5WZUVNS29MbG0v?=
 =?utf-8?B?N3ZQN3prVGZZZ0FYSTMzNjRJTzJpVjNoclhQdHV0a1NkNFhuQ2d6U01KNUdq?=
 =?utf-8?B?bWFZVU9kL0hPYXhYSEhCN3o4ZGxyQVVZWjlwUGtObU5WVTI4TlhEWDZSbnRH?=
 =?utf-8?B?bmdveFpWWnJIODQ3QThFUVRMRnlDanBMYVBoOFhPU0lpRmtuTjR2dkRaOEFa?=
 =?utf-8?B?eDJoVW1kWERWT085b2c3QndEaURyeUdtNU81cTJmRmxhejVHSTlHMldXZ1Ay?=
 =?utf-8?B?TXNkVWpodURNV3FiV20xWkxDS3piTjk4blM5S3dyMi9FMUxZaEZuaStPMXpm?=
 =?utf-8?B?UERTWkNjWGx3dzlkV1VGNk41OHRnSWs0dkNpa2VKSkVjVU5OMUNZZ2pRT09E?=
 =?utf-8?B?a2ZRS0gxVFVGSHNzS2oyazBjTC9PeEhiV01vTmpmNnozMXR4ekZLRk01Wld6?=
 =?utf-8?B?MGVtTDNaZVpNa3BGcTRKeHo2V0p3TUNNeDN3a0Vpa0hYVEpndkE0MjVPdWpL?=
 =?utf-8?B?eklKSnIyUXNTdVVqakxjQjU4Q1RnbU1CNnlDMlBnNmI1TUR0azZ6a1JHQndz?=
 =?utf-8?B?TmY1SFk5cjMwYXc2ZEN6MG1MWEh0TzZ1amhWSjJJS1VsY0VVMi9ib05FcG41?=
 =?utf-8?B?U3UxS044Q04yQ0xRa01ZUzhpRUlpSG1vbERqb2F4ZXhweEFFclhSOWkxbEtx?=
 =?utf-8?B?blZtdlpHSkRib0JEb1NYMHFaS1FHY3dlZW83cmZJM2Z0dVRFdWVEZlZjWWRS?=
 =?utf-8?B?eFY3clFLZ3pVWGxHOEJwbVlBMGJlODY5WXYvNHZyQ29SV090K24xQ2tvSzIx?=
 =?utf-8?B?bGZ2djk0eGdMYWMxNFhKUERXTzF4MDFTOGN0WXBtb0svZkV3ckFPbUt6clpR?=
 =?utf-8?B?OS96SEd5QXJlWC96Yno1NVZhb0ZFR3NTTzYwMFplNU5MdFArS0VQU3ppSDNV?=
 =?utf-8?B?em5GT0oxMVdtZHRxczBhbTFnMEZ1OUZYUDlXSE1iaDlrczlZc1JFSll1SkQ1?=
 =?utf-8?B?Wmd0TW15K0FyMHMvVHgvM1FHb3F5ZzFPRy9HZHFJRnlJK0tFYXBZWmwxTW95?=
 =?utf-8?B?V1lIUEw4QmEvbE9wMVFJWHdmWmp2ZmNiZkZ4WHZuc0Q1YlFYRFJUbHB4Z0RE?=
 =?utf-8?B?QlJvTmV0bkpEQi9lWGxsMHdYeUhFRWVxOUcxZDhUY2pVcjVtcnBmU0dsbDFv?=
 =?utf-8?B?cU12bzVad3RwbHZEdXhheEJFVlNPeTRzK0x2c2tTNVJPM3QyUmtRMVc0MHJB?=
 =?utf-8?B?Rm1IcE81OFlSRkI2UTEyZE95U1FRV3NSL01weUNCWGY1eDQxK0ZYNXBCWXRZ?=
 =?utf-8?B?V3pMMGp4UUV0VzhxSjYzOXNwT29CdjNBelpDMC9hNzZVWHBteXB2ZXNxdTlu?=
 =?utf-8?B?SWlJZ3QvUFZhdjhCNlFSbzhtdVkxQ1k5Yzg2S2k2NXdheHFLN3hyR0U1U3ZW?=
 =?utf-8?B?WktDL2lQNzdDS0ZxMlI2WndWTTVrNlR5dHhiRzNCTVRtRENjeXRlQnkvL0lS?=
 =?utf-8?B?RmZWWTBMbVNsVVo5NWZGTWV1OVBuOTJIWWlYRjZCMVRQOXh5Umd0aFhFS2xE?=
 =?utf-8?B?RFNBWWtZWWdtRDU1QzZYWGdGKzlqMGQwcWdmb29iZkRDdTZ2MXJvRXBqSStL?=
 =?utf-8?B?RUxJREJnamFhWFBUdFo1TVJJTk16UDM3OUxodHZUZEpBRGU1S2w1MVA3cmZj?=
 =?utf-8?B?Y3ZVdW5objltZ1IxVlNjQmhpLzNtNmJEZWx4NGlPT3FHSmF3ZEIrTnhwYlNq?=
 =?utf-8?B?TEZOOVRieWRwYUxEL0E3S2lSOElsYnVaVUFWQWpUMERvMmFoN2FKYlA0VVVG?=
 =?utf-8?B?cEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cda04342-b200-4210-5fde-08dbc9e74e16
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB4921.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 23:19:09.0515
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A42HSBpQrYUBQXtqEqL4gJ2BIDBiv6hQfqjZ7xA3ViXEjljZ5Key6NFBEy+uUZDeQ0ZGU5V3DDsxVlRuYKKCdmzmHxoqne73+B7G8qL8hfM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8489
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 10 Oct 2023 16:19:25 -0700 (PDT)

On 10/10/2023 3:26 PM, Justin Stitt wrote:
> Hi,
> 
> This series aims to eliminate uses of strncpy() as it is a deprecated
> interface [1] with many viable replacements available.
> 
> Predominantly, strscpy() is the go-to replacement as it guarantees
> NUL-termination on the destination buffer (which strncpy does not). With
> that being said, I did not identify any buffer overread problems as the
> size arguments were carefully measured to leave room for trailing
> NUL-bytes. Nonetheless, we should favor more robust and less ambiguous
> interfaces.
> 
> Previously, each of these patches was sent individually at:
> 1) https://lore.kernel.org/all/20231009-strncpy-drivers-net-ethernet-intel-e100-c-v1-1-ca0ff96868a3@google.com/
> 2) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-e1000-e1000_main-c-v1-1-b1d64581f983@google.com/
> 3) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-fm10k-fm10k_ethtool-c-v1-1-dbdc4570c5a6@google.com/
> 4) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-i40e-i40e_ddp-c-v1-1-f01a23394eab@google.com/
> 5) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-igb-igb_main-c-v1-1-d796234a8abf@google.com/
> 6) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-igbvf-netdev-c-v1-1-69ccfb2c2aa5@google.com/
> 7) https://lore.kernel.org/all/20231010-strncpy-drivers-net-ethernet-intel-igc-igc_main-c-v1-1-f1f507ecc476@google.com/
> 
> Consider these dead as this series is their new home :)
> 
> I found all these instances with: $ rg "strncpy\("
> 
> This series may collide in a not-so-nice way with [3]. This series can
> go in after that one with a rebase. I'll send a v2 if necessary.
> 
> [3]: https://lore.kernel.org/netdev/20231003183603.3887546-1-jesse.brandeburg@intel.com/
> 
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> Link: https://github.com/KSPP/linux/issues/90
> Signed-off-by: Justin Stitt <justinstitt@google.com>

Thanks Justin for fixing all these!

For the series:
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

PS: have you considered adding a script to scripts/coccinelle/api which
might catch and try to fix future (ab)users of strncpy?