Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   D Scott Phillips <scott@os.amperecomputing.com>
To:     linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Bjorn Helgaas <helgaas@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
        Darren Hart <darren@os.amperecomputing.com>,
        patches@amperecomputing.com
Subject: Re: [PATCH v2 1/2] PCI: acpiphp: Allow built-in attention drivers
In-Reply-To: <20230930002036.6491-1-scott@os.amperecomputing.com>
References: <20230930002036.6491-1-scott@os.amperecomputing.com>
Date:   Tue, 10 Oct 2023 17:13:22 -0700
Message-ID: <861qe2qan1.fsf@scott-ph-mail.amperecomputing.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6DfKBEXf1kPl6TiHBWCGWuCYNhpI83sBcPQ9OUGQ1LE796HJoq9Fv8V607vT?=
 =?us-ascii?Q?8RVOlEq66pprS9PjmUjxMqOk+Dqd91bnggcYoGmahT8lsyJ+u3pYOZ202isH?=
 =?us-ascii?Q?MRBNPizqnIFtELTWYTlmGMrN3BSTu6UTG4zymsnFVIBk5U9OmMblx3I/GGqq?=
 =?us-ascii?Q?95fruyMmeis0E90e1Hzhw0chj3to9IwnfE+i/BnvVmeJ4Tex921SsS1IlYQD?=
 =?us-ascii?Q?XrlSBVaZwukQ48UklY+gHinPWuQCy5K+WN7RyPi5EQmWIK57pK82d+td/K57?=
 =?us-ascii?Q?FDCdU7E5n3vTSJ2uaT4mUyXYeQcF3xnaW0+EpzUtZou/RGIT3Hy6DUc2s6ar?=
 =?us-ascii?Q?TNK5wXeOFa1KasHqQc319/PCbsfggkj/mR4loRjGO5w/BmuFDgalbA/upDar?=
 =?us-ascii?Q?5XOcb44IfmgYIwhBa1c1vP7DTTprmixPeVadtGpJa3K7EikENURddr5dMouw?=
 =?us-ascii?Q?ANpltQDbmJ4wgrmK7q/YAjCzfTGzZ+bKV0GWwo7ZQyJL0MtnHVcRlLGKNzCk?=
 =?us-ascii?Q?BuuCD4p+kOhLIWLL1aFfL6aIBLZQJYHujdN0w/LaPj9H6TUreBl0sp28UbIt?=
 =?us-ascii?Q?yCn5IhNxCnsXAzYGRKm/YP3oV1qmXMumvn9tJ9kkSzLDErSYSIRvTeW1o4Lw?=
 =?us-ascii?Q?FHMlg/MBrHQzM0vliDSISgTFrBrQT94peTIr4CUzEUai+ClXMlyZjvmAhAz4?=
 =?us-ascii?Q?s3v3BqpAsvAnloCGSoDXhiVKbXdZOOV2COAHABT47sAp9GIpiE5g1n4l91jQ?=
 =?us-ascii?Q?kZtbDz6PBSsHa7kQ0lvbaJjU9QvvaDNVnRzAMpf3jCKKtvftpxT/6BB29Ur1?=
 =?us-ascii?Q?YfvZ97UGSmL+YwVeSMytEcRmlPVX1SI1JTqzzrw7VcSHLqNI0szeGDicBBkq?=
 =?us-ascii?Q?A5V/pZLFz789uarqnMKbO3Qv9ucrF+/xyNw3hlNTOxHeTdfNy9Bce7pdq104?=
 =?us-ascii?Q?z2ae8esZcdzNndQ6SCyyrgnrwG5Ui3Fk+E92g/1qb5aMw4ThoQG4AJT0It35?=
 =?us-ascii?Q?Nv2DRDGzWXO4XshaYNLlsFiY5xQAudB9jQ5Ya8jrhiVBPtGcpaqWh/nTuhdd?=
 =?us-ascii?Q?EhF8whNQ6AwKGxZ4MYWdCHYOc77rHuXrZ/d+acpt6cdzqOdrLl2bhlQfskb5?=
 =?us-ascii?Q?t02Vf3B5oN8kdf8TlfiAZNoVVICk9yU4TtPwZsqp6i4/brexzGVXqu0l/2nK?=
 =?us-ascii?Q?MRHHIRb6hoka19GojRC31vFI5kXS8EYtcpvchfl2INGP9COTYGlxKr8UoaCR?=
 =?us-ascii?Q?tobwOBWOd4z9B1H98kKazG8y8I73UayruAfcveqzITAdgdpZ7bAXQNOCavQ5?=
 =?us-ascii?Q?H5UgqmN/2VUib3zowDMPOgxGRn81s/r10YnLgkUm7g89Q3BRg+bdvWa+Pitn?=
 =?us-ascii?Q?d1wOhQK3RzED0xIKnKResinsiPYIlGk1IWOoMo5aSg4ZiqLV4K0VeWmAN2uE?=
 =?us-ascii?Q?0BOifyCkNrAI+4yUXzcrmnz2Pu+icr2SLbc2gnhjJhVnkBfTRahBuhK/yzPK?=
 =?us-ascii?Q?/IPoYoLu5d1UeoAsmwRrvjqtuvPvs+NTGhT2DlCxIvqJqW4pQFrG3wEhtZI+?=
 =?us-ascii?Q?xs1LXrhU8tIls2O05qh9qkOVaoS7r8zNECKZd2iT9lu+Jr8NvVL5tYsGx4OV?=
 =?us-ascii?Q?vcWVpZa0Fc4w0A5KioMfpME=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2808d902-1887-49a7-592d-08dbc9eee43e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR0101MB2893.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 00:13:27.4732
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iXmIkJPpoy7ntzWn4AlXDC1L11enFkXQyG1RgQ8Lf2UL3eBufouOxplSTUPYoupSbv8aRYMTmhh8RwTX8NZvMe7m6DAJV5rb6QltduB/h5pTD5+4DOgBybEUz7ZKR19V
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7766
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 10 Oct 2023 17:13:42 -0700 (PDT)
X-Spam-Level: **

D Scott Phillips <scott@os.amperecomputing.com> writes:

> Starting from the introduction of the attention callback in acpiphp, a
> non-zero struct module *owner field has been required in
> acpiphp_register_attention(). Then intent seemed to be that the core code
> could then hold a refcount on the module while invoking a callback.
>
> This check accidentally precludes the possiblity of attention callbacks to
> drivers which are built-in.
>
> Remove the check on `struct module *owner` in acpiphp_register_attention()
> so that attention callbacks can also be registered from built-in drivers.

Hi Bjorn, ping on these, thanks

Scott

>
> Signed-off-by: D Scott Phillips <scott@os.amperecomputing.com>
> ---
> Changes since v1:
> - new patch in the series
>
>  drivers/pci/hotplug/acpiphp_core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp_core.c b/drivers/pci/hotplug/acpiphp_core.c
> index c02257f4b61c4..9dad14e80bcf2 100644
> --- a/drivers/pci/hotplug/acpiphp_core.c
> +++ b/drivers/pci/hotplug/acpiphp_core.c
> @@ -78,8 +78,7 @@ int acpiphp_register_attention(struct acpiphp_attention_info *info)
>  {
>  	int retval = -EINVAL;
>  
> -	if (info && info->owner && info->set_attn &&
> -			info->get_attn && !attention_info) {
> +	if (info && info->set_attn && info->get_attn && !attention_info) {
>  		retval = 0;
>  		attention_info = info;
>  	}
> -- 
> 2.41.0