Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp510805rdg; Tue, 10 Oct 2023 18:10:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF15s91jm42ix4HBRTMUgOvJSmRoZ1RcHjwih3wrXTlSMWbRpxvOp+Y7ndBxBsauc6wRCer X-Received: by 2002:a17:903:188:b0:1c9:b5a6:44a0 with SMTP id z8-20020a170903018800b001c9b5a644a0mr4057103plg.23.1696986620830; Tue, 10 Oct 2023 18:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696986620; cv=none; d=google.com; s=arc-20160816; b=ZE8I+OoYOypzX1B4XxsYePl4Hlix2DYqDaNLAnguQcZN6U+fS4VXtO6bncNVmD5ki0 1ybxIQo8dkQjzMWjksjoGUqLQyoFvZLMuHK2gRT/uLDw0af9rhcp6LjCmkK5SHXVo3Hz rxAdTGEf5co1hoQUpSnuf1rWQcUNtGAhyvwgby270zurU9ceTQ3u9VvdJkf9gwmWSYAi BsKXgSmDdXDjZV+LC+xnGvXkMTBjmiSuXZxC22AbVpnadgNi9izbvjlGl2VCx6dMxhIf K2a1Xtt/FQTFUB5POQrOUBytAjQZohixyHv6FupA4hDYnVxmDOf+Kw3qaJERryCr8G2/ Moqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=6sPq7khALZjsHwPR3Bsye7My8cUmyvcV/7Vuy1vjlZg=; fh=QWvUy1Q2Buj9bGz54nigjp1KcbXljRCl1ePypoM/Lzg=; b=NGO1oUBST1huWu/0p96NChzYt8QiEPwOpF3RtDHrC0dg40vc/4OwF2Cy6GI47+Gduq /y3bgXD0glwkKDJh5EnZKfWSmBnUfQfZ6ZSsFN2Cuefw5qfOwduCxdhqb3b1ZLZqdN6t 3D8kzD2wYrzDROIiyek6DdknNORa3L3sH2/AFmGUG9+BF8k1hx335M2l8Weexqsp1T01 BmfceTIoASSdXJLKbWrICGP8qu1PleCnoPeyOqlHiKke5dfUmAObC3FJoziwK7wq6aKz 8CQGARB10Age58pZkdFdoJUMut9rGBH4UyRDW3X5gxs+QGgJ3A8IJLozE/SM9Inmjd6L cbNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=azd0VSfO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id n6-20020a170903110600b001bba7713547si13768685plh.151.2023.10.10.18.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 18:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=azd0VSfO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BFF73812AD2B; Tue, 10 Oct 2023 18:10:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344579AbjJKBKR (ORCPT + 99 others); Tue, 10 Oct 2023 21:10:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343612AbjJKBKQ (ORCPT ); Tue, 10 Oct 2023 21:10:16 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF4C792 for ; Tue, 10 Oct 2023 18:10:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FD97C433CD; Wed, 11 Oct 2023 01:10:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696986614; bh=2IfNHYRbev2ob8PWFLqJ/T/VpvjKdoXQ/QJwspMHZVQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=azd0VSfOVuUgSlae+InN/Nq0QJC5WUtCO/YxqhpEbFIYFUpyiyDyb6V3bE1s+8631 dLXPNNEBRg9WYNwbyh9SEL94tP1io6c82lloUP5xjmRaTCr9ELT85IDVq5xg8ts/w5 0/QIy8+GdxsT0bT18PFF39/agaql2agzuPCUtTX52GtptjnryvX5EBWPbPKPUQxyA3 DYG/SeWTMegue7lrEukE6JiFyG40bmVjuIxYakBb2eti3qxHDR8oh0SDi1XTp5hJOy MXXy5sfhXSF8rDAXQxTPSdhArn+3a/HiTRhAk7V4mY1S4Nd9fG7eWK3mEzCveaYTWf MsMr8JG4BK+Sg== Date: Tue, 10 Oct 2023 18:10:13 -0700 From: Jakub Kicinski To: Joel Becker Cc: Breno Leitao , davem@davemloft.net, pabeni@redhat.com, Eric Dumazet , hch@lst.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org Subject: Re: [PATCH net-next v3 2/4] netconsole: Initialize configfs_item for default targets Message-ID: <20231010181013.67187de2@kernel.org> In-Reply-To: References: <20231010093751.3878229-1-leitao@debian.org> <20231010093751.3878229-3-leitao@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 10 Oct 2023 18:10:19 -0700 (PDT) On Tue, 10 Oct 2023 12:27:34 -0700 Joel Becker wrote: > > +#define NETCONSOLE_PARAM_TARGET_NAME "cmdline" > > Perhaps `NETCONSOLE_PARAM_TARGET_PREFIX` is better. Makes it clear this > is not the whole name. FWIW I had the same thought when looking at v2. Didn't wanna nit-pick but if there's two of us... -- pw-bot: cr