Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Wed, 11 Oct 2023 09:47:28 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Like Xu <like.xu.linux@gmail.com>, <pbonzini@redhat.com>,
        <chao.gao@intel.com>, <kai.huang@intel.com>,
        <robert.hoo.linux@gmail.com>, <yuan.yao@linux.intel.com>,
        kvm list <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 01/12] KVM: x86/mmu: helpers to return if KVM honors
 guest MTRRs
Message-ID: <ZSX+sODaE+zQr/AW@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20230714064656.20147-1-yan.y.zhao@intel.com>
 <20230714065006.20201-1-yan.y.zhao@intel.com>
 <553e3a0f-156b-e5d2-037b-2d9acaf52329@gmail.com>
 <ZSRZ_y64UPXBG6lA@google.com>
 <ZSRwNO4xWU6Dx1ne@google.com>
 <ZSTJEJepdnmC5PA5@yzhao56-desk.sh.intel.com>
 <ZSXnaIi454ATEdH0@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZSXnaIi454ATEdH0@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CjNSwprbpPjA10eJIk80r+iz22DzpGePoDoGMa/F46Q5CFxXIDnZ1/kY7gci?=
 =?us-ascii?Q?KXVcPKaywdayNts4IoQJzIJnrh78qcrPx4mVwR3bk/nClZg+zdH02Zjkh0BM?=
 =?us-ascii?Q?m1UfZwdy+yo0Ws7++LZ2Z01hiHd8phVoYlTpXiBeFimI4/7M7mPDlsjZ3p+h?=
 =?us-ascii?Q?v6HmsiNQC7SAdenrzwFSnfVFw/4noHIi0ek0mSP45RXdZoaMUH77IPBoa4hl?=
 =?us-ascii?Q?E6eQuZa7M/hG/U33ST/OI7z7k4l4YYEPgA/oS5D1A/dCe61FgF6MHmUld+Hy?=
 =?us-ascii?Q?C6QVQeU/nP/+zHSeXlDGU2p/LEivOBI1SG8euxTpd8D6PcGZVxSLrrJYtwTl?=
 =?us-ascii?Q?NN82VsZnKDP2F5r/jyu3GMO4pmycXXcHDbrW8jr0NG8YvlS7yWhOS37HsFiM?=
 =?us-ascii?Q?mq+Q7VN2nsFQuweLULozVNYvT20GPfiL+E9e8aT5h2+OpxtmVjOVe3hvFgPh?=
 =?us-ascii?Q?hzeD2DH90HOK2D/zVpPndSmznxygf01RvUKI3HQgHdlrxSu8YUI+b43h/ueD?=
 =?us-ascii?Q?EZMx2/6Wv82FWm7yQZtaQQXmmR/rXGmE0RZ3UhsjEQXvqB1CbmUiNxa6kD+P?=
 =?us-ascii?Q?ruROdgeZJRJijwj8b82h7rZ1SNBfxZPVkkrmD5h28jgUGx9UmA/D66w0HZHl?=
 =?us-ascii?Q?jRaZ1BytlG7qgVRRBOGe8kKnmW3mpFSQz4Y/lL7pGi/HjIQ3TB24onjc8HF1?=
 =?us-ascii?Q?cSEIZ9MpWmGdpulW/rJdr7G4n884crS1LjpTcwQVLuXdayf+X2P9xRor3q+0?=
 =?us-ascii?Q?IPmakQEFMZtE3Rmi5A0xfDOTY37ELn/rU/8mnNBBWAklQaEfAO+Cy3t12P2U?=
 =?us-ascii?Q?9eKEffgzmrrCfjqveUYjVk440t/u5pgwJ7+BFks5coNrOtm7gh35SKh+nHuW?=
 =?us-ascii?Q?fx0QsfkxV/69GuHeYMi8c5gj1ORDgwyae0+rXjhsLUZQvrcQ4iCVGF80gcRM?=
 =?us-ascii?Q?zsv/Y/TvMkxIBobQhXNlqqUyKNp2/y8IjSoEboqciooiC4MnYlwLluJp5GcT?=
 =?us-ascii?Q?d2bnL3QQHvdTOAxxDKkz8PIBbThPjCmGt869us8zPonvBokryqPmuaioXS4H?=
 =?us-ascii?Q?tqvClQ75mAFIDFNZcfpIR/sq366q36cZd6yy/YhJbN4HGsGXyJdWtkRhEwVj?=
 =?us-ascii?Q?gOmTVL9aPFP+xNAOGaKcbzYai1kvaKC/LYi6CPrfDauBZYIPM+cE9VqH8IhF?=
 =?us-ascii?Q?0MuSF8mcwawAu6i8SxoJuQhRZGdnl/1a0znDIbSC3dX064mamn6c7pobnwE6?=
 =?us-ascii?Q?NXByqYitzXoqSTb+qFjrvCWM5Tme9v4umQgJcHG7uX1vIJEW1XRuBKplB+QN?=
 =?us-ascii?Q?Uuo9Evl7sDkTnbuhBmijeiZnIET1Elva+TV5o02rgoqNzUEQD7Eq9M3SYoOK?=
 =?us-ascii?Q?oyEMa0zuhNseLd1/XWMKjwuq9aDf6LxMSmATTm5g+e7lba0Yv4Eer5ebUv7O?=
 =?us-ascii?Q?gWVGYv07kbYHni6bFqHcW9Pui7qkVAnDySHN9s53oP17SGDphjgRE0hrEU/t?=
 =?us-ascii?Q?GzNhd1LWJnM5w0KWlcuBpUd0FsUeP6z//UP59MzJyVkm/MdJiCpLr9sj/9t9?=
 =?us-ascii?Q?CaiaJPfzV2O0Eil1UycqxPeBjQYDku37ipDg3+F+?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e1d516e-5a19-47e4-bd5a-08dbc9fff409
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 02:15:35.2454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aWwLMeAtIAhiKL3WlnbYYXw8x7uLbW81W6USLP7UDSaIEUD5PwwRAaHnhjc3pTc979e4dsuHXW1XtgnAH2IoAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8719
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 10 Oct 2023 19:16:02 -0700 (PDT)
X-Spam-Level: **

On Tue, Oct 10, 2023 at 05:08:08PM -0700, Sean Christopherson wrote:
> On Tue, Oct 10, 2023, Yan Zhao wrote:
> > BTW, as param "kvm" is now removed from the helper, better to remove the word
> > "second" in comment in patch 4, i.e.
> > 
> > -        * So, specify the second parameter as true here to indicate
> > -        * non-coherent DMAs are/were involved and TDP zap might be
> > -        * necessary.
> > +        * So, specify the parameter as true here to indicate non-coherent
> > +        * DMAs are/were involved and TDP zap might be necessary.
> > 
> > Sorry and thanks a lot for helps on this series!
> 
> Heh, don't be sorry, it's not your fault I can't get this quite right.  Fixed
> up yet again, hopefully for the last time.  This is what I ended up with for the
> comment:
> 
> 	/*
> 	 * Non-coherent DMA assignment and de-assignment will affect
> 	 * whether KVM honors guest MTRRs and cause changes in memtypes
> 	 * in TDP.
> 	 * So, pass %true unconditionally to indicate non-coherent DMA was,
> 	 * or will be involved, and that zapping SPTEs might be necessary.
> 	 */
> 
> and the hashes:
> 
> [1/5] KVM: x86/mmu: Add helpers to return if KVM honors guest MTRRs
>       https://github.com/kvm-x86/linux/commit/1affe455d66d
> [2/5] KVM: x86/mmu: Zap SPTEs when CR0.CD is toggled iff guest MTRRs are honored
>       https://github.com/kvm-x86/linux/commit/7a18c7c2b69a
> [3/5] KVM: x86/mmu: Zap SPTEs on MTRR update iff guest MTRRs are honored
>       https://github.com/kvm-x86/linux/commit/9a3768191d95
> [4/5] KVM: x86/mmu: Zap KVM TDP when noncoherent DMA assignment starts/stops
>       https://github.com/kvm-x86/linux/commit/362ff6dca541
> [5/5] KVM: VMX: drop IPAT in memtype when CD=1 for KVM_X86_QUIRK_CD_NW_CLEARED
>       https://github.com/kvm-x86/linux/commit/c9f65a3f2d92

Looks good to me, thanks!