Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <d378d545-e14e-7e7a-8085-1e4dae87d66a@nvidia.com>
Date:   Tue, 10 Oct 2023 19:19:14 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH v1 3/4] hte: tegra194: Remove redundant dev_err()
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        timestamp@lists.linux.dev, linux-tegra@vger.kernel.org
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Andy Shevchenko <andy@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>
References: <20231010151709.4104747-1-andriy.shevchenko@linux.intel.com>
 <20231010151709.4104747-4-andriy.shevchenko@linux.intel.com>
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <20231010151709.4104747-4-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0lGQ0VZaWR3RVVEbkYxQ29YelZIZ01QU3dmOG1RZWFId1I2V1pJZnFaaDUy?=
 =?utf-8?B?Y0w5UTZ3Y2llbm03aUNCR0l3eTlFK2ZBSFdCcWZyeE0vbmVCMmJiK01tUHhu?=
 =?utf-8?B?c0ZSS0xnUFpBeWs4ekxLSHY5WFVTMmNWRjVTWlo3eXJVQ3NOR2ZzUEpKbzRy?=
 =?utf-8?B?Tm85bHQxMHU3RVNwYVRJbVE2eVJramlabXBsZFE4cllOWmgyUlBUQkxaTDg1?=
 =?utf-8?B?cGJ5emxSRkwzN0x0bVFmakpBNlVJTFQ0NUVKOXhWcUt4L0l4bVRwbUhVTlgv?=
 =?utf-8?B?Z2Q1Z3o2ZVJ0WFRicUltcjdmUklkb1FseUplWFhFd1dTZ21PdktBVWkyRUFD?=
 =?utf-8?B?VS9vWU9YMkt2QWt2WUxsRnI5aldKbk82aDdxTHg5NDhRa0pGcktlREdtUUhY?=
 =?utf-8?B?aGkwd3M5MmxUWHdxRjZqK0o0NFVhTXR1bHdRZG5aZ3p0TE53VXlOaTA0Qm5G?=
 =?utf-8?B?aXJIYUdSMHFMSlYrL1YzZCs3RlJhZHhGcnpTWXNqVVUyVVJGL0lnS1VhN2tI?=
 =?utf-8?B?djQrcnl0NS8vWEx4UkFzL1doTjgyazVKQkdZbldXMnIxcXJYekJ4ZXN0UTdj?=
 =?utf-8?B?cXJzZEtvVndPU2R1Q2NNRXJDaGo0NVVGbUVJeWUxaFVsUm4xMGJPRFN1WGV5?=
 =?utf-8?B?Vkk1MjNRMUdlUVY0cGd0bUhmb2VBWktmK0VMTXF6azVSSEZobmVYRmpoMXc0?=
 =?utf-8?B?THRXdUt0SkdqWW5lZ0tIOWJpc0UvaUE1MDI5L1lFZW9sNVczV1Z0RHB5TmxT?=
 =?utf-8?B?MU5DbjlROWdqamZrSENXT1dWL29tN0N0WG5NMWI4RzlzeVZMSFV3U25LM20x?=
 =?utf-8?B?ZXBmYWVWUS9ud21tK1pqVVl3c05iUmhhRytzdWhaZWovTE5vUDd6ekVxRkFu?=
 =?utf-8?B?R1BFTEZMVTZMYm5qY05qbEJYS2tWa2pyQzdOWlMwZmhGNE5ud1hnNDZWQTh0?=
 =?utf-8?B?ZW1FaWVoK2IxZkJTQzVtRFBBOVpUTllNd2pBdWJXeDdKbkVMU3FRTWFxa0JQ?=
 =?utf-8?B?U3Z3N0U4NW0zVnpUTENzR1c1NExUUlVleitJaWk4dUk4aUxlYkM5Nnh1REI4?=
 =?utf-8?B?MXpTYVFSR05lVEVOZzVDQmhLTjNyUmMxY2pXSlBkTi9BUUt4eXZKZUVhT0I4?=
 =?utf-8?B?bk5SYmVXVjJLMXpDaVlTeUNXbnQrRGQ2TWVIemJaTHREU2xsL25qai9GUndY?=
 =?utf-8?B?bmRMVmpzRjlwbHFOUFdza3V5Z0I1aFhqblJkUEpxeWY5bnZ1Mm00TUQvb0Vk?=
 =?utf-8?B?Mll1c0FFV2lqZVpXcGVrb3l1ZXpDT0xmMEhTT2RKYStuT2l2S0tCTzFDcEVo?=
 =?utf-8?B?M1dzVnlUdGxLODFoMk14WTJlTzBpdXpyZllGcU85YWFUdkNuQjA2WmlOdnk4?=
 =?utf-8?B?ZnVIdU9JMmNIblJORW9URmRVbjZoVzJEei9QeTJMdHRRVDBoOXdVU3FJejZ3?=
 =?utf-8?B?WndReERPb2hHdm1BV3R3dk5xMzJDeU9SbHJ1RERwS3FqekVrK1MzMkJSeG9l?=
 =?utf-8?B?dWhSbTZkSXBsczFLSzZTRmxSNE03NWx1V3R2WmJQM3hJbkhUYlQ2T09EMm8y?=
 =?utf-8?B?aGZXOTg1aThTTzA4eVNMQ2NNS0hSa1VURXd2cXdkQWxObGhsV25NYzc3RWNz?=
 =?utf-8?B?ZW85NVBmblY1V2FWNkU4TDhjVGlSMk9wTmRCWHVVYXozYjYzS2tHK0h6T21K?=
 =?utf-8?B?SkNTT21Ga2I1bndZVjI5eGIvVG8xZDcveEpSM2hkZmp2Sm1OSHJzRlMwVFFD?=
 =?utf-8?B?VFRvWUlWQSt2ckFOV3JyMmNmejNEYjJ6QVRJUi9JaVJSYzdiajVMTjJPaW5L?=
 =?utf-8?B?S1NZYk1XKzhiMW81ZVRlSGhoNSt3cm5YZEprVmE1S2hibUNsWlRBUkYyc1F6?=
 =?utf-8?B?d005NWNaRGpvR08raFdtVWdOc3pxc3V2aXZwWjE0d1R4aksxOEl5R1ArU0FS?=
 =?utf-8?B?N2gzcDQvcnJ1M3J3WEhVcDVKMS9idnMxeERqaElmZDhXN1NLTGRNWmRKZVEr?=
 =?utf-8?B?c0M1b1JZM2o2NXpZZGJENW01VzFJSTFYNmJDNDdGQ2RkQXlzeDR0OHRvaElu?=
 =?utf-8?B?T1lyS3poS3FuR1pwR1hob2swaVdRZzA0WjY5YWdBQmdsdkh0NzF2M3ljSjB2?=
 =?utf-8?Q?26EFUK81d5HAB+2ddJpQF9stm?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54128e1a-e30c-4da1-af86-08dbca0078ce
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 02:19:18.0706
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6Cih4hfMxuAT+O9ePajcrK3dW/dlVDQvni6uihLODTxxKRxZ46an0O6NjW5+xxHJtL6uAxI5DlC6kRwA+bF8tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5773
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 10 Oct 2023 19:19:43 -0700 (PDT)

On 10/10/23 8:17 AM, Andy Shevchenko wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as it is
> going to display an appropriate error message in case of a failure.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/hte/hte-tegra194.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c
> index 339ff5921ec8..30ef1750a9fa 100644
> --- a/drivers/hte/hte-tegra194.c
> +++ b/drivers/hte/hte-tegra194.c
> @@ -731,10 +731,8 @@ static int tegra_hte_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	ret = platform_get_irq(pdev, 0);
> -	if (ret < 0) {
> -		dev_err_probe(dev, ret, "failed to get irq\n");
> +	if (ret < 0)
>  		return ret;
> -	}
>  	hte_dev->hte_irq = ret;
>  	ret = devm_request_irq(dev, hte_dev->hte_irq, tegra_hte_isr, 0,
>  			       dev_name(dev), hte_dev);

Reviewed-by: Dipen Patel <dipenp@nvidia.com>