Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From:   Rob Herring <robh@kernel.org>
To:     Wesley Cheng <quic_wcheng@quicinc.com>
Cc:     bgoswami@quicinc.com, lgirdwood@gmail.com, broonie@kernel.org,
        gregkh@linuxfoundation.org, robh+dt@kernel.org,
        konrad.dybcio@linaro.org, conor+dt@kernel.org,
        linux-usb@vger.kernel.org, andersson@kernel.org,
        Thinh.Nguyen@synopsys.com, srinivas.kandagatla@linaro.org,
        linux-kernel@vger.kernel.org, agross@kernel.org,
        mathias.nyman@intel.com, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, perex@perex.cz, tiwai@suse.com,
        krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org
In-Reply-To: <20231011002146.1821-26-quic_wcheng@quicinc.com>
References: <20231011002146.1821-1-quic_wcheng@quicinc.com>
 <20231011002146.1821-26-quic_wcheng@quicinc.com>
Message-Id: <169699146438.2560961.3220166947763848754.robh@kernel.org>
Subject: Re: [PATCH v8 25/34] ASoC: dt-bindings: Update example for
 enabling USB offload on SM8250
Date:   Tue, 10 Oct 2023 21:31:04 -0500
Precedence: bulk


On Tue, 10 Oct 2023 17:21:37 -0700, Wesley Cheng wrote:
> Add an example on enabling of USB offload for the Q6DSP.  The routing can
> be done by the mixer, which can pass the multimedia stream to the USB
> backend.
> 
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
> ---
>  .../devicetree/bindings/sound/qcom,sm8250.yaml    | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/sound/qcom,sm8250.example.dts:97.44-45 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/sound/qcom,sm8250.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1427: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231011002146.1821-26-quic_wcheng@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.