Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <291f03f9-72aa-2842-b44a-c88c812df4f1@amlogic.com>
Date:   Wed, 11 Oct 2023 10:50:04 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH V2 1/4] dt-bindings: clock: add Amlogic C3 PLL clock
 controller bindings
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
Cc:     linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Chuan Liu <chuan.liu@amlogic.com>
References: <20231010062917.3624223-1-xianwei.zhao@amlogic.com>
 <20231010062917.3624223-2-xianwei.zhao@amlogic.com>
 <20231010132151.GA557938-robh@kernel.org>
From:   Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <20231010132151.GA557938-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFRpengyUFpUek5WcFR3OEw2OURCYTBhWXVRT2JXa2xnSjM5WlBteGpXUWhr?=
 =?utf-8?B?V09DSElNWXhhcHFDUUVKQWdkZXdOM2ZTYjlzWmhrUUowTGU5WmJSVmNZZFh5?=
 =?utf-8?B?Lzg0MnkwM09qRWdNei9Kc1JYNXBOR2FJQ2xLT2dCTjYxaC9sNzFySmxyWTYx?=
 =?utf-8?B?QTNmdmx3NXBoRENpRGRKL1N6V0duU2s4enFXY2craTJ3UVdZZ2Y2d05yVW44?=
 =?utf-8?B?Q2szbFN0THlqSTFkVUxyZGpXQnlRRmJoc2haNjZPWE95V0U3K1kwdm1LaTFF?=
 =?utf-8?B?anhVOW5nZDBFeGxwNW9YQWVKN2xPS0ErdFlHQXlzZDRLTFBJaks0Rk96Z0dU?=
 =?utf-8?B?eDFBKzBNSjhSVVlJZW1hVUJYVm5zdlR1YW80SnY0eGZzdTR2SlpPOUFZM2pp?=
 =?utf-8?B?UzFwenRNeCtHeC9BMDg3a3l1N1NoOXk5T1djVlVGNXp0QW56RjdLbkNiMVdm?=
 =?utf-8?B?Smx4SkdQWEJnVEROcElNZHU2cFdKY3BRQjhEZlJJQm9JOENBRE0wSWZQd2xX?=
 =?utf-8?B?bzRpcHppRTE4MWozRmhBRXUwRzBXT2libElLZEZtb1JCUWFBWEtTQ21TTTlN?=
 =?utf-8?B?SHJjTThEN3l2T1BHUkh2ZlFxQVN4Lzl2UHpiL0prYXJMNThud2M0ZjF5STM4?=
 =?utf-8?B?L1FpQUZ1bEhLWEJ6WVRVc3JZZSt1K0hVb0NaWkdSeE1FK2N4b3paNCszQkFq?=
 =?utf-8?B?NnN4VDdCVHN6d3piMnBxS2srU01KWXc0ODY0YldLSnFjTDU0WndZWTJSWUNF?=
 =?utf-8?B?WHBiVEZVbDVLUXFFcTJGSlZRQ25DM1NvbXJSUktXbTNqWDVBNFhrK0VkL2x5?=
 =?utf-8?B?ZlpsSHlZNkhNUDYyb2ZOdHhBTTlGWkdaRGUyYWFaNlJzODdWYUJsWC92dW1z?=
 =?utf-8?B?TE9DL0hVZ1NEZjZhUGdKcXpTQkFUMGRXZ3pwRmdzMjB1QXk3QXR3K0ZwVm1z?=
 =?utf-8?B?RXFwanpSR0VaUXVxY2tvcklOOXJBa09RcjE4NjIvblUzcVcwdy81cnZidWt0?=
 =?utf-8?B?SEswa3VEc3hqOUNIemVjdjQrTXlxK25HSlo2NmhPNHlSNG1BQU53R3ZDbkF1?=
 =?utf-8?B?ckdSU2JzUXQvZWJZRjdPYXlTU252SWVmQ1lEUFVHeTI0YmgvN01yQ2tjOVdC?=
 =?utf-8?B?MFdma3czZUJhVEE0UmtabkRFRWFFNHpOY3VKMVljVmpibUxiT21kWjFJbWxM?=
 =?utf-8?B?WDVCcHNaTFBiT3B6TkZwSFpUcUgwY0RPWllOZWNCOGpZL1pqTTE2dEE2Ny9r?=
 =?utf-8?B?ay9henE5dTJQYjA2dzZFaGU3SUxza1M1TlZYN2NUM3RHTG9TQ0c1OEgrYUlL?=
 =?utf-8?B?ZFRaU0xYaHhvSkFYV3ZQNlJqN3hRWjhyMkI5NktnSkp0TVRtNjlabEpwaTV1?=
 =?utf-8?B?Z3hoU0VYTnEvTUQ3UWE3N2Y4RVltMU9PRXFqT216S1dlOU1xSkxmNTRPR3dy?=
 =?utf-8?B?aUFoWXhYZUxKVkwrQURQWlJNQU5BSHZzT2tzSkFoWFZSMzhQR3NRYnhUcFNv?=
 =?utf-8?B?ZkZVNkpTYm03YnlRZUEvZGxuYjNzOGVQWkpFNTZXbFBZWTh4UGU5ZHdnV2pZ?=
 =?utf-8?B?SU5wTldpZUIxZnJwM2xWVmQvMzc3bzNnYkxWOEZDRzFyRGFLWU9MZXJyd2h6?=
 =?utf-8?B?aU5pRHZKdW1ROTd2OXdZYUlWK0F6NG9janI0bHFQMitzTFR3bE1BL0s3WFZQ?=
 =?utf-8?B?dUtNY2diTTE2SVYvdkIwMlB2WjBoaWlkMFNQR2EwYVdqUU5yQmJGa1I4QXh5?=
 =?utf-8?B?a2YwTXRHdXRUZ2tWZzRBaWl2bm8vZG5FbjY2QkFDeHd1S2tBNStQVFhUbDYz?=
 =?utf-8?B?ZXliRURKVXhrcDJhZUFCMnk3UUtISEFoSENlWWdUQjlpZlo4a1Q3N3lzOVdC?=
 =?utf-8?B?MWx0YjJad2VXdDc1MWRTc0xkYnkzbUwrS3BVeExZS211UkluaE5JTC9IRXU4?=
 =?utf-8?B?MzEzdEQrckgrY3lFOHFYcGpOMTczeGJnMUltbHo0QUErWjIycXd2ejJKL1lr?=
 =?utf-8?B?RzlPTm5UaUNxa0FnQWRkT0FqRFZHL2g0bHpFZVB6SXByUmxSTW9BaWRCMmJ2?=
 =?utf-8?B?Vnh3VGJyNjkzSWpKT2duSmlhcS9aUjRWc2U5NXVyV3NBZzEybUtLc2xUYm5V?=
 =?utf-8?B?ZTVBZE51OW9BbWJZZWdubkMyUFY3WWYzc0NBSjhkNWxpaEdsbWRPZmtrKzBJ?=
 =?utf-8?B?S1E9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ee20711-979f-44cf-3f98-08dbca04c94f
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 02:50:11.4204
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FgPGxfY1snTYQtwNy1OCGKA40pddhv2lKxON3iQK8MbcapvYG9AgtJmMZq0NalcXRCBEVF6POsxxAKh98r4UWfJzROllW87BohBbs5t8YgE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR03MB5771
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 10 Oct 2023 19:50:32 -0700 (PDT)

Hi Rob,
     Thanks for your advise.

On 2023/10/10 21:21, Rob Herring wrote:
> [ EXTERNAL EMAIL ]
> 
> On Tue, Oct 10, 2023 at 02:29:14PM +0800, Xianwei Zhao wrote:
>> Add the C3 PLL clock controller dt-bindings for Amlogic C3 SoC family
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>> V1 -> V2: Fix errors when check dtbinding use "make dt_binding_check"
> 
> Your patches aren't bisectable. It's fine if you want to combine patch 1
> and 2 into 1 patch. Or just use the raw numbers here instead of the
> header.
> 
I will combine patch 1 and 2 into 1 patch in V3.
>> ---
>>   .../bindings/clock/amlogic,c3-pll-clkc.yaml   | 59 +++++++++++++++++++
>>   .../dt-bindings/clock/amlogic,c3-pll-clkc.h   | 42 +++++++++++++
>>   2 files changed, 101 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/clock/amlogic,c3-pll-clkc.yaml
>>   create mode 100644 include/dt-bindings/clock/amlogic,c3-pll-clkc.h
>>
>> diff --git a/Documentation/devicetree/bindings/clock/amlogic,c3-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,c3-pll-clkc.yaml
>> new file mode 100644
>> index 000000000000..a646992917b7
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/amlogic,c3-pll-clkc.yaml
>> @@ -0,0 +1,59 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) 2022-2023 Amlogic, Inc. All rights reserved
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/clock/amlogic,c3-pll-clkc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Amlogic C3 serials PLL Clock Controller
> 
> s/serials/Serials/
> 
Will fix
>> +
>> +maintainers:
>> +  - Chuan Liu <chuan.liu@amlogic.com>
>> +
>> +properties:
>> +  compatible:
>> +    const: amlogic,c3-pll-clkc
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    minItems: 1
>> +    items:
>> +      - description: input pll_in
>> +      - description: input mclk_pll_in
>> +
>> +  clock-names:
>> +    minItems: 1
>> +    items:
>> +      - const: pll_in
>> +      - const: mclk_pll_in
>> +
>> +  "#clock-cells":
>> +    const: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - clocks
>> +  - clock-names
>> +  - "#clock-cells"
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h>
>> +    apb {
>> +        #address-cells = <2>;
>> +        #size-cells = <2>;
>> +
>> +        clkc_pll: clock-controller@8000 {
> 
> Drop unused labels.
> 
Will delete clkc_pll.
>> +          compatible = "amlogic,c3-pll-clkc";
> 
> Your indentation is not consistent.
> 
Will fix it in V3.
>> +          reg = <0x0 0x8000 0x0 0x1a4>;
>> +          clocks = <&clkc_periphs CLKID_PLL_IN>,
>> +                   <&clkc_periphs CLKID_MCLK_PLL_IN>;
>> +          clock-names = "pll_in", "mclk_pll_in";
>> +          #clock-cells = <1>;
>> +        };
>> +    };
>> diff --git a/include/dt-bindings/clock/amlogic,c3-pll-clkc.h b/include/dt-bindings/clock/amlogic,c3-pll-clkc.h
>> new file mode 100644
>> index 000000000000..aa731e8fae29
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/amlogic,c3-pll-clkc.h
>> @@ -0,0 +1,42 @@
>> +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */
>> +/*
>> + * Copyright (c) 2023 Amlogic, Inc. All rights reserved.
>> + * Author: Chuan Liu <chuan.liu@amlogic.com>
>> + */
>> +
>> +#ifndef _DT_BINDINGS_CLOCK_AMLOGIC_C3_PLL_CLKC_H
>> +#define _DT_BINDINGS_CLOCK_AMLOGIC_C3_PLL_CLKC_H
>> +
>> +#define CLKID_FIXED_PLL_DCO                  0
>> +#define CLKID_FIXED_PLL                              1
>> +#define CLKID_FCLK_DIV40_DIV                 2
>> +#define CLKID_FCLK_DIV40                     3
>> +#define CLKID_FCLK_DIV2_DIV                  4
>> +#define CLKID_FCLK_DIV2                              5
>> +#define CLKID_FCLK_DIV2P5_DIV                        6
>> +#define CLKID_FCLK_DIV2P5                    7
>> +#define CLKID_FCLK_DIV3_DIV                  8
>> +#define CLKID_FCLK_DIV3                              9
>> +#define CLKID_FCLK_DIV4_DIV                  10
>> +#define CLKID_FCLK_DIV4                              11
>> +#define CLKID_FCLK_DIV5_DIV                  12
>> +#define CLKID_FCLK_DIV5                              13
>> +#define CLKID_FCLK_DIV7_DIV                  14
>> +#define CLKID_FCLK_DIV7                              15
>> +#define CLKID_GP0_PLL_DCO                    16
>> +#define CLKID_GP0_PLL                                17
>> +#define CLKID_HIFI_PLL_DCO                   18
>> +#define CLKID_HIFI_PLL                               19
>> +#define CLKID_MCLK_PLL_DCO                   20
>> +#define CLKID_MCLK_PLL                               21
>> +#define CLKID_MCLK_PLL_CLK                   22
>> +#define CLKID_MCLK0_SEL                              23
>> +#define CLKID_MCLK0_SEL_OUT                  24
>> +#define CLKID_MCLK0_DIV                              25
>> +#define CLKID_MCLK0                          26
>> +#define CLKID_MCLK1_SEL                              27
>> +#define CLKID_MCLK1_SEL_OUT                  28
>> +#define CLKID_MCLK1_DIV                              29
>> +#define CLKID_MCLK1                          30
>> +
>> +#endif  /* _DT_BINDINGS_CLOCK_AMLOGIC_C3_PLL_CLKC_H */
>>
>> base-commit: 57b55c76aaf1ba50ecc6dcee5cd6843dc4d85239
>> --
>> 2.37.1
>>