Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp545072rdg; Tue, 10 Oct 2023 20:01:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtyCUNJ1zBqBmZIjIKg5KQ9fLUYP0CoSNTqgWC2f7zSMXNJuSeHRf7jR2nYDL/TIFEwnwS X-Received: by 2002:a05:6808:1386:b0:3ae:5a97:7660 with SMTP id c6-20020a056808138600b003ae5a977660mr25266438oiw.57.1696993271090; Tue, 10 Oct 2023 20:01:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696993271; cv=none; d=google.com; s=arc-20160816; b=YR/uFBR7QXqhQ7Uy8J/KOgxXnceLiIS9LOEamKgSR8PRkdAvMoGInE40PAmn1mg24a rXJOcnuVN93aASUGHrF+ikEW9rMSypVyaT67OZaAqUB+ezpEF4Ec2E3dJc4j9Utizu0D yct++uFl5q4pd6ikC9iY3g2esj2XV2uOV+mLgb6NDAq+qcWLAEj48T3fz5ita3S0SCg6 5uTCyYi6/qFt7ZrMh8HJJPJ/q8B2dbJzhyYqj94TZV70dTPCxQRqJA4xhLVNiulNm47j OHGlCqbhSV8nl3Cu34A/UWkh4XuhRiGLdyWRtlKwwzA7ABcJXE/FA/AJ2+tbJFHuDKiq WO6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=C2f5PVWad+FTaFjX9ZF2iLM7HseZZgGNPg6dmQnCITA=; fh=5zPsr0ZacDLGSiskc1nMwkucL1t80vRj22y8+0U/hd0=; b=JIT8zTgjURxJ+RFAEv5K8Z1JlE8AnVQeZfQm04CCXmTIwO+0iZPxO7RrMXmHOitV12 j0UGCEgGMQeI3PwnYkuwrpGluPx0b7V7aoddTHjukUplYdOaKNS4m9brVcFftzfc/y0u u65Z/qLiR1H52NLOAlXSuDYDOVp1TD1MZafyn28w6iaPeZfvR9Zzs6Z6Mj58aWv6IN8Q 5/8prII2HTa0Z2nqL43crkCTDRWU1GiNSwZoCC91z/1s42Zz3syKQq7+J57qLtcVr9ZC BEzDKk6URwlvcY6aqmDtwV27NUxEvW26080LaHEF2CxN3nbZJgRLZZql1mJFfioTmZQb RsnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=htKzSa2k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id v135-20020a63618d000000b0059c02a0f7e3si2748840pgb.343.2023.10.10.20.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 20:01:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=htKzSa2k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id AC2C9807C869; Tue, 10 Oct 2023 20:00:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344901AbjJKDA0 (ORCPT + 99 others); Tue, 10 Oct 2023 23:00:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343612AbjJKDAZ (ORCPT ); Tue, 10 Oct 2023 23:00:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74B2A92 for ; Tue, 10 Oct 2023 20:00:24 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPS id 125AFC433C9; Wed, 11 Oct 2023 03:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696993224; bh=H6zMY1CykdTxHKp9W2Zsgj0WQod7yLkCbShgqc2quBo=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=htKzSa2kkqPt5I4hkna/91UV0+3qVATM5Nd/+f7hTslNRdssh8jDmO3yYc0v5xmM2 oWlRfes7K2GJDasURDy26MZuZBN7b3SkFG5zmFLaq4yZ8L5r7ZLur7ipTvJx50H07+ O9khDsxgT21PzxYSLa+ww/4FWqh4aIx+eq9ubd3sNuEUortz6E/AKI5YQgbavIwxih vln8lBEJyqqHjSqlpGMS6mggjQfBvo3oest1UTTmxsF03V7z6I0mddqKLwe7VqwSaA hLZBlMmX84DxW19vNIrt3YsmUI0ViVTeHmKi5sKorWeElPlXVJ+w0ewGj1DsDVioei COT/ySxJjLKHw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id EAC52C595C5; Wed, 11 Oct 2023 03:00:23 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v3 1/1] ethtool: Fix mod state of verbose no_mask bitset From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169699322395.28899.12018945004976045331.git-patchwork-notify@kernel.org> Date: Wed, 11 Oct 2023 03:00:23 +0000 References: <20231009133645.44503-1-kory.maincent@bootlin.com> In-Reply-To: <20231009133645.44503-1-kory.maincent@bootlin.com> To: =?utf-8?q?K=C3=B6ry_Maincent_=3Ckory=2Emaincent=40bootlin=2Ecom=3E?=@ci.codeaurora.org Cc: mkubecek@suse.cz, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com, horms@kernel.org, thomas.petazzoni@bootlin.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 10 Oct 2023 20:00:36 -0700 (PDT) X-Spam-Level: ** Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 9 Oct 2023 15:36:45 +0200 you wrote: > From: Kory Maincent > > A bitset without mask in a _SET request means we want exactly the bits in > the bitset to be set. This works correctly for compact format but when > verbose format is parsed, ethnl_update_bitset32_verbose() only sets the > bits present in the request bitset but does not clear the rest. The commit > 6699170376ab fixes this issue by clearing the whole target bitmap before we > start iterating. The solution proposed brought an issue with the behavior > of the mod variable. As the bitset is always cleared the old val will > always differ to the new val. > > [...] Here is the summary with links: - [net,v3,1/1] ethtool: Fix mod state of verbose no_mask bitset https://git.kernel.org/netdev/net/c/108a36d07c01 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html