Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp549113rdg; Tue, 10 Oct 2023 20:10:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGSXdKAdNi7tmRRXMbju7oxNAyTcl6O452Mx4JwcYc7x8CBk7fLEAo8jvd83a+LVQ3C9IW X-Received: by 2002:a05:6871:293:b0:1d0:cbc7:1c92 with SMTP id i19-20020a056871029300b001d0cbc71c92mr25141839oae.28.1696993842857; Tue, 10 Oct 2023 20:10:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696993842; cv=none; d=google.com; s=arc-20160816; b=02W/AzOSB7S8uwrkUEX5OwxUP1E4Kod76pfyxSQl8zN09bmAzwYa17uzHYAojIqKvn fObMP96Qo2YYN3eQefDTpBBm8/5SPDeKhxoWWG02oRmIU5ddMAWbuMrkX5RbMTUuORbE YzdFjA8UIJ7wmNnekCX+MHZz4Rt4uCKAvx4HZB5h+jlE56Ru7plq4u4vzE5Qr2krQUhq WdQBQdI8UUpOT/1m9RKIJ1Raa4uvZ9I87mOSQX6xN7B6Wno9uP06XYi0AUoUpWnaacPZ 9SIGM0d7VEJaduMe8IKpOsd3rfx3tZUbD1ITCna1KtrJ4uSWmeLPczN7k9qlD6ec45/a 0YbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=cvz/+b9NoprvQ4hd+MD1rCI335n8E12kQt40mUaoKoQ=; fh=Z3JasQqfRn/Vkez4MYlAX8R8cF8ZY4pvsRIDDWMpzvY=; b=TEOy9aMT32wn171kwIOlLEqB1N7Qaa7NZmD8GTx1nNNomBnU08lozlTUpEuaEeId6I W+G3xeP0AjC2AB9lBN6XOgSjWhQvGGWNmjg12KNUAxdTSvPXu2z9EG0WG1L+4PvUhb7G JqneNe9gDeRsmws+o82bsZe59eUd14QVsgTcG+NH0XlmZXm2A5lVrew2PDBSxDhpBE2N bIEsziHvU84IZjv+oGgKij8bm/YC2NSR7QQLpjhWDRtNKD/xZ299/4ofZv4iPcAb/zgm jzagOu8Zi3W7N2WUP+NzhMMBPfnusR4KQBEdugHWs0xEhzGdCXjASgRC37kTRz11CuYq xa3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uliMU3Db; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id d6-20020a056a0010c600b0068faabd47fcsi4054918pfu.210.2023.10.10.20.10.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 20:10:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uliMU3Db; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E277F80B18BB; Tue, 10 Oct 2023 20:10:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344939AbjJKDK2 (ORCPT + 99 others); Tue, 10 Oct 2023 23:10:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344895AbjJKDK1 (ORCPT ); Tue, 10 Oct 2023 23:10:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 453CA91 for ; Tue, 10 Oct 2023 20:10:26 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPS id C6D9CC433CA; Wed, 11 Oct 2023 03:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696993825; bh=chhBCKkV6ZerimGonFhRxw877THTC2UOjXgTOzI0cxw=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=uliMU3Dbeg2uHNffO1m5HRHiMQDIb8dS3e0RUtjyg+HY5B2fNk7N11YHjoaVRDqq4 bXKTY/R5kLh3EEtAHu+vSsMVKcUnTgP6sWUsNs80b5qwevgGwWV1wUQ0+LTQyldhQA kxFLw1tr8yvSdfeyKHqRjH6p0APsUBtUTYrtRGFOsfv3L9uialQ/zLO7cEQSiC3Eqo Qlj5vE91gMnlMSbt2Rw6LDBFsRyra/9QMMDJdWpSvdFzFbnWLMBQ+2TPIiUW0cfhOO 7Z4nfgUr0taYgSK/WA9u675nIyGq5DRczNSOCHh50qiymoe1Ude+FyCNKSLHZZC5VC 33DxgP5gqEHtw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id A7C24E11F43; Wed, 11 Oct 2023 03:10:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169699382568.3301.6960021020124970856.git-patchwork-notify@kernel.org> Date: Wed, 11 Oct 2023 03:10:25 +0000 References: <20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com> In-Reply-To: <20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com> To: Javier Carrasco Cc: peter@korsgaard.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 10 Oct 2023 20:10:38 -0700 (PDT) X-Spam-Level: ** Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 10 Oct 2023 00:26:14 +0200 you wrote: > syzbot has found an uninit-value bug triggered by the dm9601 driver [1]. > > This error happens because the variable res is not updated if the call > to dm_read_shared_word returns an error. In this particular case -EPROTO > was returned and res stayed uninitialized. > > This can be avoided by checking the return value of dm_read_shared_word > and propagating the error if the read operation failed. > > [...] Here is the summary with links: - [v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read https://git.kernel.org/netdev/net/c/8f8abb863fa5 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html