Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp556670rdg; Tue, 10 Oct 2023 20:34:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8JP89dl4q8WORWLADix6jSgmdWP+QaDmudIqAJkHgI1+j4ClvaTI5G2Q8zv17FmtfXD5F X-Received: by 2002:a81:4787:0:b0:59b:61c2:e8db with SMTP id u129-20020a814787000000b0059b61c2e8dbmr22855283ywa.49.1696995279185; Tue, 10 Oct 2023 20:34:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696995279; cv=none; d=google.com; s=arc-20160816; b=qLKP7ALknWMMlPQOUYtLcbHksd33RFhHiqag0xF4gFFe7GOYZq27ZQhPomMJ2x7Sjs OKsuc6VrhPWY72p5gZHk7tVzteML0kQLJMTFtBCbOw472Gc8EtYWyag6O1MSgEzH8TFR Nw6UYiaCSRR2wmOVnWV7CDa+Hoy3i8XCT/Yl3r4ryXfNg7ZR7xD5snfCrhQbPAXqfOf3 ej4qH2JX/KSdI3OpMEf42K2Y2FsPMaH459fo2lVprhbNvxyzA8kgLYJ4IU+RvQwqoABS id19aENspaEJRfkG519YFzBAOTkQJX/R4fY8adzKm0+qAaOAa2uH3x53dtmMMclHJOQc R+1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=vuLs/ZNj2aw8cpmUoC70Uox5QIxpc0c91hNSezSH85E=; fh=pcDa2ftpqHzaNAntTpqoHisFjaUIwNwqMUguW+DRDcE=; b=Qdczv/L1elHH8a9gfZlumtgvM8dMPNfAN4qCKQn/b9WPVEr4Rz58zPT1c7Q3/wIpU4 cG41jqfwV2CqIQK9ZgYxQMd68YyKJWgpCOAPSXwnKfbUu4Easi3aI+2EBTWX2hXqETTi PDt3u/CM3MgSsjedXmOYyi8T+R1Th4I3F/8AslEVn0hNIbWocD1F4HEmDMeqQPW055Nf 855AxoYzNY4vwfkLfjIy6VsJ+QF+s89ib7IZysav3NcOtuxCkUQBu1oao/TWCND8PcMB k4HdKe5R1OTnrilu7TP3i1RbFOxh7oZQlCvpnxr5cGOEt6CcS51+1+FoRbjhOpWMPvW5 +WLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id r22-20020a632b16000000b0056fc3ceaba4si12850074pgr.432.2023.10.10.20.34.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 20:34:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id F3CDC8097E79; Tue, 10 Oct 2023 20:34:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344988AbjJKDeb (ORCPT + 99 others); Tue, 10 Oct 2023 23:34:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344777AbjJKDe3 (ORCPT ); Tue, 10 Oct 2023 23:34:29 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EAB592; Tue, 10 Oct 2023 20:34:28 -0700 (PDT) Received: from dggpeml500025.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4S4yvn6RM6zLpxZ; Wed, 11 Oct 2023 11:30:29 +0800 (CST) Received: from [10.174.176.117] (10.174.176.117) by dggpeml500025.china.huawei.com (7.185.36.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 11 Oct 2023 11:34:25 +0800 Subject: Re: [PATCH] doc: blk-ioprio: Standardize a few names To: , , , CC: , , , , , , , References: <20231009100349.52884-1-yizhou.tang@shopee.com> From: Hou Tao Message-ID: <42882d2b-e076-74df-e0bc-2b6c79986d3a@huawei.com> Date: Wed, 11 Oct 2023 11:34:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20231009100349.52884-1-yizhou.tang@shopee.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.176.117] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500025.china.huawei.com (7.185.36.35) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-0.5 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 10 Oct 2023 20:34:37 -0700 (PDT) On 10/9/2023 6:03 PM, yizhou.tang@shopee.com wrote: > From: Tang Yizhou > > Our system administrator have noted that the names 'rt-to-be' and > 'all-to-idle' in the I/O priority policies table appeared without > explanations, leading to confusion. Let's standardize these names in > line with the naming in the 'attribute' section. > > Additionally, > 1. Correct the interface name to 'io.prio.class'. > 2. Add a table entry of 'promote-to-rt' for consistency. > 3. Fix a typo of 'priority'. > > Suggested-by: Yingfu Zhou > Signed-off-by: Tang Yizhou Reviewed-by: Hou Tao > --- > Documentation/admin-guide/cgroup-v2.rst | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst > index 4ef890191196..10461c73c9a3 100644 > --- a/Documentation/admin-guide/cgroup-v2.rst > +++ b/Documentation/admin-guide/cgroup-v2.rst > @@ -2023,7 +2023,7 @@ IO Priority > ~~~~~~~~~~~ > > A single attribute controls the behavior of the I/O priority cgroup policy, > -namely the blkio.prio.class attribute. The following values are accepted for > +namely the io.prio.class attribute. The following values are accepted for > that attribute: > > no-change > @@ -2052,9 +2052,11 @@ The following numerical values are associated with the I/O priority policies: > +----------------+---+ > | no-change | 0 | > +----------------+---+ > -| rt-to-be | 2 | > +| promote-to-rt | 1 | > +----------------+---+ > -| all-to-idle | 3 | > +| restrict-to-be | 2 | > ++----------------+---+ > +| idle | 3 | > +----------------+---+ > > The numerical value that corresponds to each I/O priority class is as follows: > @@ -2074,7 +2076,7 @@ The algorithm to set the I/O priority class for a request is as follows: > - If I/O priority class policy is promote-to-rt, change the request I/O > priority class to IOPRIO_CLASS_RT and change the request I/O priority > level to 4. > -- If I/O priorityt class is not promote-to-rt, translate the I/O priority > +- If I/O priority class policy is not promote-to-rt, translate the I/O priority > class policy into a number, then change the request I/O priority class > into the maximum of the I/O priority class policy number and the numerical > I/O priority class.