Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Wed, 11 Oct 2023 12:40:33 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        David Airlie <airlied@redhat.com>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Gurchetan Singh <gurchetansingh@chromium.org>,
        Chia-I Wu <olvaffe@gmail.com>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        Akihiko Odaki <akihiko.odaki@daynix.com>,
        =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Ragiadakou, Xenia" <Xenia.Ragiadakou@amd.com>,
        "Stabellini, Stefano" <stefano.stabellini@amd.com>,
        "Huang, Honglei1" <Honglei1.Huang@amd.com>,
        "Zhang, Julia" <Julia.Zhang@amd.com>,
        "Chen, Jiqian" <Jiqian.Chen@amd.com>
Subject: Re: [PATCH v3] drm/virtio: add new virtio gpu capset definitions
Message-ID: <ZSYnQbHUecuUlwvr@amd.com>
References: <20231010135722.1142265-1-ray.huang@amd.com>
 <2f8bcce1-6551-6c2d-481c-67502c82bc68@collabora.com>
 <2c162058-288c-9e9e-48d5-3b2ddb0cc1fa@collabora.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2c162058-288c-9e9e-48d5-3b2ddb0cc1fa@collabora.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3qNtL2aDZ0Ri1Q48TZ7YFHCCsBNyZrocvoeCGnK5sSHJiNW1uvRvRSYaFgx7?=
 =?us-ascii?Q?QKLQGnCPCbNFnrqgylSoUPiwSF5pAmHhEnkkD37NDx6FdPbDm63rGo7x4jej?=
 =?us-ascii?Q?JRBd6++sQHoHmWWAdw89w9lBV28kx/W66jo5a+F6F2erxJz3h7sR+FbF7wCk?=
 =?us-ascii?Q?Csm08TdoS3RA7D0ZiKP7/MSGxu/BMWMBX7VUCtFILi1CJnAMboWesPHqqcFk?=
 =?us-ascii?Q?lQkO1oCqbAWJIFebqin+VWUZ5+MrfsAbLCJXB/VawmKuf01jvMA+fjGpzSXI?=
 =?us-ascii?Q?AWkgXAOQLOCdZBwdgKoySUfL0riChmJvCSt6AkkcXhsSnCvmuqaG5Vpz1dXy?=
 =?us-ascii?Q?arf8oBu00VNHp9zoDBgkgLV7v0bHQUGw2p3UODg09RVNqG6qllkZ7sbwl6PY?=
 =?us-ascii?Q?YDTsaBLkP7X6mgzrR783YJ+yMQFSa3rI4nARP8fkoH9kLVkooHekl4gfQQec?=
 =?us-ascii?Q?EVfNVIS1GDWbgfRuvL0yWUEjV7HPqdPLh3YJGFbawnphKiwqG9Xq/uizMXXp?=
 =?us-ascii?Q?JEtTjupuv3TfPwk+5p1l2FIGqEuyYOuX9WSL1HpEXkvHDPup+8/fOEvdzv6a?=
 =?us-ascii?Q?CFnJbReGKW3mlSnYeIzKKrHGAgRioldE8mwu1DtIKDY4uQnPRJGfOXYksliC?=
 =?us-ascii?Q?HpdectHpY8laDl0L4tWucir9budfWggHUBfulWOakYZVRI11d3QwOOPhE1vW?=
 =?us-ascii?Q?BUorL3bzSRR3hPia3HDzCfkbigLZLlhw/WNhSeajrMxVgDbG1iL+nkIosS5I?=
 =?us-ascii?Q?zNp3uuAhi5N5wvA6hZpSdWeAEmaUkZnMTTQtqgS/WqxTshZG65ARRIs2iGKJ?=
 =?us-ascii?Q?vylWHNku/trhO2ksds0vSOlSc5q71L1MdZhnwPlohSCm6jKFoI/S1voewJ0+?=
 =?us-ascii?Q?TekcI9pd4E0Ae3/ljncbqvpCrtHPFnUHGJSAviD4O2Q7LqOLxHv40RUqaaD8?=
 =?us-ascii?Q?duhoSANOQrO0t8puxxuMImYFyiTfMotTHFbWTBfJlG/ot1X6twT4XzIOhfof?=
 =?us-ascii?Q?Z80R2LAA/wioESdDT3obriBYWmAP7sGIJD/2QxDygo6QKcZqhGNNgSOCspJK?=
 =?us-ascii?Q?LMHXa3uf4alqa4/0UvWn5tEeTKNzhKWLBWC2XP7dNB+nKrEurKvStOz1/98L?=
 =?us-ascii?Q?ClzXN6bu2CNyY3NyN5stOC8Cirm15pDKdomcYznaQ1u5FfHapRWlvccZ5+7m?=
 =?us-ascii?Q?YarhfmHrbyS9Jty0Lpfvd+jrDmNj2dixAFWxCi7Q9TkY1ofgpCPsCLHZl8+J?=
 =?us-ascii?Q?03btEsZMnY4FphZ+JQOk0Mxx8XwoMxY4y+ica3vk9JGfGH2D3RGBOgj1rhcs?=
 =?us-ascii?Q?tSe5nVUgbPrUwaNppgeo8ocCsnjsMWXHb5wVtOKgRmUXXN4ALi9OvQzt8LO8?=
 =?us-ascii?Q?GivBNYwP0+nQalyXRwPJK7DMTUP8Ei6/nTJvm6579Ol2SStxi8zGIeDvBFd0?=
 =?us-ascii?Q?S7j/WOlCvZUWS5UpLv5YeRKG5N55OljwtmccEveCHn2UMBdprgRajeCbqJH8?=
 =?us-ascii?Q?zkZ3Gm95WlcMp1MLmg2gIkEl6UQDjYepAN7oH8smcIecEKAmwGoRU3FHpI8u?=
 =?us-ascii?Q?B9K5kWF88s8s0OmQ5WdRpkNOIve5uALhP56/xMpM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25e47431-ff28-4987-19d7-08dbca144368
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 04:40:58.3992
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dEAOKZaSmITYylutvZ7BimmnMAB4oIwXEtwA5UOzcBmlBwEs08rrL6PHKTuG9y93CJIMVoWZbweB6XlFlauI7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8443
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 10 Oct 2023 21:41:49 -0700 (PDT)
X-Spam-Level: **

On Tue, Oct 10, 2023 at 11:52:14PM +0800, Dmitry Osipenko wrote:
> On 10/10/23 18:40, Dmitry Osipenko wrote:
> > On 10/10/23 16:57, Huang Rui wrote:
> >> These definitions are used fro qemu, and qemu imports this marco in the
> >> headers to enable gfxstream, venus, cross domain, and drm (native
> >> context) for virtio gpu. So it should add them even kernel doesn't use
> >> this.
> >>
> >> Signed-off-by: Huang Rui <ray.huang@amd.com>
> >> Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> >> ---
> >>
> >> Changes V1 -> V2:
> >> - Add all capsets including gfxstream and venus in kernel header (Dmitry Osipenko)
> >>
> >> Changes V2 -> V3:
> >> - Add missed capsets including cross domain and drm (native context)
> >>   (Dmitry Osipenko)
> >>
> >> v1: https://lore.kernel.org/lkml/20230915105918.3763061-1-ray.huang@amd.com/
> >> v2: https://lore.kernel.org/lkml/20231010032553.1138036-1-ray.huang@amd.com/
> >>
> >>  include/uapi/linux/virtio_gpu.h | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h
> >> index f556fde07b76..240911c8da31 100644
> >> --- a/include/uapi/linux/virtio_gpu.h
> >> +++ b/include/uapi/linux/virtio_gpu.h
> >> @@ -309,6 +309,10 @@ struct virtio_gpu_cmd_submit {
> >>  
> >>  #define VIRTIO_GPU_CAPSET_VIRGL 1
> >>  #define VIRTIO_GPU_CAPSET_VIRGL2 2
> >> +#define VIRTIO_GPU_CAPSET_GFXSTREAM 3
> > 
> > The GFXSTREAM capset isn't correct, it should be GFXSTREAM_VULKAN in
> > accordance to [1] and [2]. There are more capsets for GFXSTREAM.
> > 
> > [1]
> > https://github.com/google/crosvm/blob/main/rutabaga_gfx/src/rutabaga_utils.rs#L172
> > 
> > [2]
> > https://patchwork.kernel.org/project/qemu-devel/patch/20231006010835.444-7-gurchetansingh@chromium.org/
> 
> Though, maybe those are "rutabaga" capsets that not related to
> virtio-gpu because crosvm has another defs for virtio-gpu capsets [3].
> The DRM capset is oddly missing in [3] and code uses "rutabaga" capset
> for DRM and virtio-gpu.
> 
> [3]
> https://github.com/google/crosvm/blob/main/devices/src/virtio/gpu/protocol.rs#L416

Yes, [3] is the file that I referred to add these capsets definitions. And
it's defined as gfxstream not gfxstream_vulkan.

> 
> Gurchetan, could you please clarify which capsets definitions are
> related to virtio-gpu and gfxstream. The
> GFXSTREAM_VULKAN/GLES/MAGMA/COMPOSER or just the single GFXSTREAM?
> 

Gurchetan, may we have your insight?

Thanks,
Ray

> -- 
> Best regards,
> Dmitry
>