Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Wed, 11 Oct 2023 08:32:40 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc:     Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc/pvpanic: deduplicate comomn code
Message-ID: <2023101113-squatter-stew-5d66@gregkh>
References: <20231011-pvpanic-cleanup-v1-1-5c93b05ec331@weissschuh.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231011-pvpanic-cleanup-v1-1-5c93b05ec331@weissschuh.net>
Precedence: bulk

On Wed, Oct 11, 2023 at 12:10:08AM +0200, Thomas Wei?schuh wrote:
> +int devm_pvpanic_probe(struct device *dev, void __iomem *base)
> +{
> +	struct pvpanic_instance *pi;
> +	int ret;
> +
> +	if (!base)
> +		return -EINVAL;
> +
> +	ret = devm_device_add_groups(dev, pvpanic_dev_groups);

You just raced with userspace and lost :(

Please just use the default groups attribute pointer, you should NEVER
need to manually add groups to a device like this.

And why are you calling this devm_*() for a probe function?  That's
risky as you are now in the global namespace and this really is not a
devm_*() like function

thanks,

greg k-h