Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <2924b09c-bf19-4de2-aae4-55752dab24a6@intel.com>
Date:   Wed, 11 Oct 2023 09:25:50 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 03/14] bitops: let the compiler optimize __assign_bit()
To:     Yury Norov <yury.norov@gmail.com>
CC:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Alexander Potapenko <glider@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        David Ahern <dsahern@kernel.org>,
        Przemek Kitszel <przemyslaw.kitszel@intel.com>,
        "Simon Horman" <simon.horman@corigine.com>,
        <netdev@vger.kernel.org>, <linux-btrfs@vger.kernel.org>,
        <dm-devel@redhat.com>, <ntfs3@lists.linux.dev>,
        <linux-s390@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231009151026.66145-1-aleksander.lobakin@intel.com>
 <20231009151026.66145-4-aleksander.lobakin@intel.com>
 <ZSQn4Mppz9aJgFib@yury-ThinkPad>
Content-Language: en-US
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <ZSQn4Mppz9aJgFib@yury-ThinkPad>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmpiRmtqUkt3MXpHMEtrM2kyZktHclRzVFRLNHdtME5Jbk1vNkhhbEFrcTIz?=
 =?utf-8?B?amNnRmNIYXRtcHVmM1VxaGJDeTZOWW1lcXk0MWdFZmpYc3NEVkVpaThXd0tN?=
 =?utf-8?B?cHQ0Q2VaaXNYWGx0d3k1M1ZYWk90TmFjMmdTMXpneHByRW1LQk5YUTZBbjBE?=
 =?utf-8?B?UUxLK1R1UTYxSlVpRGlzUDgyZUhkVGplai95cmxtZmpPQnRqdjM3TGkrNnpH?=
 =?utf-8?B?VEhxUnNlSS92VUNPM3c0ZzNWTGhFa0EzQlNhcVJBQUE4cU1rWWRpZzliT2d1?=
 =?utf-8?B?ZkZJdFptOGEwYkR6cWxOVy9LYWNDZno5WnpuMEJJUjhEbmpjYVR1N3J4ZTBX?=
 =?utf-8?B?citWSjFNbUdmZ3FFak43UG1tcHlzWkZHanU1azNmOXJiZ1NubWV2YzB1RGZa?=
 =?utf-8?B?L2JqclFTdU9EYnNVckkyTUp4WERSZlQwODUzSGY4ZFpCZXFlVDlvM2RhWGIz?=
 =?utf-8?B?ZTFsU0ZhNkFualRRbVlmbm1Tdkp5OEhQOHFkTmpOUU5PVXVwVEVPNmRaQ0g1?=
 =?utf-8?B?bnh4QkY3alpWa2l3amZWV1dHREl3MnVpOGd6OVNjaVdOZjU0emYzMU9Sdzgz?=
 =?utf-8?B?U2FQcDlUVnFFdkt5MVdTT2d2eTltNWJHZ3JFQzFMMHBzamFoU1Fpb2hIS2dm?=
 =?utf-8?B?K1pyT0hMUGcyOFB3Y2ZJRVlGWWdzRjV6amdiSDVTYnQ2VXRFUjByYStTaEwz?=
 =?utf-8?B?a3ozOGxZcjNMcnZnMmtlKzhkRVdCRHppKzNRWWFFSXVTaHMydXFwQjM1SS8w?=
 =?utf-8?B?SjdOaUJJWUYwYTlNS3F3Z1F6K3pzakd2aXVBMW43V1VWb0dMZnFqVFNpdXY5?=
 =?utf-8?B?ckU4bEk0ZURyWDhDK1JkSWxBN3gyUEFxVVNhY0diZ0Vob1ZqdGRGRmpiZWZE?=
 =?utf-8?B?clBpZkozcTZHalk0cVpSV09WWWtGVDNMbmxoU3M5OVQrRW5oVXY2ZTQrUmJm?=
 =?utf-8?B?WnVuY2dQRTNvM2ZXSlJRV0VWS3dkblMyL2VOYzdmQjVqSHFjK3EwRWU3OFBx?=
 =?utf-8?B?bXdvRS9Qc0dXZzZYZGFyUnJZU0VwaUEvVmh6MmF3aFU2cCtDUUpkK0Uzemx0?=
 =?utf-8?B?TW55K2dqbVZiNHJmRElZRmJjRHpDK3VFSW1DSVpVZkZOdmc5Z3A1TThCanFq?=
 =?utf-8?B?YnlQS3c0S2pNWWpFekZCMXhvd2NNWEJJY3ZJZnVYOWRUU1BlcW9taFpMdS9G?=
 =?utf-8?B?bEZOSjVzblpXL0hzUHYxenI5cVhKL1ROckR0WGVyeWVzNkljUkYvQTgzcWdW?=
 =?utf-8?B?UVBEUlIwOVIwOE5SblFWOTRxMVhTOWNRWmVpTXRZUWdoREJvamI4TVVlTEtw?=
 =?utf-8?B?Zkt6amEzMTZZVTVVYTZBZWUrWFh1RVdnQUs0K2lpVmF5WnYxK2tYR1ZYcFRJ?=
 =?utf-8?B?ai9yaHlIcUlndW5yT0xORlUyZ3p3QkhpY3FHL2h4ajc0OWQ5ejRGZk5MODhF?=
 =?utf-8?B?RE16Z3cvaWUxUmVUN3ZTM0YzQ21iT2NBUzhaVVBjbFNGbkczVjk4QjVaRVpW?=
 =?utf-8?B?VDduZXZrVEZqWXR5c3lqNWg1VWR4MGdOS0pUZ3FXS0ZlN0ZEdGVOR2dPTVM0?=
 =?utf-8?B?TXp5NzJaczJEbFRnSzJhZE5VUFhFV3hZcHdUSWIyMkZSM1hEMWZDZkZwZi9h?=
 =?utf-8?B?eGtleDVqdW5OL1dmWnpEV3k4bFN3SzRjSWovNjUvb21NVEtLRURiQXQxdGg3?=
 =?utf-8?B?SnhGL1lRc2QrSGc0VEhITUt4dlNoR3JpOGJUUXR4bXJuaXBGUXBTWFMzNStH?=
 =?utf-8?B?TlMrRUUwWWo3RHBXUUM0QkE2bE54QTNCekNURkQwWUJpODhCTFZiM1AvY1py?=
 =?utf-8?B?NnBJRFVwWmJxeW5KMzFTcUpmUmNVMlRXdUZGMWtZRy9NVHNCOXg0cVJJSFA5?=
 =?utf-8?B?VENDeEpqNmljT0p4dkE2a0NPSVJPd3pSSEorLzQwS1BGZk5KeWtxSXNFSWtW?=
 =?utf-8?B?QjljeVByZGlsYVFydkQ1YzlpTXcxUVFwcDlXZUhpeC9LaUdzckZjNGZCSDEz?=
 =?utf-8?B?L0U0Skg4ZEVJZktxeG1rNmRERGJVRzM5Zjk2dDJMdFF4WXZnNEFPU0pQOTB3?=
 =?utf-8?B?MW0xTDJnUXB3b1JxbW5iM3ZYNUY5ZTB5NnlGUHZ2dTJ5bGdnait6aW81akFH?=
 =?utf-8?B?UlhmdFZnM3JPSHNMZUZDSDhhcHliMlA0Mkd5UjRnSG1oRmIyU09ON1BVZXhH?=
 =?utf-8?B?S0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: aa5167bc-1fa1-45be-b3b3-08dbca2b7813
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 07:27:05.2661
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ct/F3ureqZIh0WVYcXzq8ApUio2uiZv2O1II2eCbO+TureHBkoH6quA3lCI9MV7kH80p0dFV78ZgBk9pRfelhiMtAZd1MxukpiiG5Tknehk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6489
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 11 Oct 2023 00:27:45 -0700 (PDT)
X-Spam-Level: **

From: Yury Norov <yury.norov@gmail.com>
Date: Mon, 9 Oct 2023 09:18:40 -0700

> On Mon, Oct 09, 2023 at 05:10:15PM +0200, Alexander Lobakin wrote:

[...]

>> -static __always_inline void __assign_bit(long nr, volatile unsigned long *addr,
>> -					 bool value)
>> -{
>> -	if (value)
>> -		__set_bit(nr, addr);
>> -	else
>> -		__clear_bit(nr, addr);
>> -}
>> +#define __assign_bit(nr, addr, value)				\
>> +	((value) ? __set_bit(nr, addr) : __clear_bit(nr, addr))
> 
> Can you protect nr and addr with braces just as well?
> Can you convert the atomic version too, to keep them synchronized ?

+ for both. I didn't convert assign_bit() as I thought it wouldn't give
any optimization improvements, but yeah, let the compiler decide.

> 
>>  
>>  /**
>>   * __ptr_set_bit - Set bit in a pointer's value
>> -- 
>> 2.41.0

Thanks,
Olek