Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <bb7e8b2f-b586-4985-930b-018035e86bcc@intel.com>
Date:   Wed, 11 Oct 2023 09:28:37 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 05/14] s390/cio: rename bitmap_size() ->
 idset_bitmap_size()
Content-Language: en-US
To:     Yury Norov <yury.norov@gmail.com>
CC:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Alexander Potapenko <glider@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        David Ahern <dsahern@kernel.org>,
        Przemek Kitszel <przemyslaw.kitszel@intel.com>,
        "Simon Horman" <horms@kernel.org>, <netdev@vger.kernel.org>,
        <linux-btrfs@vger.kernel.org>, <dm-devel@redhat.com>,
        <ntfs3@lists.linux.dev>, <linux-s390@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20231009151026.66145-1-aleksander.lobakin@intel.com>
 <20231009151026.66145-6-aleksander.lobakin@intel.com>
 <ZSQryML6+uySSQ55@yury-ThinkPad>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <ZSQryML6+uySSQ55@yury-ThinkPad>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUN2TjZyeFlSLzlab1FvaVhBeWdrTnUvamtzWDhBWlh5Qmh3R0c1eW5mVTlZ?=
 =?utf-8?B?K3hGVG9zNEN5S1pkMitvWUQyam9PaXZ4SldndUpSSk1ySUs4aVgvVzROSm0v?=
 =?utf-8?B?RkRUcmZYajJSbTRmZU9xcnE2YWd1UWZvNmNnV3Y0L2pqL2hPVWVyOXVwSS9r?=
 =?utf-8?B?Qk5uSndDUjFPbGNuQzI3VzdjZ0Y5Q2VEQ2FjOEJwaEsxTWVGOUFRYktpc3ht?=
 =?utf-8?B?K3BTRDRQYWFJSDZjekFraWJSTmk4L0d1a0wzRkhqZnhacU5GN0pmaG15S083?=
 =?utf-8?B?Y0NocUIwU1YycnA5bXNwUnNkM2o5Uk9mUFdSRGdoY2pydkF2UjRiKzVlNi9i?=
 =?utf-8?B?aURTbUFhOVlnOHBHSGxVdW9PMFhGZVVDR2kvZUlYRnFMZjJVMmFZZ1hKcW9i?=
 =?utf-8?B?MisxVTNLV2lKY2NUb1JvUytwUnVFQUZyQzQ1VEpqUDF4b3o4Nnp3d3BFMnhL?=
 =?utf-8?B?bFNDREdlSHAvM1pYTS9Ld2xjemRSanVwZitKRnozY1RhOU9Nc0NVTUFJcm5C?=
 =?utf-8?B?WVNjSFZ4Qm9TTVRqSE5IS2ZtNUQyeEI3aWhBVE12QXBRT2g5UHpCMExFankx?=
 =?utf-8?B?S3VDZVBia25YUDhYOHdWZ1lHQXIvd05VYW9seXA4bWxZY1hvSkRZSDRkVmJr?=
 =?utf-8?B?eVVZTzM4azV2cytZa2pVQlJHUUhMTnVmTWNaU2g1cVdFNGV3OWNJbXFKR1pm?=
 =?utf-8?B?MVpmV2V6bHEyMHNmUm0rL0syZ1VvZVpZMnRWVGVlZ0dQajlEWDB6SlI1Y255?=
 =?utf-8?B?NFdaZStGQXZiNW1iQWptYkJ3SVZtNzhySzlIQVpkWjJRdzN4cG85M1F0bDVl?=
 =?utf-8?B?NWwvbmY3VEVlWG5GRUNhSkJnWHlJaDJBTGR2M3FSSjVXSXNLbEE4YWViSTBO?=
 =?utf-8?B?Uy9yNXhmZXZtaitSeVpRVFVaVUpCcndlSXlzTDl5WVFpb1N6eWV0aVA0RW1S?=
 =?utf-8?B?WCtyS2lwMVYraW54aW1sRFR4S1BoVDNKTTh5Ti96dG8zWDNpTlYrYWl6TkRX?=
 =?utf-8?B?dk9Yb0ZndnUyYklYUFB6Qklqalh2eHUrYTl2RDlXYWJnd21iRXVVSzQwczlq?=
 =?utf-8?B?Y21sZHZuZlJ3ekpwdktKS3c1QSt5TjFMQTJibyttMktkb3lBZWJSS1ZPY21P?=
 =?utf-8?B?Y0FaNk93alA4bnZLZjdkclphU1hsTzBvanIyMWxrbHJxcjloOWU2RUROU3Y3?=
 =?utf-8?B?MWY4QmpZTitwdXlMZ2NnelYyODV5SzNLemtodXhCSFhIUDBlV0FwUmM3cXoz?=
 =?utf-8?B?RCsycEt3TGV2ekVZWG4rd1dDZHh3alQvUlhjRGxyZVF5RDd5SndQNDZqVGhm?=
 =?utf-8?B?bWxoK1JDWEJMTzN3QTRzeDNOb3czaXJCZ0pCWmVNM1VlOXk0bFF5ZjdVZFAw?=
 =?utf-8?B?STR2REZKMkpKd1dkNzZyQ1JBS01wNmh6RzdlTzlaNmFSTFRoY21vYi9hNVRr?=
 =?utf-8?B?OXBvb1poMTZRNVF1NUlMQ0VlOHdMd0t2end5U0VHVk9uQnJGOHAzQUJYRE9n?=
 =?utf-8?B?bmwvV1VwRlA1UHJ6amxobzhDNFpUUlF4d3QwYmYrMkZwV2lVbGFPMXZiSGsz?=
 =?utf-8?B?VmZtTGdLQmRyTnFOVjZRRE9zNEdmTXVuVmx4UGtyNW9vaXRkM25BMmVUUmVw?=
 =?utf-8?B?KytnbzJCcHpUYS9IRk5JKy9iS1l4dFA1aGpCOExSZ2JhTWdMV1dUc2dRTTdU?=
 =?utf-8?B?QzFlVGxhbkdZZlVFUTIzSExpVmhSWTNNWTZwQW53NjZGeEtrZ3RlcVRtLzFV?=
 =?utf-8?B?QXBnWHZLZnVJNFdBcGZvR3F1OVo0NmNwalVES2I1czArcmNmcTd4b2lHK0Vx?=
 =?utf-8?B?ZWNKVUtSUnJGM1cyMjhBMDFpZG1zNEtCaG1iOVhNalhpejFvOGYycy84RmV2?=
 =?utf-8?B?V0p0OWlDZTV3Q3lyOEN1ME4rWjBJSjduSkdKc2RGVTFFQmJFNi81aHdmTkFS?=
 =?utf-8?B?d1k1dklUS1I3US9WQkZvbEdUclhMSGpyWVB5RzhrK2JJT0dkY25YK1hnZEJk?=
 =?utf-8?B?SENIZXdwZVVMaXBxbDZtazZyMkZwMUxSbUxiVE5aY1ZVYlFXZ1pzRUNYRHFx?=
 =?utf-8?B?ajJVclRBZlpkdm1Yam1iRGd0eCtHL01HNzV6aGx0T3pMYnFqWjdnVmlHS3Rk?=
 =?utf-8?B?MGtFeEpraUg2SFRJZVNUTDV4cjZVUzA3WTlYZzIwdkFNVzMrZDhhSkM4VnRR?=
 =?utf-8?B?MWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cb156fc-ace1-4de7-3b86-08dbca2bdc51
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 07:29:53.4722
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ErwyNnvMbgseIdw2Vq9IIxRdQC90noy/pLT4pLhYMMQgJDCa9kLjiBFTpRTGQTPN1HY5wHsSR82dtiK/J9f5SKnXQPyvy3HGnu3mHtY9XjI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6489
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 11 Oct 2023 00:30:28 -0700 (PDT)
X-Spam-Level: **

From: Yury Norov <yury.norov@gmail.com>
Date: Mon, 9 Oct 2023 09:35:20 -0700

> On Mon, Oct 09, 2023 at 05:10:17PM +0200, Alexander Lobakin wrote:
>> bitmap_size() is a pretty generic name and one may want to use it for
>> a generic bitmap API function. At the same time, its logic is not
>> "generic", i.e. it's not just `nbits -> size of bitmap in bytes`
>> converter as it would be expected from its name.
>> Add the prefix 'idset_' used throughout the file where the function
>> resides.
> 
> At the first glance, this custom implementation just duplicates the
> generic one that you introduce in the following patch. If so, why
> don't you switch idset to just use generic bitmap_size()?

I didn't want to introduce any semantic changes, but good point, why not.

> 
>>
>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>

[...]

Thanks,
Olek