Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <9728a6f4-96be-4f8f-9806-17413e4ffb00@intel.com>
Date:   Wed, 11 Oct 2023 09:36:23 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 06/14] fs/ntfs3: rename bitmap_size() ->
 ntfs3_bitmap_size()
Content-Language: en-US
To:     Yury Norov <yury.norov@gmail.com>
CC:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Alexander Potapenko <glider@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        David Ahern <dsahern@kernel.org>,
        Przemek Kitszel <przemyslaw.kitszel@intel.com>,
        "Simon Horman" <simon.horman@corigine.com>,
        <netdev@vger.kernel.org>, <linux-btrfs@vger.kernel.org>,
        <dm-devel@redhat.com>, <ntfs3@lists.linux.dev>,
        <linux-s390@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231009151026.66145-1-aleksander.lobakin@intel.com>
 <20231009151026.66145-7-aleksander.lobakin@intel.com>
 <ZSQvR+bQ8PS9/CEa@yury-ThinkPad>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <ZSQvR+bQ8PS9/CEa@yury-ThinkPad>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkdvLzhiR0NEa1QvcktOcG82QzVwNWxtQ3NvZC9aRGtsVWNvdjlMcE5QRTJX?=
 =?utf-8?B?dWVGaFFRalI5dm9RMlJmSDhUQ2lMU3pYZ2YvS1lHYXVvWXBPQk1CU1lEcmNK?=
 =?utf-8?B?YTJFd09qd3Rza3pIN1JhVTFXenA4SW5QYlBCSkMyL3AxUUtxQ0RyL2dKa042?=
 =?utf-8?B?U3ZkNStFL01PTExFbmxMNEpmS2NWSWdEV0wvRHRqVXgrQ0xTOU1kUnN2TjZ1?=
 =?utf-8?B?eU5ibUdqWXVTZHNva1Z4QWxYSlBJSituUWNmanl2RHh1UFhaeHc1SmRQSHdH?=
 =?utf-8?B?Qmw0a3MxU084eEFuNTlXUTJzNjdSUkFQaXhZODE1cUNTYTVkMTdBL1hEaGNV?=
 =?utf-8?B?YXhWTDJvYXNkWmxsQkdYSktjL1g2OWF3MG4vZzJxTzNORU5TTmU5Y1cxRE9q?=
 =?utf-8?B?Q2xzTGQ4MFVmMTJlZHhzaVUxY0hjcU5CV1dCaW5PU2xtdkdmSWd3dEgra3dx?=
 =?utf-8?B?MkRCdjlBUlp0TFQ4Y3dUdHJmMlozQmxXZFRiMHIvSUZubXJOUnhLekR1eFVi?=
 =?utf-8?B?ZjJCVkptYmM3VldOK1ZWbXBHMWJ3dVZzdDR2aUE3V2RHdGZRb2FQQzJDajUz?=
 =?utf-8?B?Yk9zWUZEN1RGbU1QbWRqVU5jajVEUEVNN3JWVEpSdzhibmFUOGlJaUQvM0hZ?=
 =?utf-8?B?d3BhaDRCMno2bXd6OFJZNWJ6ZlpWQ202dUNubW1FQ0JKZGZyUTQ1S3RkU0ZY?=
 =?utf-8?B?dWorRmY4ZFJiSFZpa3diWmRycjhyZC8vcWRhbVVBazdwZitqWHEvVDkzRllv?=
 =?utf-8?B?ZWg4cGppdjlBeGgxazRHei9wM2VibzJ4a3JPUWw5b3NqY00zbWlkWGxiRDFr?=
 =?utf-8?B?dC9vUzFieHhwOExoTEVKY1JVVzVrTjB6ZFlCV3JqRjk1MUFRd3lJcG1UY3RJ?=
 =?utf-8?B?ZWpTeWJ1YjF4NnZkUU9TRTNEaWhacHpKOFIxcmpzaDhqSnhWRGZuYVNpTGE3?=
 =?utf-8?B?d1ZKbDV0eUQyM3k3SEFwY2ppekVDL1JucVl6SDB1TnBkWWdZVVk1WUJFeGdM?=
 =?utf-8?B?VklwL0ZabjdXUDRUbTZzd3BMVEJSM1IrS0FNTCs0VGg0SzBwSDBKODRrNXl3?=
 =?utf-8?B?MXRsUjdQQ2pDYmxlK2xmaXQwcXdpNHo1RE1IKzhsdzkyWmdGVk91d05oa0ZB?=
 =?utf-8?B?eGIxcXE3N0RRL2U4SmJveHRLUmI5QmZvZ3ZKUE5qTC9xaVhHZHNHTVU2WUhX?=
 =?utf-8?B?cC9wMFVCZkZKYUNNeEFEV2l1blRvMENiVjFWVExCTkFPSU9Sak8rZW5vTldX?=
 =?utf-8?B?L2NZd2hHcG9nakxSbEFmNGFYN3c0N2VjS1p5MkVCclFseU1WbUh4Yk9lNHow?=
 =?utf-8?B?UWRxZUFucUlWaktXY0dhWGlTa3Vtdk5DUFozaHJpQlNNcnUvcjJQb2g3K0hF?=
 =?utf-8?B?RmFCUG9TTVl0bTR1cTl6bmxjNThHMnpRN0J5QWkzbHpGRDliZTdwMndUZTlz?=
 =?utf-8?B?VUxxSlB4ZVBuMnpCcjVDRDNMdVIzSzJmMWxQU295Y09uaE5QS3hHQmU5c1p6?=
 =?utf-8?B?emRvSTFOYW0xc0VPUTVWNS91bHllV3A5WWxsSm5ibDMzRHJKc3BUamVRdThX?=
 =?utf-8?B?NnZBR1dLT1B1Q0xaMC90bkFNVDQ5bG43eDFQM2Y2cUZEc0U2OWpTRkZiL0tB?=
 =?utf-8?B?anBYU3lTdDN4aDVRc0VOclV1cnBTNmZtMkFnV0xuUWtlMVJobkE4akRyTkZn?=
 =?utf-8?B?cXhtTEs5bnR4TCtZTkxOMkFCSDM2blJ3dkNnSThqY0doVEROZDI3UGt1RW5T?=
 =?utf-8?B?UXFPL09ScXEyaG1WNHU4WjYwQ0oxblFPY1NvMmsrSDQ5YWk4d3JGbHJOaFFR?=
 =?utf-8?B?c1Vnb21wY3phbVdTa1RmZksyaXhrWXY4dGZweUwybHRZTVNoc0krL3FENHhL?=
 =?utf-8?B?bER0NzZYbkI2OEF2NWNHWldTYVZWMVNLNE9Xay9INUtORmZDaWRNRkF0WGNp?=
 =?utf-8?B?RWJmNVRnUjkvRWwxWmNwbFF2U2NaU0c5RUxQSzdGZnRLak8wb21Qb2wyMDNw?=
 =?utf-8?B?V0NoV1YrUGxrbnBySGlEOVdlQzdvanFMa0ZYd1pXMDA0RHNlQnUvWUJWRk9k?=
 =?utf-8?B?aHk0QUwzOFZIMHg1OThiOWsrRnJuT3U2cXFUaHQrZGtqOEV6Y3FGeloxZzFO?=
 =?utf-8?B?YXpCSUtUZFVnaGZ4QSsvZTd0VklVNk1aQ3gzOUN3djI0cTlZdU9oNCttL0F4?=
 =?utf-8?B?NkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1197541c-c34c-4d6e-57ad-08dbca2cf13e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 07:37:38.0257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zpF8xBZ51zhDDkxCP7cqMS+azS39wza4eSmbLEpwQ6DLtDSmYbj6GUYJDTImW35k1zYGT3idPB1IYNXjcWiRdQq7BDOeSiO4hhviOvXTEOQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7730
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 11 Oct 2023 00:38:42 -0700 (PDT)
X-Spam-Level: **

From: Yury Norov <yury.norov@gmail.com>
Date: Mon, 9 Oct 2023 09:50:15 -0700

> On Mon, Oct 09, 2023 at 05:10:18PM +0200, Alexander Lobakin wrote:
>> bitmap_size() is a pretty generic name and one may want to use it for

[...]

>> @@ -961,7 +961,7 @@ static inline bool run_is_empty(struct runs_tree *run)
>>  }
>>  
>>  /* NTFS uses quad aligned bitmaps. */
>> -static inline size_t bitmap_size(size_t bits)
>> +static inline size_t ntfs3_bitmap_size(size_t bits)
>>  {
>>  	return ALIGN((bits + 7) >> 3, 8);
>>  }
> 
> This looks like duplicating BITS_TO_U64(). If so, why not just switch
> to using the macro while you're here?

I thought that this

	return BITS_TO_U64(bits) * sizeof(u64);

would give worse optimization, but actually

add/remove: 0/0 grow/shrink: 0/6 up/down: 0/-32 (-32)

Nice, makes sense to do it.

> 
>> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
>> index cfec5e0c7f66..b1fb6efe7084 100644
>> --- a/fs/ntfs3/super.c
>> +++ b/fs/ntfs3/super.c
>> @@ -1285,7 +1285,7 @@ static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
>>  
>>  	/* Check bitmap boundary. */
>>  	tt = sbi->used.bitmap.nbits;
>> -	if (inode->i_size < bitmap_size(tt)) {
>> +	if (inode->i_size < ntfs3_bitmap_size(tt)) {
>>  		ntfs_err(sb, "$Bitmap is corrupted.");
>>  		err = -EINVAL;
>>  		goto put_inode_out;
>> -- 
>> 2.41.0

Thanks,
Olek