Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp659205rdg; Wed, 11 Oct 2023 01:35:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiXOiH0rh6mORBZ1sML981WyQbCzVkJKbS2U5qOKbrrc6P/Tw33+jhozxr8T5hXBQKSN2s X-Received: by 2002:a17:903:1c6:b0:1bf:7d3b:4405 with SMTP id e6-20020a17090301c600b001bf7d3b4405mr22737164plh.14.1697013312732; Wed, 11 Oct 2023 01:35:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697013312; cv=none; d=google.com; s=arc-20160816; b=EivAwpPs/MmXv+0Wti1HrBKWARim0d9XzR2LbX8NkoBgTV1R/Eu76T2PRXbkWA9gyL h3A42dyQS0GaBu0HryZOKJsQqeEOXyNNJTD8aitPhzsHuvu+85Jb27O7Okp+w6+mKj/5 rzek9a8gcsKZQ/LlXkWP/6Cf7z9t6YWQnsQA6+wWYUKf0GudWRbHJoeoJoDIqGIBdGKm uWI/2cCQQ2Afo6ClzwqMnCwt4CL9qn1rEcXUmNPiWYm8xJ1H3Q220UUu7i9eWGG0xCn7 vRQ0nTHQGj1PyxufT8tWRsFGyqFObuq7tWZ83PfoH3iEzaUBoPA2Ig1VHCZIYgpfJray UtlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=o11ywevrjkAGx/uipO42BvPNFGFhAboFMAK3dybl0hA=; fh=KYfAVph4r8Q0QL8w2PKQM+mlcUaM4t4ymfiVotNlWDE=; b=Z55wY+ZFyOk2uldahkyr1KctB7CQOdrKMgiTqW6lB113gtskmSVDnUhcfGCY9brXb/ Y/6B3UDdIvEmqBWSgRP8NMEaxUBUJ2jOFODhcgY2RwGvbdrCuFDEuzhjHTTIKSURoCt1 kC6HDzxmUOtz7SL3Q8w9nQN3naBWr5CjA+rT+L08hD4q+TSHNZe/hBknlWJtxExFuzeq cylj2W+Kl9pLFHjCvJt8bISuZPp9TVixmC+Q1OcnaTKQ4PKIlaXWuqzVOkh/SQDkD0hy AigswqwEWhQZq4/10ZM3aVPGZe4u0vNj/UtAyFg3mgOemFQSqZNLafH6Um9BR2kTGwri +frg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eT8F8aHS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id t10-20020a17090340ca00b001c589ba4a0bsi3670250pld.195.2023.10.11.01.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 01:35:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eT8F8aHS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 3251280E0A02; Wed, 11 Oct 2023 01:35:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230471AbjJKIeX (ORCPT + 99 others); Wed, 11 Oct 2023 04:34:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230468AbjJKIeH (ORCPT ); Wed, 11 Oct 2023 04:34:07 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EB439D; Wed, 11 Oct 2023 01:34:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697013245; x=1728549245; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5PKJcHQuGAJasXvUQcWL2vxKmsvzbQLbVutteBr3/jA=; b=eT8F8aHSG/PXFeGGCc2Yn6tCOfkhJQL23q+eesxOEkYfTl7MG4KIOQJZ TkMOjbuStWPvDiKTkZpZoV1uqMsX/85+PSGudonB6Az9qE5qXdHEepvPr cX5KLZ+MHmxLbheO3MFzdIgbhbU1LvHDCVt0p64/YXBsbTWTfgirOtl08 CL9cb3huQXGGrQMzliadIxDOstLN+75atA6R7U7e6a0qAjiFxuuJnRNPb YQyJnh1SWvxk/FfXcs4NCX5DqO8z25UyF7G3wC4lA7KC6U7lPA8gTj4VC 8lRHlov0qtbTIwgFfcSG6Ac+PqsEAVGnJqSnej0uS8rLFcp9Xk2KMoqfR Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="388480159" X-IronPort-AV: E=Sophos;i="6.03,214,1694761200"; d="scan'208";a="388480159" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 01:34:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="897548177" X-IronPort-AV: E=Sophos;i="6.03,214,1694761200"; d="scan'208";a="897548177" Received: from powerlab.fi.intel.com ([10.237.71.25]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 01:32:12 -0700 From: Michal Wilczynski To: linux-acpi@vger.kernel.org Cc: rafael@kernel.org, dan.j.williams@intel.com, vishal.l.verma@intel.com, lenb@kernel.org, dave.jiang@intel.com, ira.weiny@intel.com, rui.zhang@intel.com, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, Michal Wilczynski Subject: [PATCH v3 1/6] ACPI: AC: Remove unnecessary checks Date: Wed, 11 Oct 2023 11:33:29 +0300 Message-ID: <20231011083334.3987477-2-michal.wilczynski@intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231011083334.3987477-1-michal.wilczynski@intel.com> References: <20231011083334.3987477-1-michal.wilczynski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 11 Oct 2023 01:35:08 -0700 (PDT) X-Spam-Level: ** Remove unnecessary checks for NULL for variables that can't be NULL at the point they're checked for it. Defensive programming is discouraged in the kernel. Signed-off-by: Michal Wilczynski --- drivers/acpi/ac.c | 27 ++++----------------------- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c index aac3e561790c..83d45c681121 100644 --- a/drivers/acpi/ac.c +++ b/drivers/acpi/ac.c @@ -131,9 +131,6 @@ static void acpi_ac_notify(acpi_handle handle, u32 event, void *data) struct acpi_device *device = data; struct acpi_ac *ac = acpi_driver_data(device); - if (!ac) - return; - switch (event) { default: acpi_handle_debug(device->handle, "Unsupported event [0x%x]\n", @@ -216,12 +213,8 @@ static const struct dmi_system_id ac_dmi_table[] __initconst = { static int acpi_ac_add(struct acpi_device *device) { struct power_supply_config psy_cfg = {}; - int result = 0; - struct acpi_ac *ac = NULL; - - - if (!device) - return -EINVAL; + struct acpi_ac *ac; + int result; ac = kzalloc(sizeof(struct acpi_ac), GFP_KERNEL); if (!ac) @@ -275,16 +268,9 @@ static int acpi_ac_add(struct acpi_device *device) #ifdef CONFIG_PM_SLEEP static int acpi_ac_resume(struct device *dev) { - struct acpi_ac *ac; + struct acpi_ac *ac = acpi_driver_data(to_acpi_device(dev)); unsigned int old_state; - if (!dev) - return -EINVAL; - - ac = acpi_driver_data(to_acpi_device(dev)); - if (!ac) - return -EINVAL; - old_state = ac->state; if (acpi_ac_get_state(ac)) return 0; @@ -299,12 +285,7 @@ static int acpi_ac_resume(struct device *dev) static void acpi_ac_remove(struct acpi_device *device) { - struct acpi_ac *ac = NULL; - - if (!device || !acpi_driver_data(device)) - return; - - ac = acpi_driver_data(device); + struct acpi_ac *ac = acpi_driver_data(device); acpi_dev_remove_notify_handler(device, ACPI_ALL_NOTIFY, acpi_ac_notify); -- 2.41.0