Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Wed, 11 Oct 2023 10:41:17 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Rob Herring <robh@kernel.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: pxa: Explicitly include correct DT includes
Message-ID: <20231011084117.jvfl7xmbcgsu7uyl@pengutronix.de>
References: <20231009172923.2457844-22-robh@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="qonxrk3tvlfhlcfv"
Content-Disposition: inline
In-Reply-To: <20231009172923.2457844-22-robh@kernel.org>
Precedence: bulk


--qonxrk3tvlfhlcfv
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 09, 2023 at 12:29:17PM -0500, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>=20
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/pwm/pwm-pxa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c
> index 1e475ed10180..78b04e017c49 100644
> --- a/drivers/pwm/pwm-pxa.c
> +++ b/drivers/pwm/pwm-pxa.c
> @@ -24,7 +24,7 @@
>  #include <linux/clk.h>
>  #include <linux/io.h>
>  #include <linux/pwm.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>

Even without both headers the driver compiles fine as linux/pwm.h
includes of.h.

I think we should do:

diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index d2f9f690a9c1..9e35970ca2ab 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -4,8 +4,8 @@
=20
 #include <linux/err.h>
 #include <linux/mutex.h>
-#include <linux/of.h>
=20
+struct of_phandle_args;
 struct pwm_chip;
=20
 /**

drivers/pmw/* compiles fine with this change.

Other than that:

Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--qonxrk3tvlfhlcfv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmUmX6wACgkQj4D7WH0S
/k6WCAf/VTAkcHY/Xjw1z+3vSnWH9KPBEte2/wm5UF3Ee2iG19jUSsuspIajwQsk
5ZucpR2CBmXmZ/H4CTm6R0N+bsCq+zDJoSNJMkUwqK4eFosS+oBSbp+HiOq6WzL1
sg4Mu2DgiGH4hYAeQQ7/rz7d+uE/AYKGHOOMYvjXfUaMYMag7/WRonErwoOvz/Nu
sflvsEG1cN6WLM6FBB7CuUQ6epDGvJ5hlAB7q1zdpan6o6gDBvsu3knr1RB8nSTT
vBasw6ULDb5kHAZgPkaNZd7ST14IbhD9HYp6C/B0bmW7IjksdBS6NlsoiwufPloR
jPIc+17voM6pBq0JcklEcLRlwNWF+w==
=8SsM
-----END PGP SIGNATURE-----

--qonxrk3tvlfhlcfv--