Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Javier Martinez Canillas <javierm@redhat.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 7/8] drm/ssd13xx: Add support for the SSD132x OLED
 controller family
In-Reply-To: <CAMuHMdVnJPBfcaPSpeONuz0dPsWUD69_GnWXwbs9VPgN+fhmtw@mail.gmail.com>
References: <20231009183522.543918-1-javierm@redhat.com>
 <20231009183522.543918-8-javierm@redhat.com>
 <CAMuHMdVnJPBfcaPSpeONuz0dPsWUD69_GnWXwbs9VPgN+fhmtw@mail.gmail.com>
Date:   Wed, 11 Oct 2023 10:49:38 +0200
Message-ID: <87h6mxsfvh.fsf@minerva.mail-host-address-is-not-set>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Geert Uytterhoeven <geert@linux-m68k.org> writes:

> Hi Javier,
>
> On Mon, Oct 9, 2023 at 8:36=E2=80=AFPM Javier Martinez Canillas
> <javierm@redhat.com> wrote:
>> The Solomon SSD132x controllers (such as the SSD1322, SSD1325 and SSD132=
7)
>> are used by 16 grayscale dot matrix OLED panels, extend the driver to al=
so
>> support this chip family.
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>
> Thanks for your patch!
>
>> --- a/drivers/gpu/drm/solomon/ssd13xx.c
>> +++ b/drivers/gpu/drm/solomon/ssd13xx.c
>
>> @@ -631,9 +821,12 @@ static int ssd13xx_fb_blit_rect(struct drm_framebuf=
fer *fb,
>>         unsigned int dst_pitch;
>>         int ret =3D 0;
>>
>> -       /* Align y to display page boundaries */
>> -       rect->y1 =3D round_down(rect->y1, SSD130X_PAGE_HEIGHT);
>> -       rect->y2 =3D min_t(unsigned int, round_up(rect->y2, SSD130X_PAGE=
_HEIGHT), ssd13xx->height);
>> +       if (ssd13xx->device_info->family_id =3D=3D SSD130X_FAMILY) {
>> +               /* Align y to display page boundaries */
>> +               rect->y1 =3D round_down(rect->y1, SSD130X_PAGE_HEIGHT);
>> +               rect->y2 =3D min_t(unsigned int, round_up(rect->y2, SSD1=
30X_PAGE_HEIGHT),
>> +                                ssd13xx->height);
>> +       }
>
> Don't you need to align to page boundaries (2 pixels per page)
> on SSD132X?
>

I guess so, yes. I'll add that to v2 as well.

> This should be handled through ssd13xx_funcs instead of a family check.
>

Agreed.

--=20
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat