Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Wed, 11 Oct 2023 10:58:29 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Walle <michael@walle.cc>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Robert Marko <robert.marko@sartura.hr>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Randy Dunlap <rdunlap@infradead.org>,
        Chen-Yu Tsai <wenst@chromium.org>,
        Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH v12 7/7] nvmem: core: Expose cells through sysfs
Message-ID: <20231011105829.778bed58@xps-13>
In-Reply-To: <fe4a2688-079c-a36d-0ea4-c244c6e1a0ad@linaro.org>
References: <20231005155907.2701706-1-miquel.raynal@bootlin.com>
        <20231005155907.2701706-8-miquel.raynal@bootlin.com>
        <318fe799-f53e-64ed-b631-d099bb5202f4@linaro.org>
        <20231011091524.0c9ecc55@xps-13>
        <548849a8-9f11-5274-778e-f291267603bb@linaro.org>
        <20231011103306.08f1fbd4@xps-13>
        <fe4a2688-079c-a36d-0ea4-c244c6e1a0ad@linaro.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Srinivas,

srinivas.kandagatla@linaro.org wrote on Wed, 11 Oct 2023 09:45:11 +0100:

> On 11/10/2023 09:33, Miquel Raynal wrote:
> > Hi Srinivas,
> >=20
> > srinivas.kandagatla@linaro.org wrote on Wed, 11 Oct 2023 09:27:20 +0100:
> >  =20
> >> On 11/10/2023 08:15, Miquel Raynal wrote: =20
> >>>>> +
> >>>>> +	nvmem_cells_group.bin_attrs =3D cells_attrs;
> >>>>> +
> >>>>> +	ret =3D devm_device_add_groups(&nvmem->dev, nvmem_cells_groups);
> >>>>> +	if (ret)
> >>>>> +		goto unlock_mutex; =20
> >>>> This is going to create groups after the nvmem device is added, isn'=
t this going to be problem with user space notifications? =20
> >>> Greg said it was not. I hope I understood correctly =F0=9F=98=84
> >>>
> >>> And anyway, cells have never been available to userspace, so there is
> >>> nothing userspace might expect yet? =20
> >> I agree, but once we add sysfs uapi then this is going to change. =20
> >=20
> > Can you elaborate? I'm not sure I follow you here. Is there still a
> > problem you fear or you think it's okay?
> >  =20
> Now that we add cells to sysfs.
> AFAIU, By the time the userspace sees the udev event from this device we =
might not have cells populated.

Yes, but why would this be a problem?

Thanks,
Miqu=C3=A8l