Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp679143rdg; Wed, 11 Oct 2023 02:22:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfBGrsu65NbbkNjN/91719PgvD93Ulb2Nbx+SvADCkzesDpn9LHtaIngF4vEPBL47GjyIb X-Received: by 2002:a05:6a00:391d:b0:68e:4303:edb8 with SMTP id fh29-20020a056a00391d00b0068e4303edb8mr22932849pfb.30.1697016136455; Wed, 11 Oct 2023 02:22:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697016136; cv=none; d=google.com; s=arc-20160816; b=fEazWEXVFBTlITtIFYXFuvGFfRHw1wqsQrW1077N7Rxox3pgg+vGqJ8U4YuQB+AJsQ Ln3YxJZlKkWLYQzOPGKXh7W1VwH8QtxP6L9uDO4Udz8JdH2eoUuUHyjMbOvRnLJ4FUyB /zWPRWnGijgJXmHNGiFQNe+e1iNkcZuMTo1yWzQugrt2o8Jg9xmCwEgDSmtAmEOLQRv9 pD8/ZTrfZQQx5PzSZeUEYkTTnziWMzcHLIEnkKA+JZeWALTPUd4eYzFoP9pkhaEM9gvK f/bV7YApjjeBYrEdzra4YxdZMqZWjW1y1cXjFgkhpgVxKW3dK+gADLanD2bMCZ/FfNbr gteQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=FBdHg52RbcScFIWBis5JPCbs4EFwutNb74y5hFI3muk=; fh=WdbRu2XmSJxiOwVZ5mmHhBzFx0pNd3JybsOTfcIGa/0=; b=kA+84a2xkSucv9P69kF6Le/4s/6geqnc0eioe8fI9b0AcKWGRE0CxPnEwK4AMzfs1Z tEPLo4ida9mb/ICpDxT2eVZlgl5wEW09Cr1ynk5WYc3hsR3SOROp2qDf5I03ix+ffXYq 0Jfd+J7GDrLXj97dfF1BlF6ft6dGHcKH7UwwocsrBVmoOZ6lSFsHG3FXKbLSoYYnbI4H bCA/NmDUMGRPimN23sLY162mVwLcssxK9Kh6VWfTbZ0f3wiym1hWP+b2muKUEnZBCRb6 L2XGe2LcKSqaxFwtE7Hr7n4Y/T/zL8ybxC7AbCia4Gj1gnb3HZBT0oD/ftCW7cPHUAOi 8LoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xguleccv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id i191-20020a6387c8000000b005859e224624si13523308pge.823.2023.10.11.02.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 02:22:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Xguleccv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 45B6680A801B; Wed, 11 Oct 2023 02:22:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230398AbjJKJVw (ORCPT + 99 others); Wed, 11 Oct 2023 05:21:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345800AbjJKJDw (ORCPT ); Wed, 11 Oct 2023 05:03:52 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97CEDAF for ; Wed, 11 Oct 2023 02:03:50 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3247cefa13aso5979800f8f.1 for ; Wed, 11 Oct 2023 02:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697015029; x=1697619829; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FBdHg52RbcScFIWBis5JPCbs4EFwutNb74y5hFI3muk=; b=XguleccvBkRPE/5miciF2rgnAiYT24fQPpEtPCtkcV2Bo7JQEWBbUM90f5SIO4VluE KN2feLXk1DDVz0Kmgz5ESr1OjXb3mfLQFAWYqvRMt4YtW8vMi3R4BtZwUloPoox++Jd9 3e/xxaAkNpH0ue/0V+k6y2XS7LlxPkBADqN0WiO4dFrUh9Nbhac2A/k5p4ejI1CT9bB4 gp1I5sKIMLuPL94bx0nvUn5H/Ft7CSj/mPNFQzkMRoonZHclG3/UB7rUCxrZN6w5Yt+K H9lMMEBPfivrf8g3XYho6IaqemAzn8VSbJVm3esah0AL69JotQyl2u20b0Wjz1hVhFNQ SSHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697015029; x=1697619829; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FBdHg52RbcScFIWBis5JPCbs4EFwutNb74y5hFI3muk=; b=Ewt3AWWG8uAJrLqaBpM1TBX2yFMk54GTzgv6vsbWsVn4FiFCSCJpYAVAjvRRuxB1+P iVQJaH/fNXsL4mUw/ytxLluzmc00bZHYJyMfZP8c5cjWdRxKdyxn3K3mvnSloba+REAr 0so4bM7ygwLDd1WC4rdzpkQ0j/CSg5xtv6YGAIulQBZ6rk1EmZvcqd0Q6Tn/8aDQbQwr y9D9lEbzvfGo/Zcyh58gJqO72obYImA9hyCmMRGNQ+8sG8H+y26kkdXKam6v/5q2BpS0 8wy9u7cxBLPpk/woHxqyIaDh+qaFaLMtwGla1ZeTelyx/J72I38I84OJ8aP2qZ04rZo+ +1jA== X-Gm-Message-State: AOJu0YyqYOLMlctn3D5wwOkp9HyN1hYbjoJvrjXZumfXVewv5MsMZJ5I FI/gKtdfy8GY+cf/n1tIy0tDypPghro8e2wTec0= X-Received: by 2002:adf:cf0a:0:b0:321:6bed:1646 with SMTP id o10-20020adfcf0a000000b003216bed1646mr17841695wrj.14.1697015028906; Wed, 11 Oct 2023 02:03:48 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:de95:eca9:6b1e:b330? ([2a05:6e02:1041:c10:de95:eca9:6b1e:b330]) by smtp.googlemail.com with ESMTPSA id d18-20020a5d5392000000b00326f5d0ce0asm14827181wrv.21.2023.10.11.02.03.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Oct 2023 02:03:48 -0700 (PDT) Message-ID: <96da3e12-7d40-458e-9f65-05606dca201f@linaro.org> Date: Wed, 11 Oct 2023 11:03:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next] clocksource/drivers/sun5i: Remove surplus dev_err() when using platform_get_irq() Content-Language: en-US To: Yang Li , jernej.skrabec@gmail.com, samuel@sholland.org, wens@csie.org Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20230831041414.66434-1-yang.lee@linux.alibaba.com> From: Daniel Lezcano In-Reply-To: <20230831041414.66434-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 11 Oct 2023 02:22:12 -0700 (PDT) X-Spam-Level: ** On 31/08/2023 06:14, Yang Li wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/clocksource/timer-sun5i.c:260:2-9: line 260 is redundant because platform_get_irq() already prints an error > > Signed-off-by: Yang Li > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog