Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   =?utf-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
To:     linux-media <linux-media@vger.kernel.org>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-i2c@vger.kernel.org,
        Stefan Lengfeld <contact@stefanchrist.eu>
Subject: Re: Sony IMX290/462 image sensors I2C xfer peculiarity
References: <m3y1gpw8ri.fsf@t19.piap.pl>
        <CAPY8ntASwh3AcRqE+2zF4Df=u+=wJ5K9icAeOrXTMJGDd1+caw@mail.gmail.com>
        <m3o7hfx3ob.fsf@t19.piap.pl> <m37cnuvmhn.fsf@t19.piap.pl>
        <m3o7h5tthf.fsf@t19.piap.pl>
Date:   Wed, 11 Oct 2023 11:50:12 +0200
In-Reply-To: <m3o7h5tthf.fsf@t19.piap.pl> ("Krzysztof =?utf-8?Q?Ha=C5=82as?=
 =?utf-8?Q?a=22's?= message of
        "Wed, 11 Oct 2023 11:10:20 +0200")
Message-ID: <m3jzrttrmz.fsf@t19.piap.pl>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWE3SHBsSW5xYmRmVndIc0cvdG94M1JHM0pGSjg0SzZUeitzSStoTGRZU2FE?=
 =?utf-8?B?cDZ4N0x0WnlvR2tOU3pHNlE5TnRiY2MyMUVtN0lMaUlVc2tldUVyU2xlUWs4?=
 =?utf-8?B?SjJnSGN2V1FOUXdNTVptN29ZSHFUaGxqZ1JHQmtBZFk2N0VJS0cxUHFwRVlk?=
 =?utf-8?B?KzU0NGUxOThoeHZvd2laZnhtWGdrNlFuV00yNXc4dFU5cG1kaVdHT2pZODkx?=
 =?utf-8?B?NHAxRzZ6RHN5UThjMlZ0RlU1YmNvdjBVRGxPL20xT3Y0N1hqaDNLYUw4dlF2?=
 =?utf-8?B?T3huc3llMEVGWitHMmxmcmtpdnhMSHpvRkpmL1BtRFRNQU1FNGdXT1p6M1BT?=
 =?utf-8?B?anljYXlVQWhqN29CK3AxdzI0cXBWdlBoRFJJRitHUk14U2JUdTRad3dPK3ds?=
 =?utf-8?B?VkxBUFJiN1B2K1BwckxEYmJLVVlQK1dXdnNBNGRNZ0hJMmk5Vy9mMWFsNHBp?=
 =?utf-8?B?TG1SbzNFSmErQ1pzSDVISjM5N0lraHRiNEZLRThUVUo0anBGdE9YSXUvalBt?=
 =?utf-8?B?ZFV1Z2wrbEcvQUt0Ym15TDRtK1lKNmszaVZVc2RqWFJ4ZjJkazdRSkp1Sm5U?=
 =?utf-8?B?MzhUQ21COE8zbGxXcGtHT09BQWZnZGhjTVJLWmh4dXhnT3ZyVHVidnI2aFJL?=
 =?utf-8?B?VEdjS29lRjZacFNGQjJNbi9tRW5xZC9vdnEwdGhKWllxVzkxcnl0K2o1czha?=
 =?utf-8?B?S0NGcnRLYWRFU1U3OGJiTUsyZEdNcVZIKzhXUEk5WHlBbjBOcFRZUHJZK2k0?=
 =?utf-8?B?RFUrancrM21yM01OdWpJcUoraUdzVUI3bXdOc0w1SElBTk9IRjY5a3cvc1lQ?=
 =?utf-8?B?UDJvZllaRUxjTngxTERvVElveGRycEV2VnVBL2FIQVAwaUdGS1V2MW9xaUtn?=
 =?utf-8?B?Qk5yM3BmR0ZyVExmN3NDRGNlalE0S1dEcEMzL25Mb21FNTJBaE53QnVCSFNF?=
 =?utf-8?B?YWtKWk14V3NwbTlUTUxZdXhoSmgwTSs1OW01WjgyNUJPVXNCeUFRdi9Tdmxs?=
 =?utf-8?B?ODNxWUxRQnJuZkMzQ3RSKzNwa0h2T1lMTnhNTmlnVWNqWWZDS0V4bzllN0Za?=
 =?utf-8?B?VEl0Q0s2ak1GblAxY1VUQ3VOd1BLL0l5MVdqRTBMZTcyckl1STZySHNlTzhG?=
 =?utf-8?B?eDYybVpBaC82ZEhmQXUyaWFwSkVEemRxVHFpZFBYZG1pL243bW9TUnFzRGFN?=
 =?utf-8?B?bVp4V05pZm1PU2tFdTI1WTV6WDJpZVNKK3NCSzNqQnd0TEpjdWlhcm0yQWpV?=
 =?utf-8?B?U1ZwOTVpQVlmZUQxbGd1RndsSWdDcWZ1bkYweHR0b2hmT0wwK1RPcW5wSnQw?=
 =?utf-8?B?ZHlCNTVXTWdTbDRCWWlTVStOQ1BWU1FadEVMekFaRDZlWitYV2pheW1ac0M2?=
 =?utf-8?B?YzUyMTlBaE1SQ2t2Q05mZk5lQ3pUZ3FESFVObzZhSXFYVG0wRkxLL2o2S3lm?=
 =?utf-8?B?RS9qZ1JKNjNtaU5TRlJRcUh6TVNGZWNOSDFlWk5MVzRmNlFlMjVkTnhvL1RD?=
 =?utf-8?B?MlZoUGg4bjZKVXRubHRSOS9SeTNYTXZPVERkbWdqS3B2SEo4c0xzU1c4cncy?=
 =?utf-8?B?Nm5jQitPSHZsVlB0OEYvSGJ3aWg2aDNVL1JuZEZtaElzcTcxcUk4OWM0TUlC?=
 =?utf-8?B?bDAvQ0loTHRmekp1cjRMdXErUXk2TXpCNHJMV1orb1FjNUxOclh1NW51L0xN?=
 =?utf-8?B?ZHZBLzNJMFRBaS83K3I1YmxMMENmVkJnNDdmQUptVkpHOUlTZEdINHNMbE04?=
 =?utf-8?B?SHNYaFJIVGFXbFo2dVZKbGUvd2IxYncyYktvK1FWZjFBREhPeGgzNnVnTjNn?=
 =?utf-8?B?dVA5TXVpTFBIRXdFN1NSY3FOenJ4MzBlMy9nSmc0QWh6YlcwOGR6RG5RbWUv?=
 =?utf-8?B?NzMwSWpBVlI3eUhSYnE4bFFnRUg0ZndPZFNVcjBKdGFtMjNLZkJzSlZseHRr?=
 =?utf-8?B?SVhaRWNuNDZrUG9qQjVQRlRkVTVTYUxVTmxPMTVoVDhxRWtjMUtUeGI4Q25p?=
 =?utf-8?B?Sk9XaWkrUXlFNk96WWxhL2puOUZPOGJ5elNsREJGZzdsajB0SGRvRlhTWHVZ?=
 =?utf-8?B?bno5WE82VmU2b1FkaGllMFhCQUFkckx2MTJIaU9rKzl4bUJtWFEwVjBNS2Jh?=
 =?utf-8?B?d1JwbE9mQWdRWnpQaEQrVkJ0MWVzVmhqV091VVExM2ExSU53VzJuOGhhUWRZ?=
 =?utf-8?Q?0bFmZCv+5eaPToxiQjboKiSM/wAN+MCrje326Ja+Snom?=
X-OriginatorOrg: piap.pl
X-MS-Exchange-CrossTenant-Network-Message-Id: e6c7f55f-255e-417c-35ad-08dbca3f772f
X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0685.EURP193.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 09:50:13.5504
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3e05b101-c6fe-47e5-82e1-c6a410bb95c0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PugwjyxbieOahBy/r2pqs+wGiOkVpSblbV0DEsLUI0C6aP+jNacgOGYpAwt1FY4L9o7z/6yhP5Ck8fDrT33eAvAnUkzeLPBMjfacZMIWMTYJ/Ft1YZ7R96cTU2dALLRih1bzuoyHt1wTJzQVXkV0kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9P193MB1786
X-Spam-Status: No, score=2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 11 Oct 2023 02:50:43 -0700 (PDT)
X-Spam-Level: **

Hi,

adding more people to Cc: as this is more general stuff than my specific
image sensor setup.

Is there any reason for the following (meta) patch to not be applied?

Currently, every i.MX8MP atomic I2C transfer starts with 100 us delay
(just after the START condition). At 400 kHz bus (384 kHz or whatever),
this is equivalent to several tens of bits. Is this delay needed?

This is on NXP 5.15 branch, but it seems the mainline is identical here.

With this patch, the 1-byte (quasi) atomic image sensor register reads
(16-bit address + 8-bit value) are down to ca. 160 us, and writes take
120 us.

It seems one bit on the bus takes ca. 2.66 us (hardware), and the delay
between consecutive bytes is ca. 4.82 us (I guess CPU takes a fair share
of this). This is i.MX8MP @ apparently 1200 MHz (1600 MHz with freq
scaler).

Fire away.
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -534,xx +534,xx @@
 static int i2c_imx_bus_busy(struct imx_i2c_struct *i2c_imx, int for_busy, =
bool atomic)
 {
     unsigned long orig_jiffies =3D jiffies;
     unsigned int temp;
=20
     while (1) {
         temp =3D imx_i2c_read_reg(i2c_imx, IMX_I2C_I2SR);
=20
         /* check for arbitration lost */
         if (temp & I2SR_IAL) {
             i2c_imx_clear_irq(i2c_imx, I2SR_IAL);
             return -EAGAIN;
         }
=20
         if (for_busy && (temp & I2SR_IBB)) {
             i2c_imx->stopped =3D 0;
             break;
         }
         if (!for_busy && !(temp & I2SR_IBB)) {
             i2c_imx->stopped =3D 1;
             break;
         }
         if (time_after(jiffies, orig_jiffies + msecs_to_jiffies(500))) {
             dev_dbg(&i2c_imx->adapter.dev,
                 "<%s> I2C bus is busy\n", __func__);
             return -ETIMEDOUT;
         }
         if (atomic)
-            udelay(100);
+            udelay(1);
         else
             schedule();
     }
=20
     return 0;
 }
--=20
Krzysztof "Chris" Ha=C5=82asa

Sie=C4=87 Badawcza =C5=81ukasiewicz
Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP
Al. Jerozolimskie 202, 02-486 Warszawa