Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Wed, 11 Oct 2023 18:27:28 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Phil Auld <pauld@redhat.com>, Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        "Biju Das" <biju.das.jz@bp.renesas.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        <linux-kernel@vger.kernel.org>, Tim Chen <tim.c.chen@intel.com>,
        Chen Yu <yu.chen.surf@gmail.com>
Subject: Re: [PATCH] sched/fair: Use printk_deferred instead of printk in
 pick_eevdf()
Message-ID: <ZSZ4kHnpQa95saJr@chenyu5-mobl2.ccr.corp.intel.com>
References: <20231010032541.339606-1-yu.c.chen@intel.com>
 <20231010075928.GA377@noisy.programming.kicks-ass.net>
 <20231010122600.GA477540@lorien.usersys.redhat.com>
 <20231010141244.GM377@noisy.programming.kicks-ass.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231010141244.GM377@noisy.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Zw4CTNZ9EwHF0tb9iBGisq0iP0RB/EJkx36jl/Wkd7BXfKamTxETakSNOKaK?=
 =?us-ascii?Q?HIR17UmRz71H4ATEUMdDH3/8tIGWmqpQAp3UDUaqA+LvQ0U6kOnVGMPgoM+1?=
 =?us-ascii?Q?uITuRS5EjaZlQty15jz4e1X3QhY5W0rj8iGe7yUcxsaxZHX1wKWhdDupQx6V?=
 =?us-ascii?Q?AhWq5MwGDWW/FPLT0/TBeWk8yf/DDX/5A4vAJYnq8yqptyW2kpwADNEUCRF0?=
 =?us-ascii?Q?pcHVgYWiaJmz+H9vzK7ltV6V0B4catIQkejvNUUbSqylT80tG7rZiuDfsmnD?=
 =?us-ascii?Q?SOVmuLd8wCa63JTslT5zJrIGjHnA9cEeae9YEcP0D9SGlEEXxQ3griX22oFB?=
 =?us-ascii?Q?f6MxTqLrpMT2AiDZGhl0gWjkNFl/EziTZnyVuE8hRF9DUzGGD97UGKTe9Z9b?=
 =?us-ascii?Q?HDqFiTwIHk52oK9iV5Fp0Y8yZcPPAKUh5zTFg10Ema7DPLs4x64V+VWsi5Dz?=
 =?us-ascii?Q?pvY7ApRdjtb+fJ2cTwaXRLUnIP9Hr6i6PadjgFMMrenda+7Sr8IDmlEq5HCF?=
 =?us-ascii?Q?l+VWO5UBO77AoLhBYSVs0q//FksqVwDJ9gxt96Pxe4Ia/k9Jp0v9wtr7Hau5?=
 =?us-ascii?Q?IHNYcVwa4x/PHwmR192XUJp8Ad5kvsf+xQAECZ9pyJkJMbBf7ZGPwqUk/6Ho?=
 =?us-ascii?Q?9H9v6IYxEd8n7Mzer0VfwPmxZVSy2IXiERuU60poSmivfVm8gnwYhjTAgVv2?=
 =?us-ascii?Q?8qZGq3OHfnBHy+fgOwCPjw5jl7yzPmJLZeEpCcRH0FQUS308ckBVWXoUKAN1?=
 =?us-ascii?Q?j4sCmtEGj2Ib1LB8n5xs4SyVVBUbOVa4rtm58gPjmJ92wSr6AbZfSyytadNK?=
 =?us-ascii?Q?CUIQAf6h0ZLlXzIJbPZKmmIQBfESWMTmaglQna0gA0fmzLo9N/toMVcuxc0v?=
 =?us-ascii?Q?pXLwifrZbhj18eFApiZYpwBWZ8BfudCager1ey9q3qSnvgsP2hs5XtQroAFK?=
 =?us-ascii?Q?i7L8PoF9nWjFCZPzI2Vbt1vh+bXowfBwofAf0JpIoqfdKTw/DnAwCy8PjelS?=
 =?us-ascii?Q?eU5dztDw+GVfe147hIxLbKEZ/AbAqKo50lz44v2hguBEHDyf6Bb4w5MSaIzm?=
 =?us-ascii?Q?oVZm+iOagLz9+bW/aEyqwd+G+bAHuhGk1zmI3U3nojQtuwJeAmYCSaWchfAn?=
 =?us-ascii?Q?Ch0TJyI3gubFqUQsZTS0ERlAMR0z8Ot15aNFGc3/Yyly+q/8JUuDb0JA9hgH?=
 =?us-ascii?Q?0ht9BEbPaVpQfPaNX/AXQkFtuvDUzvWcWouzH7RcioEGWhdVVQ9IahRirW55?=
 =?us-ascii?Q?m4ZeNnCqb2TobVxH22+O1VruOIKuXm99Hm4CHA2dpTGPuDQycu2khKKmm9Ky?=
 =?us-ascii?Q?3hh5KOCz9AETH8yyDq5rTM8JbBUfHBLUCkFnm9j0K/kJQ721IaAYeLE0Oh5M?=
 =?us-ascii?Q?2yDVUwImHitjOaGIlTq1AyYYu5K9W3ubf2HegKT9T3zahzVWzqv0WfKIPhu/?=
 =?us-ascii?Q?UAlQ6Pof2oWLtoULQTKjmbGbhpdr1amfOS1BSI1hcWRkEsa2PXJ5LxMOWvk6?=
 =?us-ascii?Q?FLwEEEgF2xLfrFbGuYuEdcKic9dv/vO+HxG/xHm3kYJL1n4JipPSi3FI7dAX?=
 =?us-ascii?Q?7rmrCTOUTtqNyhJGnzZ4THIFNPVSkIGjSazOGYok?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fd20192-a0ae-4253-bc8f-08dbca44b19e
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 10:27:39.1658
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F43FodOUxK0oWpxOkvR9UxssszFQ0GMSB26KbjkzB1q3wTSKAwftQ9AgIrnlTBSGDdilKuMiWLAeWuG2sSwcMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8468
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 11 Oct 2023 03:27:54 -0700 (PDT)
X-Spam-Level: **

On 2023-10-10 at 16:12:44 +0200, Peter Zijlstra wrote:
> On Tue, Oct 10, 2023 at 08:26:00AM -0400, Phil Auld wrote:
> 
> > > No.. I detest printk_deferred with a passion. This is effectively a WARN
> > > and we don't do silly buggers for them either.
> > >
> > 
> > Sure, printk_deferred is not ideal, but is getting this message in the right
> > order worth locking up people's machines?  Not sure you get the message at
> > all when that happens.  I have to dig the code location out of the crash
> > dump to find which sched warning fired and took down the (usually virtual)
> > machine.
> 
> Same thing with WARN(), we don't have a silly bugger version of that
> either. Just use a sane printk() / console or whatever.
> 
> Virt stuff has perfectly functional serial consoles that works just fine
> and don't lock up the machine -- mostly. Use my early_printk hacks if
> you want something reliable:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=debug/experimental
> 
> Boot with: "earlyprintk=serial,ttyS0,115200 force_early_printk". And all
> will be well.
> 
> The fact that crashdump is more reliable than printk is a *BIG* problem
> and the only solution is fixing printk() (people are sorta working on
> that). We should not try and work around this problem.
> 
> I fundamentally despise the delayed stuff, I've had countless insteances
> where delaying output means you have no output because the machine is
> dead.

I see, thanks for this information.

thanks,
Chenyu