Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Wed, 11 Oct 2023 13:28:37 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Raag Jadav <raag.jadav@intel.com>
Cc:     linus.walleij@linaro.org, mika.westerberg@linux.intel.com,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com
Subject: Re: [PATCH v1] pinctrl: cherryview: reduce scope of
 PIN_CONFIG_BIAS_HIGH_IMPEDANCE case
Message-ID: <ZSZ41Xwg3Z6H/Bhm@smile.fi.intel.com>
References: <20231011064533.20549-1-raag.jadav@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231011064533.20549-1-raag.jadav@intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Oct 11, 2023 at 12:15:33PM +0530, Raag Jadav wrote:
> We have a couple of pinconfig cases inside the braces which are meant for
> PIN_CONFIG_BIAS_HIGH_IMPEDANCE case. Although it is valid C, it makes the
> code less readable and prone to misinterpretation. Limit the braces to
> PIN_CONFIG_BIAS_HIGH_IMPEDANCE case to avoid this.

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko