Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Wed, 11 Oct 2023 18:30:24 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Phil Auld <pauld@redhat.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Biju Das <biju.das.jz@bp.renesas.com>,
        "Marek Szyprowski" <m.szyprowski@samsung.com>,
        <linux-kernel@vger.kernel.org>, "Tim Chen" <tim.c.chen@intel.com>,
        Chen Yu <yu.chen.surf@gmail.com>
Subject: Re: [PATCH] sched/fair: Use printk_deferred instead of printk in
 pick_eevdf()
Message-ID: <ZSZ5QE/r6GD5mOEf@chenyu5-mobl2.ccr.corp.intel.com>
References: <20231010032541.339606-1-yu.c.chen@intel.com>
 <20231010075928.GA377@noisy.programming.kicks-ass.net>
 <20231010122600.GA477540@lorien.usersys.redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231010122600.GA477540@lorien.usersys.redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cWnxEU3efBGYiLIqZgowcpyo2L5rBpJ3RzTV6feGSuxoeRYWriwOPdCZjUxA?=
 =?us-ascii?Q?roGCPZlH/IBuIN5ofOMjTkx8iQNcYP+f7niXtaKi5Jx8j6tTYh48IRHew8SX?=
 =?us-ascii?Q?iu1tOFmeI4Dcd4klls2PTwQGvIhZpRDJ0ufG8HOXxHuSpYLQOI6byY6akpgv?=
 =?us-ascii?Q?XxS2AHnyfNp/uTxzO0o6FFisBUGEuBDEo8VyeXzwhWhtzYHw4Jo0mKslGPlP?=
 =?us-ascii?Q?GeqnN/qfmHL2CdjPf+fhLPwN1DemtjsUGqDCUdCKmyiHRG5iHMVXmZfNrNMN?=
 =?us-ascii?Q?WEc2ru08nm285Ptvtkzu04MmJa/wtwrv4shGtmQML+LUAFp5F4G3+sej7ly+?=
 =?us-ascii?Q?hmYdf38RjKrbMmsoBSn2PwrC6kqW7iYWYm4RHR7W0bKNn3pZXgdS6ZbbxT8r?=
 =?us-ascii?Q?KCTQUoXRDFLPt4h+dFFCVIuJnQxvh5CDN23AmRf+kYduaTbyL1pVGNJeUX9s?=
 =?us-ascii?Q?JQXr/r9o5mGqX96qwRsHNaW3q/yWPTizjSiQqxpc8lVszxulyVV3gLTgxmO6?=
 =?us-ascii?Q?amfIv1o3ybR0h+dAsN1XP3Jxy94x145q1nZZCDuWGNLu7ocqR7PXBbOcQHY8?=
 =?us-ascii?Q?EKplEGI8YBhB8md8mSlbacqG3QM3pG80K2pY8tbrCxJbLfYyWiMU/Wec7JHo?=
 =?us-ascii?Q?AbiClYOQfbs5cKkG+2SPkcveJBEsZN8bWBNH3krkoiRg0CMwHoAY6mlETruk?=
 =?us-ascii?Q?fuSEB27aEHSpI4e961V+uifuX0Q3eTgzgFvTre0UD22od7p2T9llAFqKLqUS?=
 =?us-ascii?Q?U/p2KJtyXDhCwI/4J6sNLdEsqhEKKQy6N9oQ4AdW+tJW41dM/wHjUXfZ9/hN?=
 =?us-ascii?Q?XaFLItUFpQEG44o+st4CSA9CE4WJsOopfMPyRP6PIFyQQ8THIfc9AcLiSlcF?=
 =?us-ascii?Q?u1ppRLxt/Nt/sKuys1ggqb/GB9MGASZ+Qfqtjdu0iE64lXIN8ANv/EV30K+w?=
 =?us-ascii?Q?2adx0ge5wQGijsuXWcS/QlV/lnQUwMkM/KVW7JSmZpfFO1zcvHTVjNHl6tF0?=
 =?us-ascii?Q?9DP5Cn6oK2NgV4xRl5OmHjG+s21NDVKEacqF37gF7VI+nedd3sVMv8/O/XIU?=
 =?us-ascii?Q?Lp4psy/jFixXMLta/RUvq/CVGlW9HL2XdYWx6wIwHnYIDi0ADc+fYz9Hf4ge?=
 =?us-ascii?Q?FYs7UQzb0LOsCHfu6G1Y8zp1eOCpIxe6nXjdmzIVholYj4Sb2bW8XNFFf6tI?=
 =?us-ascii?Q?Gg3EgZ4FqfOp8aKXhiunNKL3lN43HViaA4Qudd0pfh+XSNWpZ6fLC9hfz0NW?=
 =?us-ascii?Q?FqcWB6OpjIJ2TIF7uivMOa/eAH+SRxBn8+KU0Vy69uWM84hTksZa004sK5lS?=
 =?us-ascii?Q?gmLZ8lf+2p+TEOelDblJumTOKYLexjfD0kenPHJiRHmwf1yhvMQ7aGYfp7yB?=
 =?us-ascii?Q?xGF3PJv3WtsnguTyhxIqyL8xdz130keUG7YimjUeWVCPP+6uT1TEC/8tuZqx?=
 =?us-ascii?Q?fYAiF6ihOdkB2LDh9VHPtw05i6BcRM5aym3bta+x7Ztljj3l7L1E/7Sr+MoS?=
 =?us-ascii?Q?LJATSVOj32eQu8xSOvhBmyyi2ACrrt29G0kuQhZSuMybr11zGjSP72xCMsLm?=
 =?us-ascii?Q?90ES/XSwsQMtH6YbV0KCoBlrZ2oZG9z9/Hd1eb2H?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c2d95be6-626a-4d0c-d237-08dbca451b7d
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 10:30:36.6636
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SUug9kUztJR7UqSudTlHl09TSX+U+Sd938ecb31POlq/7JY6DEU+1Qonz2ToaKYK82oC7YJ4xE2tRztltdlxhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8468
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 11 Oct 2023 03:30:53 -0700 (PDT)
X-Spam-Level: **

On 2023-10-10 at 08:26:00 -0400, Phil Auld wrote:
> On Tue, Oct 10, 2023 at 09:59:28AM +0200 Peter Zijlstra wrote:
> > On Tue, Oct 10, 2023 at 11:25:41AM +0800, Chen Yu wrote:
> > > When no eligible entity is found in pick_eevdf(), it has to pick
> > > the entity with smallest vruntime. This indicates a potential issue
> > > and scheduler will print this error.
> > > 
> > > However this printk could introduce possible circular locking issue
> > > because when the code path reaches here with the rq lock held, the
> > > printk could trigger further scheduling which loops back to the
> > > scheduler.
> > > 
> > > Use printk_deferred() to defer the console write from current context
> > > to the irq work in the next tick.
> 
> Chen: I was not actually suggesting you make this change, just answering your
> question about printk/rq lock.  You don't need to put that line in there.
>

Phil,

Sorry for misunderstanding that, and thanks again for your guidance.

thanks,
Chenyu