Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Wed, 11 Oct 2023 13:38:07 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     =?utf-8?B?S8O2cnk=?= Maincent <kory.maincent@bootlin.com>
Cc:     Manivannan Sadhasivam <mani@kernel.org>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        Vinod Koul <vkoul@kernel.org>,
        Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Herve Codina <herve.codina@bootlin.com>
Subject: Re: [PATCH v2 2/5] dmaengine: dw-edma: Typos fixes
Message-ID: <pa7nvziczcnj56oozkgy244avbeirkseviimwmaxxlm5ozrjuo@plvebecoc4ev>
References: <20231002131749.2977952-1-kory.maincent@bootlin.com>
 <20231002131749.2977952-3-kory.maincent@bootlin.com>
 <20231010145906.GL4884@thinkpad>
 <20231011092350.18049672@kmaincent-XPS-13-7390>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231011092350.18049672@kmaincent-XPS-13-7390>
Precedence: bulk

On Wed, Oct 11, 2023 at 09:23:50AM +0200, K?ry Maincent wrote:
> On Tue, 10 Oct 2023 20:29:06 +0530
> Manivannan Sadhasivam <mani@kernel.org> wrote:
> 
> > On Mon, Oct 02, 2023 at 03:17:46PM +0200, K?ry Maincent wrote:
> > > From: Kory Maincent <kory.maincent@bootlin.com>
> > > 
> > > Fix "HDMA_V0_REMOTEL_STOP_INT_EN" typo error.
> > > Fix "HDMA_V0_LOCAL_STOP_INT_EN" to "HDMA_V0_LOCAL_ABORT_INT_EN" as the STOP
> > > bit is already set in the same line.
> > >   
> > 
> > You should split this into two patches. First one is a typo and is harmless,
> > but the second is a _bug_.
> 
> Thanks for your review.
> Ok I will do so.
> Serge if it is ok for you I will keep your reviewed by on the two separate
> patches.

Yeah, it's ok.

-Serge(y)