Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.118.233 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C
From:   Kartik <kkartik@nvidia.com>
To:     <andriy.shevchenko@linux.intel.com>
CC:     <arnd@arndb.de>, <digetx@gmail.com>, <frank.li@vivo.com>,
        <jonathanh@nvidia.com>, <kkartik@nvidia.com>,
        <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <pdeschrijver@nvidia.com>, <petlozup@nvidia.com>,
        <pshete@nvidia.com>, <robh@kernel.org>, <stefank@nvidia.com>,
        <sumitg@nvidia.com>, <thierry.reding@gmail.com>, <windhl@126.com>
Subject: Re: [PATCH v3 3/6] soc/tegra: fuse: Add function to add lookups
Date:   Wed, 11 Oct 2023 15:07:35 +0530
Message-ID: <20231011093735.8069-1-kkartik@nvidia.com>
In-Reply-To: <ZPnfmxqI12OsQRPA@smile.fi.intel.com>
References: <ZPnfmxqI12OsQRPA@smile.fi.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 11:20:05.8432
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 97df51d5-8721-43ec-7df2-08dbca4c055f
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D2.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5221
X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SORTED_RECIPS,SPF_HELO_PASS,
        SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 11 Oct 2023 04:23:04 -0700 (PDT)

On Thu, 2023-09-07 at 14:35, Andy Shevchenko wrote:
>On Thu, Sep 07, 2023 at 12:40:49PM +0530, Kartik wrote:
>> Add helper function tegra_fuse_add_lookups() to register Tegra fuse
>> nvmem lookups. So, this can be shared between tegra_fuse_init() and
>> ACPI probe, which is to be introduced later.
>
>...
>
>> +static int tegra_fuse_add_lookups(struct tegra_fuse *fuse)
>> +{
>> +	size_t size;
>> +
>> +	if (!fuse->soc->lookups)
>> +		return 0;
>
>> +	size = size_mul(sizeof(*fuse->lookups), fuse->soc->num_lookups);
>> +
>> +	fuse->lookups = kmemdup(fuse->soc->lookups, size, GFP_KERNEL);
>> +	if (!fuse->lookups)
>> +		return -ENOMEM;
>
>Why not introducing kmemdup_array()?

Introduced this in v4.

>
>> +	nvmem_add_cell_lookups(fuse->lookups, fuse->soc->num_lookups);
>> +
>> +	return 0;
>> +}
>
>...
>
>> +	err = tegra_fuse_add_lookups(fuse);
>> +	if (err) {
>> +		pr_err("failed to add FUSE lookups\n");
>
>Why pr_err() and not dev_err()?

This is called before tegra_fuse_probe in device-tree boot hence the
reason behing using pr_err instead of dev_err.

>
>> +		return err;
>>  	}
>>  
>>  	return 0;
>
>These four lines can be just shortened to
>
>	return err;
>

Updated this in v4.

>-- 
>With Best Regards,
>Andy Shevchenko

Regards,
Kartik