Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   =?utf-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
To:     Stefan Lengfeld <contact@stefanchrist.eu>
Cc:     linux-media <linux-media@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>, linux-i2c@vger.kernel.org
Subject: Re: Sony IMX290/462 image sensors I2C xfer peculiarity
References: <m3y1gpw8ri.fsf@t19.piap.pl>
        <CAPY8ntASwh3AcRqE+2zF4Df=u+=wJ5K9icAeOrXTMJGDd1+caw@mail.gmail.com>
        <m3o7hfx3ob.fsf@t19.piap.pl> <m37cnuvmhn.fsf@t19.piap.pl>
        <m3o7h5tthf.fsf@t19.piap.pl> <m3jzrttrmz.fsf@t19.piap.pl>
        <20231011101553.we3r73xejvqdql5j@porty>
Date:   Wed, 11 Oct 2023 13:25:55 +0200
In-Reply-To: <20231011101553.we3r73xejvqdql5j@porty> (Stefan Lengfeld's
        message of "Wed, 11 Oct 2023 12:15:53 +0200")
Message-ID: <m3fs2htn7g.fsf@t19.piap.pl>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGxWZ1dsb0o2N3RkWEhvcjAvcEhkZEdkaFFlelRxdTd0WUZZZTc2YTVGMTg1?=
 =?utf-8?B?RGVDcC9CQVE1RGR1WndqalgwbWRpS0FJZXFqSFMvM2VNalhud3d0eGZMOXJI?=
 =?utf-8?B?N082ejI2dmlmQlVhMWgvZ2srdzdpUTV2VlFZYThuTWRUTUpoNnB6M2krSGRV?=
 =?utf-8?B?UTRHZVV3WjhKOUZib0RmTzgvTWx1dWx0Zm5UQXNGQjF1YUJjSWlYeHBlSkpt?=
 =?utf-8?B?cGFNU0JJZzJGTDg4WXJzcHYrRkRlUjB2OFVjRkl6NTNqWDZLNHNacTdyM3F0?=
 =?utf-8?B?TVdYWFBtZFFjZFN1ZWNIWEoxRCtxeW1SbDhpdzEvTVh6elVubGpkaG1mc3Jr?=
 =?utf-8?B?WHNYSVY2NjM2WDVlUTN4MHRlbXBWcy9nTzR1RDF1RjVnR2tDVVhqb3M4azYv?=
 =?utf-8?B?UUwrSGhXWnJJQ0NaTkptbmt3RzltcGdoemcvMWpCRXpSdzBTVWF1cTRXL1pV?=
 =?utf-8?B?amxHaWY4dmpsS2NjZFk2TnZrT29aQmUxWXF2VnM1VE03a2c1SlJyeU5VeERM?=
 =?utf-8?B?QzVyMlhVd2tuUzF3ZEx5K2x4RVhJcGhFNitoS0NXNUVsZURINnJpTVJUc3M5?=
 =?utf-8?B?a21YVzkrWUl4TWVXOXJqMy9CdEdUWHBuRThYRDV5dEYyR05DSUErU29mSG92?=
 =?utf-8?B?ZlJSQzhUbVMyZWUyaDdKblRaekt0emppUW5QZWRmeExiakJtS1dPdmw0Zmlk?=
 =?utf-8?B?VFRLQzgxVnU0QTVBdEVJdGlvK3RlY3JFMmw5VkxVM0R1L1lPUEZPV0l1V1Vw?=
 =?utf-8?B?UStmY0ZMcmJWZ0EwcExzQkFwNjN4LzZvbEx5RlpBa3A2VjdyZkJwaURKeTQ4?=
 =?utf-8?B?enJoZUFrUEVvdjEzRHlkSkc3WU9sWXovcTFtRm5PZTgyak1DbGxtQTVKSEZa?=
 =?utf-8?B?OGVpT2w1WVFwSHFxRmg2SzVpM2o5ZWJ0Z1IrMGYyTUUydE54WW9DL1ZWN0Jh?=
 =?utf-8?B?Wi9XZjhjRm4xeVhLcDQrVGFLbk5IdE5wQUIzcjhCZSsvTHkvQVdMTC9rY0hG?=
 =?utf-8?B?WWVRSjhJMkxlR2Y0ZFpsc2xvOVl2M1RuVTBtMGh4OXNrdjdiWFN1YzZyM3ho?=
 =?utf-8?B?R3dhTkdndWVwZFdxQlU2MTJVV3hRS0hvakxxVXo5LzNBbU1ITnRSVVJ6S2tu?=
 =?utf-8?B?bkdsRHhWSUpkYVVnQ3FKb01KM242RkRtbGRvQVNEc09jSEFwOEk2V1NqK1g2?=
 =?utf-8?B?bUV3Ukdobmp0bHRvZkcwUGRmZW13WE9TTC9URXIxN1FmbnI0UEEyVVFidkMy?=
 =?utf-8?B?bWVCTWhqaWtwb3dtUnYrQjdsaVVaRVRQM0pGY1luRjcxS3FMVWFMYnExTU1l?=
 =?utf-8?B?ZmJHY0pLYzIwMFlqTXI5WTRoNlJKeTgxY1AwWm9TQk9hZ1dQTitkZ2Nmd2pN?=
 =?utf-8?B?UmFTdHdTTHppZ2U5WUE5OUhuL0wrdlU4Wnk5TmhXcVBwbTNpS2UySWtzbUtJ?=
 =?utf-8?B?QnpVTTR3aVNSRC9qL2o5U1UzTWdXblFFRGo5eCthb2svaWhjcUhrREtmYzhT?=
 =?utf-8?B?ZGl0bEtMRGhnTU1LMUhLSHB1SDZ6amI1bjYyL2d2SERpcWJpN1U3U3pnR3NX?=
 =?utf-8?B?a21UK29nU3JDQmZRLzhZam9hblNSUDZ1Tkk5YVNhcFNtdzYzTk03MDkrR0VF?=
 =?utf-8?B?dDljckFDeVZaak9HbVR3b1BDaDZKTlN6UGhjZVRIY2p0SGh0SEN1WUxHaFF3?=
 =?utf-8?B?Q1VXeEJhcTVhKy9NWXBGUkhuQVYrbFlYMXBqVFhCMGpIVUtWOW1kbG5nVmJF?=
 =?utf-8?B?YkVsVzZoQ2huekdMeCtHVWVhdU9vUDdmdmJEYWRuUWZYT2QxcUd6ZmVWeEJy?=
 =?utf-8?B?akRjcnF5M1hyZDNuOHV3ZVZMY1YwVy9QWFJoeEg3S09zcDRGeHFxdlRaaHFD?=
 =?utf-8?B?VWRkaWExa056WHVxVlA0WFVxb2MzTk5IZnR1RGVMYTdCajJKeTJtSDBzcFJj?=
 =?utf-8?B?TXkxM3doZGwvVkVaVjlmNk5FSVJ4RHNhY0o2YkRuZzcvbVVFZWpZRCtpSHU5?=
 =?utf-8?B?RmgvSGd6Y1JRaHpGcnJ5bitoTWl5Q0xWNkRvcDMxeVNydGwyb1FqeDFmU0M2?=
 =?utf-8?B?SmNtVmUxU1hzb3JpT2drY1V6cFlieVMzT21VOU5Kdis5Qmd3RkJ3SVpmV0FL?=
 =?utf-8?B?UEMzQzZuN01MYlVVdXNDMGJnZUNXMk5xQ2RTVGt4ZTdVd3ErMURBV3ZCenps?=
 =?utf-8?Q?E84cEhvjiJ/2Nz4s05C2t17KECzidcKsXwJuUbsr1k1l?=
X-OriginatorOrg: piap.pl
X-MS-Exchange-CrossTenant-Network-Message-Id: 767bc278-32c3-48a3-00a4-08dbca4cd660
X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0685.EURP193.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 11:25:56.7257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3e05b101-c6fe-47e5-82e1-c6a410bb95c0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: chnB0sWvtOyRTZwoU9Uktc5SyUybPPRewqPWbZhb6yBwjCVFEG+CtDOQ+DOxesrT5j9W+nrSm48R6oDjSwMiggttzd8Q3j/pPftK3FlttPkumIKWV6NXlH1fnzJj+LFeV2E4P82hnr5B59zaHSIU9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P193MB1176
X-Spam-Status: No, score=2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 11 Oct 2023 04:26:16 -0700 (PDT)
X-Spam-Level: **

Stefan,

> I cannot answer whether the delay is needed for atomic transfer or not.
> But I can give a bit of context for I2C atomic transfers in general.
>
> These where only introduced for a very narrow and special uses shutting
> down the device/power with external PMICs in the kernel's shutdown
> handlers.

Well, I guess I'm abusing this code a bit.

The problem is I use Sony IMX290 and IMX462 image sensors, and they have
an apparently hard-coded timeout of about 2^18 their master clock cycles
(=3D ca. 7 ms with my setup). After the timeout they simply disconnect
from the I2C bus. Of course, this isn't mentioned in the docs.
Unfortunately, "normal" I2C accesses take frequently more than those
7 ms (mostly due to scheduling when all CPU cores are in use). So I
hacked the IMX I2C driver a bit and now all accesses to the sensor use
the atomic paths and local_irq_save() (inside the driver only).

> My understand is that an ordinary I2C device would just use normal (and
> sleepable) I2C transfers while the device is in use.

You are spot-on here :-) Now I use IMX 290 and 462.

OTOH I wonder if such issues are limited to those sensors only.

Thanks for your immediate response,
--=20
Krzysztof "Chris" Ha=C5=82asa

Sie=C4=87 Badawcza =C5=81ukasiewicz
Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP
Al. Jerozolimskie 202, 02-486 Warszawa