Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp745026rdg; Wed, 11 Oct 2023 04:33:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7QobjxxLJDHymFSTAivL8ONcEC92LSk1rg2kq0678BJLX4aeW3mzllH241o2gEbR6859m X-Received: by 2002:a17:902:db06:b0:1c4:2ca5:8b7c with SMTP id m6-20020a170902db0600b001c42ca58b7cmr20507388plx.61.1697024027916; Wed, 11 Oct 2023 04:33:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697024027; cv=none; d=google.com; s=arc-20160816; b=KrVUofsVdaYVxeOl3tmYp7xBtEVR+b9/t7mYBhuiO5WfiQKUuSuEVdc5jnzGfX+wCA eI4drph5AjUKqbsPJqfCzz9494Zfo0rLt1ZXx53XLNYaXXrsu4c+/NWDkZAFZf9dAo3b CkTZXZY9WLzlHFfSkASd2QzjrC1ol6KlGzvgbLzcM7K2rrcg25j65L5kAZ8eKGRW6lsM 6Nd7HshkwpTLurWnwc1p5Nk9DkGmYpCvHcflaHCJWIDblkPNbCVMyURTKjAkcPmls8Mp rgxIgiM64RerYcXe70n3IskFf5V/uQX/ENLlm7HwB8Y6/hGR3wxafugm1K0KFgvBuvs3 J4CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=NZzIfsUIMKmIPZuNBx7E7QsUZucBviLZv516iI+4Ocg=; fh=R6VROgAMDUQj+n4QNtfaru8NVjmlbCsm41OL67e7iLw=; b=DjHOVsTxWzhtwXWQsn6us396ZU8euQGTEEGsUaegncV88zQD8dcDtLJ3o15vk9tFVc 7Ld+YYP9YTYzM/n7Lh/i8KxFEXkUbzVSn1IE7789cp0cize6ENG+gOfdzYheZIOta0Ei yiC/AGEDEjhxY+Yh63h2I8oetBCd5Bzwkfox5hWG2khhrjkUUMx1cpPAITQ4BdJmS783 ltU4HzewvYlp8u9CUu7IbjB8OOznuqHL3f8vHsHcEh89eMF1s4NMS2QyUZn3uJCvBUQR wWEjT3FCoJl1AZSHtknZMpctnkwl82gorVb6vgQ/p+sLA/4RcNT/ale1tbjI/K8uNQOm ZNUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XI0cRoLa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id q12-20020a170902eb8c00b001c73738781dsi13541322plg.609.2023.10.11.04.33.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 04:33:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XI0cRoLa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id C07858113EDB; Wed, 11 Oct 2023 04:33:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346388AbjJKLdc (ORCPT + 99 others); Wed, 11 Oct 2023 07:33:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346246AbjJKLdb (ORCPT ); Wed, 11 Oct 2023 07:33:31 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C015A7 for ; Wed, 11 Oct 2023 04:33:28 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4066241289bso63441585e9.0 for ; Wed, 11 Oct 2023 04:33:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697024007; x=1697628807; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NZzIfsUIMKmIPZuNBx7E7QsUZucBviLZv516iI+4Ocg=; b=XI0cRoLaEk0gElbpQX2B2oKaOHoLEPNWsFPXilKB56OVnnnhxp7U8TJSTwrhAoNiSy CkR7DBeSD3WPuzb0DC+fiS16GD28nmp/q8y79L3ACQ6sywwIUTaIaEldJ10LX2Z4hg6G ySeiOn2MTA/0f0WRK8PMdxow0BvLdhsH6bdxspc8KDbLi+2JEoUJNTT/UwnZzvJRVCdL m1yT9vjcdDqqcKgmsGgjqYfxgwOUvepF2f5+10Ga/tTv5JYyJN4xY3PMWm4x/wDgTEtC zqrQ5erlbRS8cVLqeQBl0tJtP2a7GIHGx9W8qmrvS9vMXh3F4lTHSr/muM4yHWtU+j+F eEgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697024007; x=1697628807; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NZzIfsUIMKmIPZuNBx7E7QsUZucBviLZv516iI+4Ocg=; b=eOgMURJlMlIGHRkTXEl85P4Wah7qf48ofgb4JpN1CPRbVmNhJuVqHgsT6HgWQNGlty VGQ+FjnKhfKFZaespVfznk72o9HCKDo6iaOKiVC5GtgbpK5wszquTRTr2XeKt0BMzH5M N3mb3bxg6PSIOZGV4aHXHSHO/ZkrjSny83SCEWOmjKytOYE1adoWmYYrpS3Sxus3ij4/ JgVO5JsiED6ucbWAtIk1zIK5oNMvzPnRA/ucYHelMaiLB/Nkb6AdVXXbbey1dtIr3qKk OlayNAw55XxhwQsdH2DLrP9G2+3u9YuaOzY3DbcUrxMZh4+mpSD6QrBkb1GFOlZR36iu fDSw== X-Gm-Message-State: AOJu0YzEAUQJDhnYbm70vLqh47JeROhV+QKtsEnm4dv47YB/7iYulDlS HGhTROG9Run7iHm5GUiq84Uy7g== X-Received: by 2002:a7b:ce19:0:b0:405:3e9a:f1e3 with SMTP id m25-20020a7bce19000000b004053e9af1e3mr18935659wmc.11.1697024006816; Wed, 11 Oct 2023 04:33:26 -0700 (PDT) Received: from [192.168.100.102] ([37.228.218.3]) by smtp.gmail.com with ESMTPSA id u6-20020a05600c00c600b00402ff8d6086sm16479381wmm.18.2023.10.11.04.33.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Oct 2023 04:33:26 -0700 (PDT) Message-ID: Date: Wed, 11 Oct 2023 12:33:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084 Content-Language: en-US To: Jie Luo , andersson@kernel.org, agross@kernel.org, konrad.dybcio@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_srichara@quicinc.com References: <20230923112105.18102-1-quic_luoj@quicinc.com> <20230923112105.18102-5-quic_luoj@quicinc.com> <10bcb0cc-19db-4914-bbc4-ef79c238a70d@linaro.org> <49c8a8ff-bdb9-a523-9587-d2a46d401e41@quicinc.com> From: Bryan O'Donoghue In-Reply-To: <49c8a8ff-bdb9-a523-9587-d2a46d401e41@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 11 Oct 2023 04:33:46 -0700 (PDT) X-Spam-Level: ** On 11/10/2023 12:26, Jie Luo wrote: >> >> 0004-clk-qcom-add-clock-controller-driver-for-qca8386-qca.patch has >> style problems, please review. > > Thanks Bryan for the review. The code line mentioned by CHECK is more > than 100 columns, so i separate the lines. Yep. Remember to align the indentation as much as possible/reasonable. Use your discretion. --- bod