Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Wed, 11 Oct 2023 09:00:26 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     "ankita@nvidia.com" <ankita@nvidia.com>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "yishaih@nvidia.com" <yishaih@nvidia.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "aniketa@nvidia.com" <aniketa@nvidia.com>,
        "cjia@nvidia.com" <cjia@nvidia.com>,
        "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
        "targupta@nvidia.com" <targupta@nvidia.com>,
        "vsethi@nvidia.com" <vsethi@nvidia.com>,
        "Currid, Andy" <acurrid@nvidia.com>,
        "apopple@nvidia.com" <apopple@nvidia.com>,
        "jhubbard@nvidia.com" <jhubbard@nvidia.com>,
        "danw@nvidia.com" <danw@nvidia.com>,
        "anuaggarwal@nvidia.com" <anuaggarwal@nvidia.com>,
        "dnigam@nvidia.com" <dnigam@nvidia.com>,
        "udhoke@nvidia.com" <udhoke@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 1/1] vfio/nvgpu: Add vfio pci variant module for
 grace hopper
Message-ID: <20231011120026.GU3952@nvidia.com>
References: <20231007202254.30385-1-ankita@nvidia.com>
 <BN9PR11MB52762EE10CBBDF8AB98A53788CCDA@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20231010113357.GG3952@nvidia.com>
 <BN9PR11MB5276ECF96BAC7F59C93B5E4A8CCCA@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BN9PR11MB5276ECF96BAC7F59C93B5E4A8CCCA@BN9PR11MB5276.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RmDtmNUqpyW0gqbl+rs902liNDV4+Z5F5QhblGxgC75GQs9GXANUinVki60Z?=
 =?us-ascii?Q?w7xgaHAaGjOJ5rVnIsKWkedth4UU5vWhFoQeqHFsZc4KrEepW+kxcet7mHOd?=
 =?us-ascii?Q?iOyGOobOyI8heCR+g60hN0/fUpAYSfit/dCLA4Yc5MPNFhpmJDUp1xCsf1d6?=
 =?us-ascii?Q?TEtEhbGa8XuupHSfyhxkCiT6o3Wo8v2+cU/CIKoW0UcDoAfmRDq+YJqY34Dx?=
 =?us-ascii?Q?badUfMKWV2wQO0lDjrYi5IguNgq/6NYDx/Pv9dQsWGi+WQEvMGPSrHLemn/9?=
 =?us-ascii?Q?wd2S/oev5UzzuUVQMc/C+gReE03/dIGuR2xylKvkWOSrmhc4mHpihGcqlTfF?=
 =?us-ascii?Q?tHDcNgdlZMlwbiA3ZsfFytSWtJP2mTKdw8of+5SY9ZYH1qS9jCGSpRvwu8pi?=
 =?us-ascii?Q?8bMB4Fd7bdMnaKbUeFqYBOCK4wRbM93XcIBE8YNpyQMre0eBU6HMLd8vZ3Vm?=
 =?us-ascii?Q?nIqQN9aesyLMDupbIFzd0ZbpofjSt7CejUt9OcpNu9MulTJNzcTw4LcbAkj3?=
 =?us-ascii?Q?w6FDSPHpXRarSsCobVa3VLvnunNqrmw8BskHQwlUSHjPQvdAA8aH4JRveBx3?=
 =?us-ascii?Q?m7WfqkvXzIkB/RcRpMgZVZAJZ//Ts5hxn806eiQ0cx+LX+FwxT3MCTF/NcAV?=
 =?us-ascii?Q?vyZfd+9vG6mCj3TKQQ9zA9iJXloHHI5/r6X7AuFseSoX57v5BtT61E0xFoNH?=
 =?us-ascii?Q?opSTSw1fKYyClT8KT7UFiFrUbLUxlEIUDtus3TGipRA1NkU5e4iYQkjN3ORt?=
 =?us-ascii?Q?qMttVeHYle3slrPhXtEBS6cx+uOQAQzOwSxE4LjJft627ReyYd4yM1HidHtV?=
 =?us-ascii?Q?lk6O8USJD9w09E9yESxhEzfsBtr9jF+rdHXEl1c8yaGYvAM20N9Muxpztxrt?=
 =?us-ascii?Q?q0aORChft6K1WPLVJn5xNcdYlPg5SPkezvWY1Mn7OhTxJrp0qA3LK6iUYP2I?=
 =?us-ascii?Q?ttK+S408dSkenTdhD2brdeuvp5g0lA1JorICYM5rm+bkF7NpCF+fIHA0Vg1G?=
 =?us-ascii?Q?9418MoBWPjRvaaRNVHBTaxddfZVg8w2lNGxpU3GGN3Bs+yG0t0mmZqNtBHTs?=
 =?us-ascii?Q?sQ68O7oNGIOadWkAuTeqZlrphsVj09Qlgewd1ClyYzM/uoWcy5hlKYKC7lkI?=
 =?us-ascii?Q?n+C3wTQ0UXP3wldG6+y0fX9p1nqvlYDqc9xIpiBFTelt1WJ3wgJs6BZf62vK?=
 =?us-ascii?Q?IdFRMcdYg5Ra1j409Fg1TZwsYJrAw2b7H+h2AN1tyIF1eejWCXzwSfdV/bYo?=
 =?us-ascii?Q?vj5cO0DSmNrROVCzLlMWgcMK2zkMuGZ6ZKXlQcH5QfmH6I9QIPROsVSXgrh+?=
 =?us-ascii?Q?eBgOR4lrJoLLeytMlrhKirQsVW6Mq4AZlcyA0TlBJwGwnBx8d9CRN5dOsbt2?=
 =?us-ascii?Q?xmPMCPzNCXsu69gbR9HhmhrrgWwbABB0xMkbVnviWSELCC6J1EhJOwv713XX?=
 =?us-ascii?Q?MKbuX3XGRc0oRwfA9hsImpcvCmaM3sErXAv9vsfYmXKp+QXsk72Lv+g5c3tm?=
 =?us-ascii?Q?gxLCJNNUO+IVagqzDzicRkOADdNkZK97CZ1ZnTyRGOAStJczHWjl4K1SXIkC?=
 =?us-ascii?Q?aJcrNBvXUwVQnK8Lq0ZuM5R9XnU/M74NliFOWVBY?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f790291-4a47-486c-e5d8-08dbca51a89e
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 12:00:27.5035
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HglA+x11zVZHJjYDT6EgeoPM01UbdYyp/+U3IIgkxVy8vxSRjBivGJL8vlmE0HVB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5253
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 11 Oct 2023 05:01:00 -0700 (PDT)
X-Spam-Level: **

On Wed, Oct 11, 2023 at 02:00:30AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Tuesday, October 10, 2023 7:34 PM
> > 
> > On Tue, Oct 10, 2023 at 08:42:13AM +0000, Tian, Kevin wrote:
> > > > From: ankita@nvidia.com <ankita@nvidia.com>
> > > > Sent: Sunday, October 8, 2023 4:23 AM
> > > >
> > > > PCI BAR are aligned to the power-of-2, but the actual memory on the
> > > > device may not. A read or write access to the physical address from the
> > > > last device PFN up to the next power-of-2 aligned physical address
> > > > results in reading ~0 and dropped writes.
> > > >
> > >
> > > my question to v10 was not answered. posted again:
> > 
> > The device FW knows and tells the VM.
> > 
> 
> This driver reads the size info from ACPI and records it as
> nvdev->memlength.

Yes, the ACPI tables have a copy of the size.

> But nvdev->memlength is not exposed to the userspace. How does the virtual
> FW acquires this knowledge and then report it to the VM?

It isn't virtual FW, I said device FW. The device itself knows how it
is configured and it can report details about the the memory
space. The VM just DMA's a RPC and asks it.

Jason