Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <ba9ed927-0672-4252-9cfd-c43febf68d49@intel.com>
Date:   Wed, 11 Oct 2023 21:26:12 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [v6 PATCH 4/5] iommu: Support mm PASID 1:n with sva domains
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Nicolin Chen <nicolinc@nvidia.com>
CC:     Kevin Tian <kevin.tian@intel.com>,
        Lu Baolu <baolu.lu@linux.intel.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, Vasant Hegde <vasant.hegde@amd.com>
References: <20231011065132.102676-1-tina.zhang@intel.com>
 <20231011065132.102676-5-tina.zhang@intel.com>
 <20231011123910.GD55194@ziepe.ca>
Content-Language: en-US
From:   Tina Zhang <tina.zhang@intel.com>
In-Reply-To: <20231011123910.GD55194@ziepe.ca>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzUwQWRZZG81dXFEQzBKUG03TXREb2ZyZEF3VkFRV25hMFgyZ3YwMzFBUkhk?=
 =?utf-8?B?bG5XRWlaWEhBUHJIb0owV0QycUxpWGhQdnVwU053dGpyRnBwcHBsZDhTS3pP?=
 =?utf-8?B?cDNDK2Fkdno4T01sNm5LYkJvL2xJWnViZUFkWStoUENXZnJhcU0zamxVck1p?=
 =?utf-8?B?dVlSZHlBYnN0bE90eVZ4aXVmSXlpZjVES1laRlAyU0hlUE5lNjVPV3dIcDhE?=
 =?utf-8?B?R0loa0hUaWczM1FHK1k4SjFnYTM3Ykw1bUxnYXJWSExzb1Jta2FNTnhvNUll?=
 =?utf-8?B?b096eG41TmNybHRiRlVPaGdETVZTc3pIcVBXbkRoaUpYaUpmYjc5dFJYQ0xQ?=
 =?utf-8?B?L215dkpjR25SbDVJMXh6dTZLbDBTYzYyV2RUa0V1WTlaOTQ1Ky9oVGlEa1JD?=
 =?utf-8?B?d0tBWmlna0s2akFVcTl4UGl3VlN6TUJRaFRoQTNCMG43R3NlR05EK0I2T2dJ?=
 =?utf-8?B?M0hCVFlGK3BhSkdsNjdDR2xLWjBZbk0rRTRjTmFDSVY1TU5ISXdPaWtlWmk0?=
 =?utf-8?B?c2tTNXdmSHpUdkZpaHV4RnBjQXd6Rm5zd1JWWGFGSzFQNWMwdjBvS2pQRXVS?=
 =?utf-8?B?NlRyQk13azlaclpBNDU1Ym9iWkdFdkJPK0pJbkdpZmZBMGJyaTloZk8yK3B6?=
 =?utf-8?B?MmRZYlE4Mk0yaXlWVnJHNjFqbC9nOEtRQlR6UXo1dTVuRlFOVW5sSVl1NFIy?=
 =?utf-8?B?cTQwNUlwK3BqYlBSU202R0ZWWk5zNWczYjRhcDdWeHIvOHowak9IaVBLekl2?=
 =?utf-8?B?bklCUkJYeHFVa25HNVVMTld3S21waFVrRnozeU5XakVLYXZGTHRFa0ZnOVZv?=
 =?utf-8?B?SWRCSUd5WkwzOXB3Y0tHY2NFcklXdWlhdEhMSkpkbW95U3IwOVNTblJvL2pC?=
 =?utf-8?B?cC9Od0FSeitPSU9TQ2xtLzFuUFkzclY2elR1cU1NNHBzRUJSYlhoUlFKOTRj?=
 =?utf-8?B?d1ZidzdWZkdnZjBYYlAzSnNqVmZ3a1JrUmErZWc5dTIyV2N2YTVXYjRsbEpU?=
 =?utf-8?B?a1hpK3JjemU4cnFudlVHeXRCeXQ5Y3YxZGM1VStSc3ZYSzdCaWt2UzU4TzV0?=
 =?utf-8?B?WkVkTzQ5dmt2alIrMU1qUU1JS21uQVJjd3JsUXFKb0RCWS9rUnFtbWJyRWlt?=
 =?utf-8?B?Z0JrZHhuRCtPdGlBTXZreEdYWjk4Z0xacC9TdzZYUTcwVVJaK0s1UTVUVG1F?=
 =?utf-8?B?K0t4VXZ5bmxGZ244SUlITi9iVDd6M0JmYWFoVTFOZUNOdWFySkFoN0FudWtj?=
 =?utf-8?B?ZVZNWi9ydUZSTTF4ckVWVmt6QzlQZUJwWDNab2VpWFdPdHUxeUFKdHdWV2N2?=
 =?utf-8?B?dnJRUXh2UnBjelk2V0tXcEVJVkZURnBna1o2TXhxcWpqSTJGbW1XanRkYzVC?=
 =?utf-8?B?N0ZXU3pmSFQzN3lmU3JYZkRvOGc0UzcrcmNUZ1hZbnNSYXR2alFEdzBLbjNt?=
 =?utf-8?B?MS9iYVpXNHI4MVd3Qkx2OTIvRGpMZDZRTStFYW05aXBjNVJVUzBJQlF0UDBC?=
 =?utf-8?B?dDdZbDd5WjA3Y0gvNURqQjBWOEI2Tjh6eEZ1NXJqdWNNWUp0QVJja2kxUnpM?=
 =?utf-8?B?bHRRM2o0RWV1U282WnNzZ2pZRkhCMG9jWmp1SEJvL3dDY1NzUm1EYTdmNEFs?=
 =?utf-8?B?a2tOZnFqbWw2YVdDWlhjOWE1QnVDY3hhNVdxeUNJdFpzaHZtTkVrYjlEaUQ0?=
 =?utf-8?B?dTJVOXJCYTQxV2JaT3dRRFBRVzBuM1V2QUFaRmcyZkh3MlZma29GKzZMQmZo?=
 =?utf-8?B?SjcwRWhiWmttblVmRUNaMkYwT1FMbDBPVHhEQjU5RmxnZUJpendaRHZISWpS?=
 =?utf-8?B?UWNLcm4xNlNINVhSdnVDKzlzMHFBN2gwa1VKK25WOHA3eExwYjA0T1grSWVz?=
 =?utf-8?B?eFRPTFdMWlFqUEN0WGlmcUVERkZubU42OTdPSkY0a05MQ0ZrRjgxejdhZGFT?=
 =?utf-8?B?ZmhtdzM3MHN1SFJBRDJiY0pYRWU3akFSVkZVS0JGYlQzYnVkQXk0U3FOTnA4?=
 =?utf-8?B?Ym9FWTZRdWtCdk1MMW84SXh3ZDhzNzlKL3dTdmFtQkxabEtuNHZ3OVZnaWdR?=
 =?utf-8?B?RzFUdW9VWVU3N0xIa1g4bFU5NjBxamhZM2tyQlBkeStUbHZydlhYVjUzSTlD?=
 =?utf-8?Q?aw6a8gcs1aFFkI16ClEvX2c3t?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3116fd58-05fc-4f8d-d74f-08dbca5da72c
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5881.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 13:26:19.1827
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uVDlH/ZY75prhYci5E6fHBy8a/YRNgaK8GZQbTHwD3lNO+WJhu3oCkbMlr6kWDVn1FLEeWkCvdG+F+uXMjh7Tw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8568
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 11 Oct 2023 06:26:38 -0700 (PDT)
X-Spam-Level: **


On 10/11/23 20:39, Jason Gunthorpe wrote:
> On Wed, Oct 11, 2023 at 02:51:31PM +0800, Tina Zhang wrote:
> 
>> diff --git a/kernel/fork.c b/kernel/fork.c
>> index 3b6d20dfb9a8..985403a7a747 100644
>> --- a/kernel/fork.c
>> +++ b/kernel/fork.c
>> @@ -1277,7 +1277,6 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p,
>>   	mm_init_cpumask(mm);
>>   	mm_init_aio(mm);
>>   	mm_init_owner(mm, p);
>> -	mm_pasid_init(mm);
>>   	RCU_INIT_POINTER(mm->exe_file, NULL);
>>   	mmu_notifier_subscriptions_init(mm);
>>   	init_tlb_flush_pending(mm);
> 
> Nicolin debugged his crash report last night and sent me the details.
> 
> This hunk is the cause of the bug that Nicolin reported.
> 
> The dup_mm() flow does:
> 
> static struct mm_struct *dup_mm(struct task_struct *tsk,
> 				struct mm_struct *oldmm)
> {
> 	struct mm_struct *mm;
> 	int err;
> 
> 	mm = allocate_mm();
> 	if (!mm)
> 		goto fail_nomem;
> 
> 	memcpy(mm, oldmm, sizeof(*mm));
> 
> 	if (!mm_init(mm, tsk, mm->user_ns))
> 		goto fail_nomem;
> 
> It is essential that mm_pasid_init() zero the new pointer otherwise,
> due to the memcpy, after a fork two mm structs will point to the same
> thing and one will UAF/doube free.
Good catch.

Thanks,
-Tina
> 
> Keep mm_pasid_init() and add zeroing the new pointer to it.
> 
> Jason