Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp826005rdg; Wed, 11 Oct 2023 06:41:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPXSW9+pkgY7I/Ps0Wx3MXMFKrT1RS1rpolxOLBRjbDjn7vx7MJjubJwujCoRaUBZE4pVC X-Received: by 2002:a17:902:d352:b0:1c8:77f2:7d20 with SMTP id l18-20020a170902d35200b001c877f27d20mr16728830plk.31.1697031714460; Wed, 11 Oct 2023 06:41:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697031714; cv=none; d=google.com; s=arc-20160816; b=q5FEUWYTXlurOM6jrp/CPewbCG4w9IK/uKV8i/cdjxfF36HLI3ILQb8neNI337SZjT fgz0lFpJI4wNvQXo3YgByigZbObJUsrww3zI5j7Q9HmB2YOFwa3W6R7t4WX8yKZKLss9 pni4E0lhUPRgUBsPB7Paa0eMu7rggNxptTX/UzuJ6druXve5ChQYBmNfwYvHLkbrSdGx bmfxHkzq6/yToO7TLH/o8fLORQ/rKmFBrO6WJb4CqpkuCOGfSyXtlAi5OSZGX/pCld9L ewqOxm6XEli0cZ4NW15J0daEQzSyJ3wktIbA+1MqFOFUdYKmlw/H9ryGDxj2dhB52+T9 sg2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=e9eHmE/+dwSS8bqz77cK345UNgnDF9v+Kl26GxUyGE4=; fh=DBT8NPwfAfhCnHb2EqNy23DjBwNBb9pJ7s6v2K56kGA=; b=DWN0/Pg57kJjE23MIqCOpYXtE5ZqNY7SWmnGv02Idt0qA4geh4BGJQR64ufm1Fjp3l zhqqYFet5mBBQ6zN+0ECCxEeW7qP1yEVvHN0xQT68McXxevV4L39w7xKdXpUulLJArm+ lSkuwJ+AmFwULWDAn3n0p1DSQLsPFRGYBY9QxBcWZKtHtvz/C4dpXUydhgoZadJGpYPb tdG1MZsIgUo51GdQ8idinG4v9z2KyyIKAqriaOuWBmQZGRbrtfTec5DhuJcBYMt6vk6O sZJSzrYfMzObfXBsCgICAiy4rqOt05cFBktueG7PNZz35sKTR3DooGtJEV9l9OoznYDm APDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id z6-20020a1709027e8600b001c9bc844534si2596199pla.430.2023.10.11.06.41.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 06:41:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 5EB2780930F9; Wed, 11 Oct 2023 06:41:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232402AbjJKNlm (ORCPT + 99 others); Wed, 11 Oct 2023 09:41:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232091AbjJKNlj (ORCPT ); Wed, 11 Oct 2023 09:41:39 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4055090; Wed, 11 Oct 2023 06:41:38 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8121EC15; Wed, 11 Oct 2023 06:42:18 -0700 (PDT) Received: from bogus (unknown [10.57.93.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C229D3F5A1; Wed, 11 Oct 2023 06:41:35 -0700 (PDT) Date: Wed, 11 Oct 2023 14:40:03 +0100 From: Sudeep Holla To: Ranjani Vaidyanathan Cc: Cristian Marussi , "Peng Fan (OSS)" , Sudeep Holla , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "souvik.chakravarty@arm.com" , Glen G Wienecke , Peng Fan Subject: Re: [EXT] Re: [RFC] firmware: arm_scmi: clock: add fixed clock attribute support Message-ID: <20231011134003.lhb5yiicgr5cbzr2@bogus> References: <20231010022911.4106863-1-peng.fan@oss.nxp.com> <20231010091223.rvcyrgbjcrmjzmvp@bogus> <20231010093509.ddy75og4jd72n6cq@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 11 Oct 2023 06:41:51 -0700 (PDT) X-Spam-Level: ** On Wed, Oct 11, 2023 at 03:54:59AM +0000, Ranjani Vaidyanathan wrote: > From what I see SCMI clock protocol could benefit from an attribute for the > clock that describes what operations are possible on a clock. There are many > bus clocks that only the SCMI server manages and the error code DENIED > should be handled gracefully by the agent. > Agreed, but we need to understand if we need it per operation basis or at the higher granularity such as any write or set operations not allowed. Just my initial thoughts, we can discuss. > In the case of Linux, perhaps this should be handled by the SCMI clock > driver, instead of allowing the error to propagate up the Linux clock > framework? Yes but even for that we need information from the firmware. > It seems strange that the SCMI server should swallow the error (silently > fail) only for certain agents. I am bit confused by this statement. The SCMI server/platform must not ignore or fail silently. Since the agent is not allowed, if it attempts it must return the apt error. While Linux may choose to ignore the error but I think this is what we are discussing to figure out what is the best way to avoid it or worst case handle it gracefully. With any extra info from the firmware, the former option must be possible and we need not think of the latter option IMO. > I would think this would make debug quite difficult and having a "DENIED" > error code not very useful. > Agreed especially if it can and is expected to continue functioning as normal. -- Regards, Sudeep