Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp839064rdg; Wed, 11 Oct 2023 07:03:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGeA1Q1meqCc4TWKh2B2+GUuHsmaAwlW/bllozJetz/npC4vLwH4KiDgxfNTTKuIEcG22U2 X-Received: by 2002:a17:902:934a:b0:1c6:636:e40a with SMTP id g10-20020a170902934a00b001c60636e40amr18789271plp.14.1697033002190; Wed, 11 Oct 2023 07:03:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697033002; cv=none; d=google.com; s=arc-20160816; b=toROcuf6eMsQfPkRIiwtw8Q7w+v/w6+gb6r6vS9unwHdUuybzalhAkZ03IiTNW78RB WDOiB9P5+4dSF0ZHe/V1fIzL5bKBwUCuOZh+ienQrBixOTHZ9NXEthLb8NEGFXJzQ3b8 ZD/MM5YHAj7JwSfaNozMOrA3wZNcoCKGs/VBAtwzqm6kNwLrIM6hKwvXabpdY+m9mlZo TnNtMKw5gKx0o1TA1FnJhhE0Kib3cK7R8CHwhKN0YBs9LjlMcDgoWFemK8R5Dq2GW1t2 MnufCwz4w3sVmxuSb/Qon8VeO22L4jjNCFXBhLpnHQYSKnLHf1Kvn6k/t+n7Id+08QfN YEbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aiXhVd+Skl1SDeXwfVwa1udc6/4a93csC6iL1H/Zlc4=; fh=3hZmsfyLFayC+OxVDRVcXAhF0jfEeN6hMeU54agNFD4=; b=gaAVCWyq6WmKLX87R3Gm7OWNacXWaxTO3joZk1ySEFaLqWviw7wI5KRaFiErSLtiap KrhxGpg+ocWJyIa3mMUYEcV2rhPNkllObboJjEFY8yzTYRnywRHKeu+I9HXcdTG9e1hf Q0C/1csZb55ZObFS/xz55VeUSPvpZLWJ7SUy4K8gHKZIcKqS2DNCqeMorqOpZVmAhkAm ALw7eY1RdrhFG+xU6zH3aiGViXuesYm4QTn/fNN6+ub3/0LetlJDUkVZ1MssFhosmC/U Vl03ab4yzYiyJAPKC8m4YqSeZYXpbmOK07+ihlhnUiXdNV3bUSTuxUyHr14CyBaFGGZU 6J/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OWVOdK03; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id p18-20020a170902e75200b001c5fca2e1besi4172408plf.15.2023.10.11.07.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 07:03:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OWVOdK03; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8D1EF81B75E4; Wed, 11 Oct 2023 07:03:11 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346971AbjJKODG (ORCPT + 99 others); Wed, 11 Oct 2023 10:03:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235010AbjJKOC7 (ORCPT ); Wed, 11 Oct 2023 10:02:59 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B882FB8; Wed, 11 Oct 2023 07:02:58 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57007C433CD; Wed, 11 Oct 2023 14:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697032978; bh=5o5h5CgRG4H4Z5qjk2eknSticE7hPec++pW0EBNapec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OWVOdK03/KwWJmBcC+LI8aDOa3bDpFqUIrBwFqpe3tZwQOVJvD85Tb918ZCwLvjcA p/PH9RLQoG3abHY/EYhuW9aidUAbgTHvt6tog9Uy4YkANKUd5IPWNe1UR8qUurGJqh HsDWm/uH4U3VLAlOQBnhd5o3rrbPx5xi6r14OdqH0wGjXlcmiIHMNWZg1oBLCPk2/E GQZFYEobq+8Wg/9NDW0IQShbNuJGpaNJEc165SF06oH1XzBMmxoWKeQzrJnTHN2Wn4 yRKDcjwL1+lJkuL7r8x3q4mg4FnQRjKCK+GdP/uAvpflLOFGQG7DLaBmusEtZbGWLb w6MmltWuXESBQ== From: Arnd Bergmann To: Jakub Kicinski Cc: netdev@vger.kernel.org, Greg Kroah-Hartman , linux-wireless@vger.kernel.org, Johannes Berg , linux-wpan@vger.kernel.org, Michael Hennerich , Paolo Abeni , Eric Dumazet , "David S . Miller" , Rodolfo Zitellini , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [PATCH v2 03/10] ethernet: sp7021: fix ioctl callback pointer Date: Wed, 11 Oct 2023 16:02:18 +0200 Message-Id: <20231011140225.253106-3-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231011140225.253106-1-arnd@kernel.org> References: <20231011140225.253106-1-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 11 Oct 2023 07:03:11 -0700 (PDT) From: Arnd Bergmann The old .ndo_do_ioctl() callback is never called any more, instead the driver should set .ndo_eth_ioctl() for the phy operations. Fixes: fd3040b9394c5 ("net: ethernet: Add driver for Sunplus SP7021") Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/sunplus/spl2sw_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c index 391a1bc7f4463..bb4514f4e8157 100644 --- a/drivers/net/ethernet/sunplus/spl2sw_driver.c +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c @@ -199,7 +199,7 @@ static const struct net_device_ops netdev_ops = { .ndo_start_xmit = spl2sw_ethernet_start_xmit, .ndo_set_rx_mode = spl2sw_ethernet_set_rx_mode, .ndo_set_mac_address = spl2sw_ethernet_set_mac_address, - .ndo_do_ioctl = phy_do_ioctl, + .ndo_eth_ioctl = phy_do_ioctl, .ndo_tx_timeout = spl2sw_ethernet_tx_timeout, }; -- 2.39.2