Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp839344rdg; Wed, 11 Oct 2023 07:03:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpTO2lmGIcY3twBucjnMu1dapp9YjtnP8qVTVB4XZI4n+zF8rygqd6omIHg3jJnP/EX0US X-Received: by 2002:a05:6a21:9986:b0:160:cf09:8019 with SMTP id ve6-20020a056a21998600b00160cf098019mr21271148pzb.32.1697033021255; Wed, 11 Oct 2023 07:03:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697033021; cv=none; d=google.com; s=arc-20160816; b=qEWU5x+TZ9+K14vc804hlAPzLd+WWHebEiF/qlfIWyOZVrm9nugbyiRj6qY4IGBzhL Np3ZnEySXEMECAPQqSGjPpxGzrxxtWLLK2OcpQunEdKlTZ3Z4Rf1WzYD2qf8QfnkQutq QPyVK2rW0nyIuaxNyhBWX7j97f7hR4Ttf/ejWziOAmwMpc+b4BfJRr4r4JB3yiAdpEaE n+MfMK//+Z/aRublHNmsw262pTQjKI704ZpSLOWJQQl0MwjPy1yN7G0rBV44qF3s69+c QElOEOwf1wWTqFn7bIGeAR4vaHDgQlnhZfO6l07DItzwrACuOU7KVd4UmEWkFsWrTXru G0fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=H8qoJOcDM0nzq59Y7QqSGudc97yZf6FxMA+BNxncf6c=; fh=3hZmsfyLFayC+OxVDRVcXAhF0jfEeN6hMeU54agNFD4=; b=zMYU9GxwhIS/5UygTcyQmyA7Ob1lD0o7a58pUOtcvT2QQ6PxmwIFd9Qq/UG0Lh0bGv pbiJvTJhxuB7zmx0hVLJNywqME9PuwmM8KDv+SCL22httcGH0CaV0rUGFzACxi/yPahv VwGgzj9NCXCAO/0n0pF3TcIj4iuTjp3QdTR0YH0Nhx+n+Pru9S3/PwDC6CFPQZEyjeq+ fFPyEWLzPnzfBmAk/F3T7AUMzisHPLuzsjInp54a2nsR3JsYgOFr8DbI73tPpQFh1iA/ sdXuecKZntqoVrdHP7CoMiJbvQzQE2wQkvUmz7VdZMnHF04h32tviPhFsXLPNVdf0wZM pLlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ioYLjO1H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id j184-20020a638bc1000000b00578f7063ae7si15634645pge.682.2023.10.11.07.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 07:03:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ioYLjO1H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id C8676801B9F9; Wed, 11 Oct 2023 07:03:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346971AbjJKODN (ORCPT + 99 others); Wed, 11 Oct 2023 10:03:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346849AbjJKODJ (ORCPT ); Wed, 11 Oct 2023 10:03:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B867D8; Wed, 11 Oct 2023 07:03:02 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D42B9C433C8; Wed, 11 Oct 2023 14:02:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697032981; bh=v2U61JipGRAw5yHfVClf2xeZ1vepHEnTwO9csgoF7y8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ioYLjO1HqpBapuo1S1iyxyyf0UcnmM6CGIlqx/8vb42Do3W/g40+2Uz6P9jaONP2W n8LYIQVU185JW1CaKn5XFRz43CM6jAi9odXt1R1fV9Q7sMtyL5g/WfZ8cIkO+MlUT1 2BjnN+t2hWuuQCq+YScg6YL68GQ0CpyOXslq12lyp0MV90gVKkfblNZM5tJl+SvXV1 7/Sx6ECMSLnfm1EnCySyzR6YwocgBIEK7SxlLgctU3m13uAte80LR3/Sxcf2TS6aFi h048r5MOVltjxnCJ7qTRzXwxyUpU0+AXNgXK7PoUyPSm5ppbgc5KMztdeuKfIAk9Y3 Z9G6PQDpzlx+Q== From: Arnd Bergmann To: Jakub Kicinski Cc: netdev@vger.kernel.org, Greg Kroah-Hartman , linux-wireless@vger.kernel.org, Johannes Berg , linux-wpan@vger.kernel.org, Michael Hennerich , Paolo Abeni , Eric Dumazet , "David S . Miller" , Rodolfo Zitellini , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [PATCH v2 04/10] staging: ks7010: remove unused ioctl handler Date: Wed, 11 Oct 2023 16:02:19 +0200 Message-Id: <20231011140225.253106-4-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231011140225.253106-1-arnd@kernel.org> References: <20231011140225.253106-1-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 11 Oct 2023 07:03:21 -0700 (PDT) From: Arnd Bergmann The ndo_do_ioctl function has no actual callers, and doesn't do much here, so just remove it entirely as preparation for removing the callback pointer from net_device_ops. Reviewed-by: Greg Kroah-Hartman Signed-off-by: Arnd Bergmann --- drivers/staging/ks7010/ks_wlan_net.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index 0fb97a79ad0b3..ab7463bb25169 100644 --- a/drivers/staging/ks7010/ks_wlan_net.c +++ b/drivers/staging/ks7010/ks_wlan_net.c @@ -51,8 +51,6 @@ static int ks_wlan_close(struct net_device *dev); static void ks_wlan_set_rx_mode(struct net_device *dev); static struct net_device_stats *ks_wlan_get_stats(struct net_device *dev); static int ks_wlan_set_mac_address(struct net_device *dev, void *addr); -static int ks_wlan_netdev_ioctl(struct net_device *dev, struct ifreq *rq, - int cmd); static atomic_t update_phyinfo; static struct timer_list update_phyinfo_timer; @@ -2458,24 +2456,6 @@ static const struct iw_handler_def ks_wlan_handler_def = { .get_wireless_stats = ks_get_wireless_stats, }; -static int ks_wlan_netdev_ioctl(struct net_device *dev, struct ifreq *rq, - int cmd) -{ - int ret; - struct iwreq *wrq = (struct iwreq *)rq; - - switch (cmd) { - case SIOCIWFIRSTPRIV + 20: /* KS_WLAN_SET_STOP_REQ */ - ret = ks_wlan_set_stop_request(dev, NULL, &wrq->u, NULL); - break; - // All other calls are currently unsupported - default: - ret = -EOPNOTSUPP; - } - - return ret; -} - static struct net_device_stats *ks_wlan_get_stats(struct net_device *dev) { @@ -2608,7 +2588,6 @@ static const struct net_device_ops ks_wlan_netdev_ops = { .ndo_start_xmit = ks_wlan_start_xmit, .ndo_open = ks_wlan_open, .ndo_stop = ks_wlan_close, - .ndo_do_ioctl = ks_wlan_netdev_ioctl, .ndo_set_mac_address = ks_wlan_set_mac_address, .ndo_get_stats = ks_wlan_get_stats, .ndo_tx_timeout = ks_wlan_tx_timeout, -- 2.39.2