Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp841708rdg; Wed, 11 Oct 2023 07:06:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhDp9PpjVD9FdRh7TCXuxE6WyTKZvXxlqFF07lqQIFtkMT7ZK6imajcYSclFZXo63CJnL2 X-Received: by 2002:a17:90a:a085:b0:276:e14a:4991 with SMTP id r5-20020a17090aa08500b00276e14a4991mr18118961pjp.2.1697033185901; Wed, 11 Oct 2023 07:06:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697033185; cv=none; d=google.com; s=arc-20160816; b=a5crQRtNxfvsia29hrTPvLBCt/DD0iFTEB6y5gTqmRFUll1lt29Vnjv/Vg/Ifs///B x1MDu//znwU+542pgj67QaRmbngdoshjvxODJjWsT3zXOxuVKJGC3DUsQdQ+mlNPIOGh WRZb6Ka+5JOspr5rAZVO5c1yIjh73EmS7+h/0XOhw0puSZt5fhF/sxx9DPDFaf4mNh7v a46zsJHWD1Eunx+25PUvju2JLN/6f2kHv/sin2D/Y9ODr6pSlpKq+kH22DSVNncwHCcK zApRhqqTK6OBhU8mrofI75o54OXBlH6bXIA1Xf3j2SYIvvsp56QqEyLrm3rb5DCgYSGJ Ghqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=MqP27hLs84B1d5SWU+1RVfvQUaw2zlqyPIX0397Jqkc=; fh=RouUbNnnoq81GX5kLEAdXKWJ9FrZ5zBvaA7ab3S/7zs=; b=D50yUWX8vLra63YSKgtYj8Emyzc2jkyc7+e6eFYl482XFQNuqERnUV7ewIn5XbaSWD Y5eRYXtDwX1zuaafTIlq0a3RU7cNx+vkaJOSIbv6zqKr+sLMg4EKMFeMY6ejlPYSpi7z /kNf7s+DKhcm+GwltHW7pATn6PoBwnqRsSlHQUFPGsKDhkj+eYiWLmQ8vZ73jUSvjTTw ybQZVO6TYgnaFY5S3/IY6NE4IIuG/++oDk5I2uWkFL0vMiUxIobs2x5TCbZ4Ir4QC/++ 6Ssd/E4bGseP2b8DSfWwYhVk6PgAsrmP7g+LZBhB1MySUjEYP476kydCJCPz68uF1DQ8 k+oQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=FphjZ5yJ; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=ouY87AmW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id l5-20020a170903120500b001bf0b29d935si4606320plh.34.2023.10.11.07.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 07:06:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=FphjZ5yJ; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=ouY87AmW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id E10088031129; Wed, 11 Oct 2023 07:06:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234938AbjJKOGR (ORCPT + 99 others); Wed, 11 Oct 2023 10:06:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232357AbjJKOGP (ORCPT ); Wed, 11 Oct 2023 10:06:15 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 385DBA7; Wed, 11 Oct 2023 07:06:11 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 780935C0418; Wed, 11 Oct 2023 10:06:10 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 11 Oct 2023 10:06:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1697033170; x=1697119570; bh=Mq P27hLs84B1d5SWU+1RVfvQUaw2zlqyPIX0397Jqkc=; b=FphjZ5yJDqwRLHEKOD 6+MstyCCd7J7CAVK/r5DkCLgzPjjHRRGBZzyQok9a3wZbpFEoE6n2ZRCC48UsnsP 2uphIUPeX5ZfrIr0RZRpROszIcqKFk/fP1FQfScda/6722MsfvTK5IWcWccAfdec 2ZWIpCRL/AGDve6LpdQIPZ0F+HW1mwss1Pn7IpPUHEy9g84nmbfoSWk0UswfcmOW oosGeMr6R7t6MpffxcxnylzE/Ia/ZFIR4aUlfn8bIXoa4KSspYkuxv4MUvZiUkWy Ex28EkTECM7tscSXGGK+eEzg/PPu2/aptZdc6loFMR2MLQPfJR5/SKQlqjfzXeZ7 OuWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1697033170; x=1697119570; bh=MqP27hLs84B1d 5SWU+1RVfvQUaw2zlqyPIX0397Jqkc=; b=ouY87AmWoncBViJ0tHfeXCMQOavQe d66cZxGBH0wrpt4l7EeEakaPu1WvmOwKYaekPvr04gBj6o8Q76MjnrkmmFj6t4Nd z6fqGfnPF+D7M1qKwlSD0QiXJw/yZ2hPH0an0yVinbaHAomma9ufH8Upltuf6Mei 820kb7MP2ro6wn4xdzj96RuP3PZCCwx2LrL1XEXqpT6HlENdwwgS1TkPJ0QVHYsl x3cRFaNQB2D8MbDsZBlJJ3vLdppbe/VTm/dsHiC38gErcr88U2TJg2GoZ7N8JBEK GF/T4/pq3MPczeoVuI4N5fDdqNbqMQPQ6ldK4sf+yYwwHrbbp/DzJSYfQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrheekgdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E3F84B6008D; Wed, 11 Oct 2023 10:06:07 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1019-ged83ad8595-fm-20231002.001-ged83ad85 MIME-Version: 1.0 Message-Id: In-Reply-To: <20231011135905.hveat7viflqluccw@bogus> References: <20231011131431.2559029-1-arnd@kernel.org> <20231011135905.hveat7viflqluccw@bogus> Date: Wed, 11 Oct 2023 16:05:47 +0200 From: "Arnd Bergmann" To: "Sudeep Holla" , "Arnd Bergmann" Cc: "Rob Herring" , "Frank Rowand" , "Greg Kroah-Hartman" , "Yang Yang" , "Geert Uytterhoeven" , "Sebastian Reichel" , "Miquel Raynal" , "Dmitry Baryshkov" , "Viresh Kumar" , "Benjamin Herrenschmidt" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of: rexport of_find_next_cache_node() Content-Type: text/plain X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 11 Oct 2023 07:06:23 -0700 (PDT) X-Spam-Level: ** On Wed, Oct 11, 2023, at 15:59, Sudeep Holla wrote: > On Wed, Oct 11, 2023 at 03:14:08PM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> This function is now called from a cpufreq driver, but that breaks the >> build when the caller is in a loadable module, because of a missing >> export: >> >> ERROR: modpost: "of_find_next_cache_node" [drivers/cpufreq/qcom-cpufreq-nvmem.ko] undefined! >> >> Export this as a GPL-only symbol, like the other related functions in >> this file. >> >> Fixes: 7683a63c08ff5 ("cpufreq: qcom-nvmem: create L2 cache device") >> Fixes: a3e31b4588443 ("of: Move definition of of_find_next_cache_node into common code.") > > I am bit confused as I see commit a3e31b4588443 didn't drop the export. > So how is this change fixing that commit ? My mistake, I was looking for the commit that initially introduced the function, but didn't notice that this just moved it from powerpc. I could have used "Fixes: e523f723d69cd ("powerpc: Add of_find_next_cache_node()")", but it's probably best to just leave that line out entirely. Arnd