Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp850075rdg; Wed, 11 Oct 2023 07:17:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6xVAna1ozi3rqiRI7zUhhuVc1Ps2t/sW+zcUDl3h3vicpvyzXC/DYRUQPytQDoWcYhFoh X-Received: by 2002:a17:90b:3802:b0:274:a241:a7a8 with SMTP id mq2-20020a17090b380200b00274a241a7a8mr28354219pjb.0.1697033859978; Wed, 11 Oct 2023 07:17:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697033859; cv=none; d=google.com; s=arc-20160816; b=0Kky8tjKBm7kXphLHzuj6zJGAHqHY417V3ICmmM7F9PVhUjyEKGn/RRW9Xg7rl6C+k 8iEBg3X+s4H6QkOUbwOpQiPVkOnVvNymhSsmLmZnayD6u5SeQASLkYRbL/SEDVJTCpZj fnkZpfi6JMq5tDSKYJSEe9ZwhQ3L7TpyEVxppvlXeW5I/Xx3ECtOsWFPjwIqN69puSww 26eovHkB2iJSOY9ShhjBNXwmAZ44bxuIok/HB9KFLqLAEOkSCk5aeL+Pb7BKlmN/fUnK plDoh/vw2K+ibcDvmvVIkGUKgKAiqgdxyuUUC1kjwxYerxgTcJIGiZqZT6StLFCzXlCl eKGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=svngh7gavoOsAoTd14KvI+aVm1JHod9n5Mvh72UXNZY=; fh=Fko32OqwGgI5WpcqYpp5KigXgtelsKMiigtnZERCGL8=; b=PTSzan4pHX1DgPduggXyAX54//gl+fpKE39kPPzrUlc+0aV7SxaUrOH1kSgbCHKyTN YfpzHrfJqp4fZBjvZCTe5k8I3348kEStEsbCc36xY/Uiha1illcHLrSqaeSmquxRqRFm 6gmB+kXwUMasHdywhTh3BGJnK8JGdNJLB8OSysxuQnWRiHJhE1BfhVqoDYm5HO9fhkBC 9PO0xc/lSq+9opGpQvVRZGJG5wm+cLlztbJgNFAA+MIYeHIeYKeLLT2e4egt8+MFerhD 9jfmki4vHezq3fDZQRdMV3bMqxy6e4XgEDb7lokBcmG3mb8KFs2YMa5ZEcopM6t4qBJu wMUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=K+0KsVZ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id pf3-20020a17090b1d8300b002774985e8b7si4212368pjb.168.2023.10.11.07.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 07:17:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=K+0KsVZ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 111A8802924E; Wed, 11 Oct 2023 07:17:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346917AbjJKORc (ORCPT + 99 others); Wed, 11 Oct 2023 10:17:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346957AbjJKOR0 (ORCPT ); Wed, 11 Oct 2023 10:17:26 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C011CA7; Wed, 11 Oct 2023 07:17:24 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 1394760011; Wed, 11 Oct 2023 14:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1697033843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=svngh7gavoOsAoTd14KvI+aVm1JHod9n5Mvh72UXNZY=; b=K+0KsVZ3BA/vLUJOTXyrJHGjkf1S7uVlIMYETl+hN76MKKXIj56hJ4b86OYyMy0qpdpslE PDE85LtXseROAHen6+fxvcJv9zDcK4IgJE/jMt/63TqSVevtnu1+XHsZPNuEj+iep2eeHR fMcMQxZ3oRLkyEglQYXz2bHO3ei6uNowDnCrRovkko6gVFudnqXVAcOKenVbgJGa+zbLUr ChDJUwQGsReMCIHcz9g8o8AwU1vKPUAI1c86M2RW6yYCEvS02XoZLsniEEE9XnWwJviG0r tU/KiFu8ooSeCcgJohdRQIexK1ZwDHjeGCZts5o/cn1ERZ7vEQ3TXGpLw+R2rQ== From: Kory Maincent Date: Wed, 11 Oct 2023 16:17:00 +0200 Subject: [PATCH v4 4/6] dmaengine: dw-edma: Add HDMA remote interrupt configuration MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231011-b4-feature_hdma_mainline-v4-4-43d417b93138@bootlin.com> References: <20231011-b4-feature_hdma_mainline-v4-0-43d417b93138@bootlin.com> In-Reply-To: <20231011-b4-feature_hdma_mainline-v4-0-43d417b93138@bootlin.com> To: Manivannan Sadhasivam , Gustavo Pimentel , Serge Semin , Vinod Koul , Cai Huoqing Cc: Thomas Petazzoni , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Herve Codina , Kory Maincent , Manivannan Sadhasivam X-Mailer: b4 0.12.3 X-GND-Sasl: kory.maincent@bootlin.com X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 11 Oct 2023 07:17:39 -0700 (PDT) Only the local interruption was configured, remote interrupt was left behind. This patch fix it by setting stop and abort remote interrupts when the DW_EDMA_CHIP_LOCAL flag is not set. Fixes: e74c39573d35 ("dmaengine: dw-edma: Add support for native HDMA") Signed-off-by: Kory Maincent Reviewed-by: Serge Semin Acked-by: Manivannan Sadhasivam --- drivers/dma/dw-edma/dw-hdma-v0-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/dw-edma/dw-hdma-v0-core.c b/drivers/dma/dw-edma/dw-hdma-v0-core.c index 108f9127aaaa..04b0bcb6ded9 100644 --- a/drivers/dma/dw-edma/dw-hdma-v0-core.c +++ b/drivers/dma/dw-edma/dw-hdma-v0-core.c @@ -237,6 +237,8 @@ static void dw_hdma_v0_core_start(struct dw_edma_chunk *chunk, bool first) tmp = GET_CH_32(dw, chan->dir, chan->id, int_setup) | HDMA_V0_STOP_INT_MASK | HDMA_V0_ABORT_INT_MASK | HDMA_V0_LOCAL_STOP_INT_EN | HDMA_V0_LOCAL_ABORT_INT_EN; + if (!(dw->chip->flags & DW_EDMA_CHIP_LOCAL)) + tmp |= HDMA_V0_REMOTE_STOP_INT_EN | HDMA_V0_REMOTE_ABORT_INT_EN; SET_CH_32(dw, chan->dir, chan->id, int_setup, tmp); /* Channel control */ SET_CH_32(dw, chan->dir, chan->id, control1, HDMA_V0_LINKLIST_EN); -- 2.25.1