Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <dc63d7ca-aa62-1f51-1e1f-8569fdf841fc@linux.ibm.com>
Date:   Wed, 11 Oct 2023 08:36:20 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v3 1/2] fsi: sbefifo: Bump up user write cmd length
To:     Ninad Palsule <ninad@linux.ibm.com>, jk@ozlabs.org, joel@jms.id.au,
        alistair@popple.id.au, linux-fsi@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
References: <20231010204348.2600242-1-ninad@linux.ibm.com>
 <20231010204348.2600242-2-ninad@linux.ibm.com>
Content-Language: en-US
From:   Eddie James <eajames@linux.ibm.com>
In-Reply-To: <20231010204348.2600242-2-ninad@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/10/23 15:43, Ninad Palsule wrote:
> This commit increases user write limit for command length from 1MB to
> 4MB. This is required to support images larger than 1MB.
>
> As per 'commit 15e2a7218c27 ("fsi: sbefifo: Bump max command length")'
> the alternate solution is to break image into 1MB pieces by cronous
> server that means kernel driver needs to provide way to send end of
> message command once all pieces are transferred. This requires
> restructuring of both kernel driver and cronus server (application).
> Hence this commit chose to bump up cmd length to reduce code impact.
>
> Testing:
>    Loaded 3 MB image through cronus server.


Reviewed-by: Eddie James <eajames@linux.ibm.com>


>
> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
> ---
> v2:
>    - Add the cmd length check back and changed it to 4MB
> ---
>   drivers/fsi/fsi-sbefifo.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index 9912b7a6a4b9a..a95b32461f8f3 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -113,7 +113,7 @@ enum sbe_state
>   #define SBEFIFO_TIMEOUT_IN_RSP		1000
>   
>   /* Other constants */
> -#define SBEFIFO_MAX_USER_CMD_LEN	(0x100000 + PAGE_SIZE)
> +#define SBEFIFO_MAX_USER_CMD_LEN       (0x400000 + PAGE_SIZE)
>   #define SBEFIFO_RESET_MAGIC		0x52534554 /* "RSET" */
>   
>   struct sbefifo {