Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <348c239f-243e-405a-a0ee-92433626b682@intel.com>
Date:   Wed, 11 Oct 2023 16:14:55 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 0/2] Fix memory leak and move to modern scope based
 rollback
Content-Language: en-US
To:     <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <nvdimm@lists.linux.dev>,
        "Williams, Dan J" <dan.j.williams@intel.com>
CC:     <rafael.j.wysocki@intel.com>, <andriy.shevchenko@intel.com>,
        <lenb@kernel.org>, <vishal.l.verma@intel.com>,
        <ira.weiny@intel.com>
References: <20230926184520.2239723-1-michal.wilczynski@intel.com>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <20230926184520.2239723-1-michal.wilczynski@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N29qRERaQjhmaEFQWlBMVWlsczFFazFQZWwvNUp5QjBlSzliZG9JK2ZERG9I?=
 =?utf-8?B?dHRJQllDQlMrblZqb3k0a3RBUGlWWm5UQ2owRzA4YXBkNEdQS0hPMlpOMFgz?=
 =?utf-8?B?SURBd3p6c2FlZTJtcUVCRDhoL1ZoT1B1ZnVadmVSZGhnQnQvU1kvQUp1MnE1?=
 =?utf-8?B?T3luOEFobTlzT3ZMNmdWbHdXL1ZQa25rZWp1N1lvUG5ya2FlQVJJZGN3bGdW?=
 =?utf-8?B?WHorZS9KWkVzNUc4M29OSXhtQUVoZXNQZ3JLQ2RqVDhYbFJuQmZWU1FyM1Yy?=
 =?utf-8?B?U2JpcUpaelNWT1hkNisyNzJYU1RUQTF2Nk9TOUNtWEJLQXpZZ2xxdk1JUk9N?=
 =?utf-8?B?L2I1cnhxaFhvaTNNTXlhRitXWlBnZDAvK1V5NHpTU2xma0VtUWhCSWNUelBt?=
 =?utf-8?B?L01WYjJyME5jU2lKUTQwVWxYcGpSNzNJMzJNbDRCeDdERWZiUHYxcFd3NWFs?=
 =?utf-8?B?M1BTTHByb1NJUjBJOVRVRSs0eG9jeUc5QUdDSVNyVkorcWdkeG9leWpySkxi?=
 =?utf-8?B?bzB3WjdlYXF0dDN1SDVORHlRVktOdmdoa0x1ak1pb3FhMEc1R0lZelp0bWxx?=
 =?utf-8?B?MmdkVXE3c1lsTGFRM2pKMzJqV3JtOWN1TUFmZy9BbENlWG1VRjIyM2U1ZWVU?=
 =?utf-8?B?N0Y1RHlxQ0xXNEd5K1lvQXc4WnMzakZKOUNZMnlLN3I0ZTV6S3A5dEZQNytI?=
 =?utf-8?B?NWxCdm83TjNIb0J4WnRtVnZVNnBjMjRMSnRDb0RtVVJBZXZtNUo3UFFUaFRD?=
 =?utf-8?B?ajB6eUpRRk02VUt4ZG5Xbi96K0Ywb0IwaURaQi9TbXhqWGZrcTR3WkZNSGhH?=
 =?utf-8?B?YUs3c2FVKzFrQnpheUZMeXBoOGIreGxvWjRKRjJlUWgvNWxwUU1XTmc5dGJO?=
 =?utf-8?B?djNrWW5GVU1LazNySXpnOTQ2UGxtdlNtRi8wYkxyQk9aaDM2cUlxaDRrcDBm?=
 =?utf-8?B?R3BqdVcvOVFpRG93UEcvRE1JWjFST0hISU44OXduK1BweTB5VmVzajQ4Zmxx?=
 =?utf-8?B?NUZnRXBLcGorSmxhODBEOXZjWDhnZVc4ZlV4OC9kcVU3Z0pPRlIzMTJTeWJn?=
 =?utf-8?B?M0pyeXdLT1VGaXVqY0UvU294S3ZjVmxxVm5ZSjFSRG9mUm85cDJML3FMckpz?=
 =?utf-8?B?Mlg4WmF5bjFucFNLZW50RG9UTEZQMkpBZ2xrbElXZEg1TVZMaHkvZS9PcFJJ?=
 =?utf-8?B?NmkrN3hGVDkxaDZLaG1HNHdJOHVVc21OS281Y29tZmhaVEplMW5sdmtiYWhE?=
 =?utf-8?B?SHBDa1VkdU5vMUMramtpL0xhTktKbW1oR0Y4RFJuTHNWWncxbXBKOHBoek5P?=
 =?utf-8?B?cHV2cHlTY2VpZVhzb1E1aXN1b3dWelFyb25MTm9jOGpkR0hkZ0U3YkM2cWZD?=
 =?utf-8?B?bnJpZFdFT1AwblhmN0h0L0hmeUlxNjFJd21UbUUwQ0JGeXhvdHVwRTJnNCsz?=
 =?utf-8?B?a0VLVG5qRFZBZWFQQjZKVDE5Q3Q4WXBXL05UVFBFaCthWmNLZGlqTGxRWkh0?=
 =?utf-8?B?RlVhQVV4MnhwUUd4RExtaFZvNlZIRlh6MVQxaUl6SWdBL1RSMHRRbmxXYjRl?=
 =?utf-8?B?azNZOWhqVlcxV3ZYUTQ2dHV6V2xUMGw5cFdxYm9ITVZGaUQ1Z1RkeW1sTlpk?=
 =?utf-8?B?K3hnM2dYNjNabFV1ektqRC9WdVByVkNJaDVuY2pHMHlKQzBGSTg3cW8raFlL?=
 =?utf-8?B?bVpLV1VuMHo0MWI4VFNQYUg4WnJNZ3VNSk5LZkREb282ems5SEYwMmtMcmND?=
 =?utf-8?B?SU9iZ2JUenBzZ1pEbmFaYzZLclhGN0NLWldZNlNhTkJtV3ZuV0hBd1VBVVRT?=
 =?utf-8?B?V3N4dE4vb0h5V3BteFl6SjQ3NGN2Q2JTUTNPUUtIZGlKZ3lGY3o2aXBmSExk?=
 =?utf-8?B?M25xQ2ltYWpocG5UaG1QUVNBYk1QVnpHZ3g4NkR0bzduT2xwbXZkR3A3SjBk?=
 =?utf-8?B?WS9WaDF6UU1MZDZnWkZrcUlmNWdHQlZ4clE3eCtqVGltZ3pyVENPYUY0NE44?=
 =?utf-8?B?ekVoTmFJbUhuZ2hyZmtYRUYxODUrZ0s1ZFo3U0JWaTJNWkthQ2lTeVFBQWJM?=
 =?utf-8?B?ZnZIMjlKRUZ6eWJNWFlwVFlZc2M3cGFaMXBhOVA1UlcyQkwwQVQwTVBkLzZG?=
 =?utf-8?B?SVhFbzE1TUdUSWNWcTl0UE5Pb2tyZy9kUFBURU5nK1dFRU01UTR4ODhyRW1u?=
 =?utf-8?B?akE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cad77b9-ec00-4333-5b40-08dbca6475fe
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 14:15:03.1099
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TKhavNLp/f3l9OsvfsG7oJItTKcrMkbrsBv3jMl6Hrk8KuSjxKzdRp2GNkerHYsfpg0w6CpwMw52BsUhvIyr9VWrvZebgNi0lFdsDBYK4ds=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6180
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 11 Oct 2023 07:27:19 -0700 (PDT)
X-Spam-Level: **


On 9/26/2023 8:45 PM, Michal Wilczynski wrote:
> In acpi_nfit_init_interleave_set() there is a memory leak + improper use
> of devm_*() family of functions for local memory allocations. This patch
> series provides two commits - one is meant as a bug fix, and could
> potentially be backported, and the other one improves old style rollback
> with scope based, similar to C++ RAII [1].
>
> Link: https://lwn.net/Articles/934679/ [1]
>
> Michal Wilczynski (2):
>   ACPI: NFIT: Fix memory leak, and local use of devm_*()
>   ACPI: NFIT: Use modern scope based rollback
>
>  drivers/acpi/nfit/core.c | 21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)

Hi Dan,
Do you think this patchset is fine ? Would you like me to
change anything ?

Regards,
Michał

>