Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <a9515560-32bc-4f3b-a36c-87f7242081a9@siemens.com>
Date:   Wed, 11 Oct 2023 16:45:29 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] tee: optee: Fix supplicant based device enumeration
Content-Language: en-US
To:     Sumit Garg <sumit.garg@linaro.org>,
        op-tee@lists.trustedfirmware.org
Cc:     jens.wiklander@linaro.org, arnd@linaro.org, ardb@kernel.org,
        jerome.forissier@linaro.org, ilias.apalodimas@linaro.org,
        masahisa.kojima@linaro.org, maxim.uvarov@linaro.org,
        jarkko.sakkinen@linux.intel.com, linux-kernel@vger.kernel.org,
        "Lopes Ivo, Diogo Miguel (T CED IFD-PT)" <diogo.ivo@siemens.com>
References: <20230728134832.326467-1-sumit.garg@linaro.org>
 <CAFA6WYP7hgRWS_gp2AFEWDs27aOeUndB6+1dh95TtW2s1N+5Ag@mail.gmail.com>
From:   Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <CAFA6WYP7hgRWS_gp2AFEWDs27aOeUndB6+1dh95TtW2s1N+5Ag@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDFuVitQWTZ1em1tT0NDQ1Qxb1BoMHV6eTVjdUU3OXdPS1RDT0dNbXBaSHY0?=
 =?utf-8?B?RXRkMkZBbVBvcU5rL3F1YldWdVRUdHF6OXN6QVRLUS9rV0xxKzBhWERzU2s0?=
 =?utf-8?B?ejg2N3ErajliQXFpSWpnWkk1aEJ0aDZOLzQrZXlLUGFCWXd4UHo1UDBRaGgx?=
 =?utf-8?B?aTBSb0hVRUwvWkh1ck1wbUJoSHhjTzRBZXNPaDFiaktvY1Y4TjdNcWpXY0xs?=
 =?utf-8?B?T2NFOXNuUytLUXFPanJSQm5WSmpmUE93TzBHSFcxejZ2ZkhrRnpmSkNPbTFq?=
 =?utf-8?B?aG95bFBKTE9iT1R5SmV4TndKNlMrVlZTWVVJTk5lcHdXbUxQcmdWN2lGOWtx?=
 =?utf-8?B?cEVaZmVSd2hrc2VINHpOR3hZbjZONitKaUJqR00wM0VMb3VwZlg1UUNEcXdv?=
 =?utf-8?B?SE9oS3A2YURuY2t5UUxNS0pHd3VSbGxKZUxyRHFDMnZmQmcxanZvbDRLSUU1?=
 =?utf-8?B?elQxbEZJSWJkWE1MaVUxVG1WaTVHOEczbXppUVNuTUhFdjhJZXZ1UmRzSzA0?=
 =?utf-8?B?Z2pseVczWjVURjhIakJQTUl2MmJkOGdhSGFUYlkyOTdnTHZFelplTWk0VUdB?=
 =?utf-8?B?TWU2enZHYmM4K0pGbUJqdXJYdXlwY0V4RkkxcHZtVzVxWVhQZGhvWVRMV1JV?=
 =?utf-8?B?TWFWUW1zNFhxM0hWVTJCUEliU05LbzdjcG5aZCtsay9OdlhiL2ZOOGJQNzdj?=
 =?utf-8?B?VEljTGkyek1ZeFROczJFSUQ0NkZEY2ZrMDdJUWRYOVQ2V3J4TWRTekJaWjZi?=
 =?utf-8?B?dWcwdUViaC8vOEpOTlVxMStvZzJkaFhoUVlXT24rMXRPOGpnQWhQS1FiWS9w?=
 =?utf-8?B?ODVGUGdaRkRNVy9nVjdQaHVIMmsreW9EOWhMUk55Q2liYnBoVVgxSXhBNTFh?=
 =?utf-8?B?bFNTRkpOZ3JvWUQrMEVxSXdTamptak56VmlRaFI5ai9kYXV0bk1ReDg4eE1J?=
 =?utf-8?B?aU9MM0RNaFVCRXdlcmx2b2FoU0pSNmUwMVN3elBjMU16dEVpdk1WeGhhOGtV?=
 =?utf-8?B?MXcrN3gwN21FbUswdHgvaFczSVgxZXd0NitPdWQvYlVJVjZlbUgzMmFJZ01U?=
 =?utf-8?B?Qng4SEZLWFZwc2I4akl1UDVObWphZFFNZ00vV0tXOWk4angwUEtQU3FCOUxT?=
 =?utf-8?B?R0ZaWkNVb1ZKUXFycWFNQjZYc3h1L3dmWlpQVFJwUjFpRUgrUkw5N09SL2Qx?=
 =?utf-8?B?VWlWVWNqZlRXRDZ5RVJsa2RlZWF1U2RNY2tISW95SW14b3NLVURtMzh4b0ZT?=
 =?utf-8?B?aTgxZXF0VVpRYnZaOW9WTVJOVFhTcnNqTUE4YmR4bnYxMms2S25oTzRnUCti?=
 =?utf-8?B?eU5zT21oVVFFNnhLQVdvQzVvQ2NrcVJGeGVEeTFxZDF6ME1DdzdkZWFHQkh4?=
 =?utf-8?B?elRsRnBoeEVwN283WUpXYndXbmJ5MFIzSjVGekFyZ2w3dHMrNUZwT0Q0NlVE?=
 =?utf-8?B?L1diUW5PZXhTNlpqUmxaTXJmenJOeHBoOEg5TGFUaEVDcWhSTWpIbmtuOCt3?=
 =?utf-8?B?WXFYTFNCMWVyZXVlRm9wQ3RGdVlRKzlGTWc0VjYzZlFiNlJYaStlcU5NUVc5?=
 =?utf-8?B?L2hyNDkvcVR3eFg3THRhejdhMDVidHVDUTdGLzY4YnYwd1VOUXpac3J1UTE1?=
 =?utf-8?B?bmdlQVJNdk9FNi82SzAxZnhjSWE2c2x2dVdpQXN1Z0lRMGVKbk83cHVpS3lm?=
 =?utf-8?B?THNJWmV5VUJKYThaWFI2SGRFV2QzanBSMkF3cUpLU0Z1UFpQdWZDc1ZzdnFI?=
 =?utf-8?B?UTVlaUpaREN1bkNYNzBKM05PRHVYejdMWlZVVXh2NDFGS3U3bWVEZjEreXBt?=
 =?utf-8?B?RWd0NDNmR1g1ZWJFN1NkdzVxYk9BNVhBYlBLOEZtSXZQWjBreTFESmk5dE01?=
 =?utf-8?B?Q1BMYWZHQVhoR3U0N0s5WUZqdUwzcXhtQ00zRFhhQ2I1ek5wMTFvck1BbURk?=
 =?utf-8?B?R05SQm9Ya3RsbjJvWExpRzhXM3RBRlVEYy9qTERjTVJIOTR0bnk3WG9PVmlt?=
 =?utf-8?B?RDUvdDFqdDFmNkxWK1daMTE1YmE2eEYrb2RXbWtZV05LeE5zdWhSTjFNUEhm?=
 =?utf-8?B?OFExODJ0ejJabTA2d3lha1A4aFF0dXI0OVNLV3libnVMMzNURHg2NlMzUDF6?=
 =?utf-8?B?clNOdTRYZVNPenVubS9CU3NHYmNraHA4ZGtPTC9iV1JzYmxuMCtsMHRCS09M?=
 =?utf-8?B?SVE9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ecb8e7d-936e-4a69-1b68-08dbca68b845
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 14:45:32.1556
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FJLE/lVlcvfJUQHE4XG5VAlU4QPKv7GGd9SgyuS9j4AmwMIsm/6SYlm64huuMmEVkntWA2rU/cZ9zhzH9pBGeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR10MB8107
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 11 Oct 2023 07:45:47 -0700 (PDT)
X-Spam-Level: **

On 29.08.23 13:03, Sumit Garg wrote:
> Hi Jan,
> 
> On Fri, 28 Jul 2023 at 19:18, Sumit Garg <sumit.garg@linaro.org> wrote:
>>
>> Currently supplicant dependent optee device enumeration only registers
>> devices whenever tee-supplicant is invoked for the first time. But it
>> forgets to remove devices when tee-supplicant daemon stops running and
>> closes its context gracefully. This leads to following error for fTPM
>> driver during reboot/shutdown:
>>
>> [   73.466791] tpm tpm0: ftpm_tee_tpm_op_send: SUBMIT_COMMAND invoke error: 0xffff3024
>>
>> Fix this by separating supplicant dependent devices so that the
>> user-space service can detach supplicant devices before closing the
>> supplicant. While at it use the global system workqueue for OP-TEE bus
>> scanning work rather than our own custom one.
>>
>> Reported-by: Jan Kiszka <jan.kiszka@siemens.com>
>> Link: https://github.com/OP-TEE/optee_os/issues/6094
> 
> I see you have marked this issue as resolved. It would be good to have
> your tested-by tag if it works for you.
> 

Sorry for this very late reply. We finally validated that this works
fine for us, though only over 6.1, our current test target. I hope we
can enable tip of tree soon as well. But I think I can still add my

Tested-by: Jan Kiszka <jan.kiszka@siemens.com>

Jan

-- 
Siemens AG, Technology
Linux Expert Center