Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <b660e39e-24ad-c755-7962-aa56e8cdf4f7@axentia.se>
Date:   Wed, 11 Oct 2023 16:59:08 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH 3/3] i2c: mux: gpio: don't fiddle with GPIOLIB internals
Content-Language: sv-SE, en-US
To:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Linus Walleij <linus.walleij@linaro.org>,
        Andy Shevchenko <andy@kernel.org>,
        Peter Korsgaard <peter.korsgaard@barco.com>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
References: <20231011130204.52265-1-brgl@bgdev.pl>
 <20231011130204.52265-4-brgl@bgdev.pl>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20231011130204.52265-4-brgl@bgdev.pl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzRXUmZIUEU0VW1tRGg5UkVIWUpsVjFPZjhtaFB4OGM2K3NuTTFjNjNpOG1y?=
 =?utf-8?B?b3g5dU9icjh1ZDRTUC9tSzl4QUdzcVZEdEhTV2hxeXJ3bVVZM2pXblZOazYw?=
 =?utf-8?B?OEY2bE0xYlVOUU5qaUhMc1BUQk14Y3hFeWpOQVJlNnNQemUxQjlaNVVnSG1S?=
 =?utf-8?B?R1pZTm5NMytVM2U3ZVA2OTFKVHhQU0NIdDEzMksyM3VKT2NYNm5XZ25HZ2do?=
 =?utf-8?B?R2k1QzhBYzcxRUFBWGEzUVE4MXlNeFBtNGhxRm1tVXhScjBXdFVLNmUrdXBK?=
 =?utf-8?B?bVROODE2cHNRVjQwRGl3TEZJa0UyQTBodjR0Ti90NHB3bHUydE1HYmtYeFZX?=
 =?utf-8?B?eE1iSVVKbHg1dVVKUWYrLzJUU2QrV0dDSHZOMStPYjNrWHE4WFNmV0JkWTFz?=
 =?utf-8?B?SHFsbWE4NnFheVo0UXhXTC9sV2JVUXFiWVJUVFNCZ0loY3BaaGtxOEUvQ3Zq?=
 =?utf-8?B?NDYvWkVCeVg1czNkbXlDMlZLQXNSREphWDlIYzl5dHFRRmtLTHJFZkR4M09l?=
 =?utf-8?B?ZWhKWmtpa3dQQnNEak5JQzY2S0YybCtQWDI4MXY5WDVkSGd3L0ZRaXR1NFdL?=
 =?utf-8?B?dCtzTURLUndmTWdwaDQvdURBd1NjdVRuaFFMWDNrM3c5ME5QeHNuOWs1WjVm?=
 =?utf-8?B?Z3lrR1ZhbUpoRWxkeE5FWmlYNUt2ZlNzeW1vSFZxeFVSbjlSRE42dDZIRVc0?=
 =?utf-8?B?dWFrYjBRSkZCZ0t1eTIxR29obHdwbGppS0tsQnBDekxKbkpKdFNRbGhnMkF6?=
 =?utf-8?B?WWRnTnB3Z3lqRk9MVVArUS9nZzFtSUpjTnYxMGVldklHTW44UGJERkhoZStN?=
 =?utf-8?B?b3NucE40WFVQUjgwY25aajBueGVROFd6NVVyMWFkdDZadnJPSnUyc3gvMjE4?=
 =?utf-8?B?ZjRCbFZkUjZWZVp1VW0rMy9nelRad1U2bUJVTks2MDEwdGZwdUltRll6U01o?=
 =?utf-8?B?YkhpTjBDcHRGLzhCdlczRDB5dDRXSE5LSTY0OE91bUpMempOTmVrNXlOZWlE?=
 =?utf-8?B?UDUyMkt5N2VWUlNZcWx0MERoWERLckRnYlhmMVgwOFhsR1RJSWFFUVlnT3My?=
 =?utf-8?B?SHlZMnJMUGpCRnNhY3R5QktpVC9yRFBKSStJWEhqWXVDWXdnN2VoUkViVnVl?=
 =?utf-8?B?bmFvYXg2dGRCd3BpZVNKbThGeFd6MmpQOE45ZFdCWkluL2Rubldod2hPd3dz?=
 =?utf-8?B?dzNtYXRZQVVRdjF3V2Yrc0ozUDd2UlJPdWlPcnc1UGJyRW9La3lMZEpKaWtv?=
 =?utf-8?B?a28zTnlybngwOXZFUGdNQkliVzhPWXBFTEZkS05ldk1zUGFQdWRDVmw4YUQx?=
 =?utf-8?B?dXhsZ2d5cmVRNmh2bDZOOFVFdnU4RGhtQlVPZldQaEVZSHl4MExaVk4yWklR?=
 =?utf-8?B?ajRIMkxkbURaemRxY1o5UHhRR1YyMTROckM2a2NTeTdDbzZBcTlaandSWm1r?=
 =?utf-8?B?MXVodFR3TGlMVU9vTDRvOUlkemIvb0dMMXpQUkNVb2FHbDI1WVdqSmNKQ3Nw?=
 =?utf-8?B?OU42Qm1IODlFM0dpZ1ROREtFTTdxUVpMWjRqckpjTlFvQlNlTFF4ck9zUjV3?=
 =?utf-8?B?YnVlWmVBNE5GRHRxU2VvOW43OUJjaTJwbjUvdVFwQlpZNGhxK2FNbkZOazZX?=
 =?utf-8?B?ZldqRTk5ZVdHN3NiN3BGTkk3WWxUUjIxUnQzNjJkVEFvWVFFQXEzcWdhTEJY?=
 =?utf-8?B?SmJyY0NoVjE5RlpvOWJMTVcxRktsK3FqVHJVcFdZUjNFbEtIUmlQMVJ2L1hv?=
 =?utf-8?B?NlBHclhZdG9oRVdUQnVia1VnQWo4bTBrVmsvWlU0UXc3aUkvdUpiRkp5L281?=
 =?utf-8?B?M2QvTFhXbDJCU0ozNEE0QmRlOWh1WXFiTzdaSTB3L3RLdVpQaHRWZ1ZqWWZL?=
 =?utf-8?B?Y0Evd2lkMUdvSnBXd29EdEM2MGYrM3huYlIrWGoxMmZPdlREek83WnpKN0xZ?=
 =?utf-8?B?SmNTaFlLNnJtWkpJWHBVdUtsNk1jZHQyNzRUVldkQ2J6aGZ0aVRJd1N4U3hU?=
 =?utf-8?B?enZkZFIyb1E3dzIxSXVaNE1LejdNTWpPeHpaMzAvMzhVSUgvckRhSVZJZ2o0?=
 =?utf-8?B?ZllFaWZsS2RDNjlXZUc2dS90cUJ0RXNnTmVJdnRHTFk2amwzR3VxTU9ZNmpw?=
 =?utf-8?Q?NwfVIgSMR4GD7LDQKorLng14J?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: b31ba7f9-7ff8-4218-9724-08dbca6aa004
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 14:59:10.4094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GFKNu2sjZ7zta0p9LmuS/2hXzqc84YBGhVYDowwsM1dLYJPYAM6ZrLDhuMJw0w8J
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR02MB8913
X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 11 Oct 2023 07:59:30 -0700 (PDT)

Hi!

2023-10-11 at 15:02, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Use the relevant API functions to retrieve the address of the
> underlying struct device instead of accessing GPIOLIB private structures
> manually.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index 5d5cbe0130cd..48a872a8196b 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -14,8 +14,7 @@
>  #include <linux/slab.h>
>  #include <linux/bits.h>
>  #include <linux/gpio/consumer.h>
> -/* FIXME: stop poking around inside gpiolib */
> -#include "../../gpio/gpiolib.h"
> +#include <linux/gpio/driver.h>
>  
>  struct gpiomux {
>  	struct i2c_mux_gpio_platform_data data;
> @@ -176,7 +175,8 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>  	}
>  
>  	for (i = 0; i < ngpios; i++) {
> -		struct device *gpio_dev;
> +		struct gpio_device *gdev;
> +		struct device *dev;
>  		struct gpio_desc *gpiod;
>  		enum gpiod_flags flag;
>  
> @@ -195,9 +195,9 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>  		if (!muxc->mux_locked)
>  			continue;
>  
> -		/* FIXME: find a proper way to access the GPIO device */
> -		gpio_dev = &gpiod->gdev->dev;
> -		muxc->mux_locked = i2c_root_adapter(gpio_dev) == root;
> +		gdev = gpiod_to_gpio_device(gpiod);
> +		dev = gpio_device_to_device(gdev);
> +		muxc->mux_locked = i2c_root_adapter(dev) == root;
>  	}
>  
>  	if (muxc->mux_locked)

Very nice to see that wart gone! The only small question I have
is if these helpers are needed elsewhere, or if a more "direct"
gpiod_to_device() would have been sufficient? That said, I have
zero problem with this new code as-is, and that detail is of
course squarely in gpio-land.

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter