Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp904800rdg; Wed, 11 Oct 2023 08:38:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErajxLXJfymgyx70tjQqiV+s55LJ+IT43bSTOTMD20Irp0DzSpJK4nbzSufPvi5YqaMR2l X-Received: by 2002:a05:6a00:3a08:b0:690:cae9:714d with SMTP id fj8-20020a056a003a0800b00690cae9714dmr20857463pfb.13.1697038684465; Wed, 11 Oct 2023 08:38:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697038684; cv=none; d=google.com; s=arc-20160816; b=vcduj5ZKvyAwUDEPsJgoc3ytlu+/eHYUCRjIB2XutkXK6QhavhiyKVDObHvURqNDtH mip4ks/4E4J8bEm/AphCk31M9BMdG2ix45PBShVYYf9ELeR+kCRvTWrHgK3SA0HZQ2ko FUtqng3wDFY5KEuQsrvppN3KiAdPZ0+ryR+WfNaHtU4PM/rz6ll7BomuFF5q8yN/rnTQ ILk8IQCzuwZP+GmymH9sWBQ1EhC6AW3zklRVyXpfYXmIgT1Uk3IXc/vq8jxlejIoUvUA GwsWuuFdBh2rfZ5dHX5qKYI0im0DQtN4DqWlAQSYzVbX3j4AyS8fCJ3kHc65ppIczNKt AS9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RyUhwkmcbgqHqWIDHCbOXe4GHf8JbeDfW6N9nCu8BHk=; fh=avSOzD4RW6Ls7I+AndpMiuY+rkTqJ5M2vXGPAGCBKxQ=; b=z1wsKnX+3UxGS6nFVtQyN/ojiZI9SOZD0DR1F0hSkOu4Xalzmd31FNN11IFB+RXnwL pjhKiMQ+DoVUPMKEiq8yAnjtCrQxhe+ZI3Sh5v3owGm84bq214gdJ5gIsoPW2eBbE5TG cU/tA07GngGeJyUSMzNnm+IflOBdqjjpD+AJjov7vR/SUk5abKKTLOzT61387WgvlSFE i5xqVud0ZtrUXJMbB/mtV17wyuVpM+a7hqjvw7e0DIQbcJ0290fQxuUMIPncIn1lTzB6 TBZijwNcEMe1avSPJkI2fb6PuKTid3qb3eBYHwqWkd8AA6uLWTa+eSVeL/19Wcsy0uQP n0dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SqMOVbfy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id fc35-20020a056a002e2300b00690d25b1991si13382624pfb.41.2023.10.11.08.38.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 08:38:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SqMOVbfy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 30E0E8050023; Wed, 11 Oct 2023 08:38:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232739AbjJKPh4 (ORCPT + 99 others); Wed, 11 Oct 2023 11:37:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234946AbjJKPhy (ORCPT ); Wed, 11 Oct 2023 11:37:54 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06DADB8 for ; Wed, 11 Oct 2023 08:37:53 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44CB3C433C8; Wed, 11 Oct 2023 15:37:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697038672; bh=sZYMiIgfprtrSPa/YkV0LT+ZOWe7IlPCwKkD47oyPlM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SqMOVbfyTIsQHi9u7DJ5iIe+Ff0gwSpewAuPmDzyYXvqcvJ4F+kiBPbNSqrlJQCRK tl46k7q4/GIsuM7g4CwYR5gzNQxaknnoWaSotPpEGO/v02gd346PPfYUXzJFP37CeZ 1b8PmDksnZhMFZJciijKOd81d9mD1d5wdrPRzetPswD+VujzyqUgU7uwhKfuQJn5b6 dZ32lmPgn2Gcwb4ezDISUOx2EMgAWCKMPcBIL/8aUDlgnc1ziq+hJv678yteFFpcHP kihDfRlFKpIHXiE0oRUkMx4q6TEM13lCXeM/lE5TR920UXFBWWVOpeJX98sphVmy3X 80UQuo8FOYC2Q== Date: Wed, 11 Oct 2023 17:37:47 +0200 From: Simon Horman To: Jeremy Cline Cc: Krzysztof Kozlowski , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Dmitry Vyukov , Lin Ma , Ilan Elias , "John W . Linville" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+0839b78e119aae1fec78@syzkaller.appspotmail.com Subject: Re: [PATCH v2 net] nfc: nci: assert requested protocol is valid Message-ID: References: <20230906233347.823171-1-jeremy@jcline.org> <20231009200054.82557-1-jeremy@jcline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231009200054.82557-1-jeremy@jcline.org> X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 11 Oct 2023 08:38:02 -0700 (PDT) X-Spam-Level: ** On Mon, Oct 09, 2023 at 04:00:54PM -0400, Jeremy Cline wrote: > The protocol is used in a bit mask to determine if the protocol is > supported. Assert the provided protocol is less than the maximum > defined so it doesn't potentially perform a shift-out-of-bounds and > provide a clearer error for undefined protocols vs unsupported ones. > > Fixes: 6a2968aaf50c ("NFC: basic NCI protocol implementation") > Reported-and-tested-by: syzbot+0839b78e119aae1fec78@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=0839b78e119aae1fec78 > Signed-off-by: Jeremy Cline As per my review of v1, this looks good to me. Reviewed-by: Simon Horman