Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp910242rdg; Wed, 11 Oct 2023 08:47:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNV3fcMZdRrohCW9x+vb3VrIVEJv4y7LWQjF1QhgLpoOcScpAO7WZTnmfB4AbuSfV3F1k8 X-Received: by 2002:a05:6358:9485:b0:143:6b2a:e909 with SMTP id i5-20020a056358948500b001436b2ae909mr19428949rwb.25.1697039250377; Wed, 11 Oct 2023 08:47:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697039250; cv=none; d=google.com; s=arc-20160816; b=m0Ky5IlBBT4CMJAK5DQALC4p8lZWYKG6s03ZVxKn5AixAoJt0skkT5pc/DolDR8ZjO bIAnqJ1ytyQTSolZa9N2soDPcBCzx/pvs2y9QkqVWCOtrNPKggayS36jCa2mQ+b1hWYg 5DQYDcI5ica5vTtje/JwBsGM5sfjyEGvLCN00A0MVwktXCqsYZ5wrtWnTf1FAY0ZgJMD Nva2lCTHVKrXa/pCl64ow4rl5SylV6OK0NQnL6HQKYyCVSGB3K7gCBLiB32xSGLppLg7 sg8Attqclei0+TYmf93CtvYM0DlPyscGACs+75gFVFE0DJhy1vMG96JLBJaJKDlOLPJS kKsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=EE5ap+Dur4ncULreHDrHsnDe3Sv6isz8UgK7sSfmbvM=; fh=vB5+ek3XL0N1qCWur0cte6dq3szXQs8mtnrWODokUoM=; b=BYv6ccPATktWsMVRoJeV1tI3O/UjAXJjaO0WdHsPcP4GUdBj7TU8USkqcmzah2xYlU WL8QkDs7r0ZGEZxhwLO9qHBHNXxe2Lr5uO0pjw89LrOBTapkbcKoQy11xyzQwPW/UuOe osGZ+E6ioT2AmNopGXOjuVc24d6w0NjCQT49TWGi1PEs1O0re/wxl+JziAEcMRY5IapE U9eu/ulf6lWA+1oWPppU0re73Gjl43pvZyw2D1OGM/A+NqV47/kOTeKNExgJpJIIuP97 N/hYNDpyYI5Oi1R8YY/Jjlrnu/HN5kCu1TjVpYGGxZTm8R3/xODG0Sr0lXjvt1Ta86L1 SrjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="ZQUS/8c0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id o193-20020a62cdca000000b0068e42950c86si1579649pfg.44.2023.10.11.08.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 08:47:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="ZQUS/8c0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 3959C81716A7; Wed, 11 Oct 2023 08:47:27 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235070AbjJKPrJ (ORCPT + 99 others); Wed, 11 Oct 2023 11:47:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232342AbjJKPrH (ORCPT ); Wed, 11 Oct 2023 11:47:07 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EFCEA7; Wed, 11 Oct 2023 08:47:06 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-27d0adf699bso488953a91.1; Wed, 11 Oct 2023 08:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697039225; x=1697644025; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EE5ap+Dur4ncULreHDrHsnDe3Sv6isz8UgK7sSfmbvM=; b=ZQUS/8c00kyW76fpkl0BmolwBOFDFWxaKENmL5DklcvcKTaTf6GBzjRejpfvjsg1kB aX8eTcDQxkGnzVJJQEn2yzZtEsQyTSqEqBW8nuZXVTLQSN9h+uiCuLwKDJi+omWUgcef kV8S3hecOu6lJaE9BzKY6FNnPjlwmfrnTUHlUEjxQEgGJyBhj9mmEPAaDSly0k0mzkC1 CWx3pSEe1kblFx/aHYPpnZusSD9TtM5p8ILPwzDQXOTdOO2sVpCKd3iBsXyKXg+72+LK I3QSPNA5EcOFFKuFUANLJoHsY3ciy+ygdkaXJeiUG+9g6X637gVrZzfyo8FKLnNfgHAs 7jCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697039225; x=1697644025; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EE5ap+Dur4ncULreHDrHsnDe3Sv6isz8UgK7sSfmbvM=; b=YsaFsl/YsYP3H/4I1GWT5o4n3wVOe5K6Mxo0lkp/aY4JZ+HLNhA+C9jG0fbOnXNbGR TKuWgZJGAQ1U12ZSH7R+il07K5FZ/r7uaxNE5Q7muEhwqg2sxq+dxAoV4+uT1r8plKNI vQ0/cyusFPmz6o+7dboarXmgRc4FS9rvv7eSVBj4O9jy/TDE43G7fFxsU7+VaJWbuvDy cPyQKx8Neb54MaQ4BC+Nq+Ix5OfLi1Vd0UfDKCfHpwQQ7C7IjwdqeqVWimlv80aCwtVW 25QCHGEsnjzb2kgAkECY4UBhBI1NYaFFLNHqjz//TKkpMHWCfpVVAlln3KaIBDAP2k1q XoLw== X-Gm-Message-State: AOJu0Yy5wB8HPo+1bjQ8oFFRWtnUme6hPl8QfL4Ca0wp7EIPuGC7ihe6 LpLtpoSj/vZkEWJds3CThZ8= X-Received: by 2002:a17:90b:3145:b0:276:cd68:608d with SMTP id ip5-20020a17090b314500b00276cd68608dmr16591502pjb.22.1697039225479; Wed, 11 Oct 2023 08:47:05 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id j5-20020a17090aeb0500b0027d0a60b9c9sm61178pjz.28.2023.10.11.08.47.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Oct 2023 08:47:04 -0700 (PDT) Message-ID: <187ea1dc-4c7d-4dee-9dfc-15f121320d0b@gmail.com> Date: Wed, 11 Oct 2023 08:47:03 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove extra unlock for the mutex Content-Language: en-US To: Kuniyuki Iwashima Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, kuba@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, singhabhinav9051571833@gmail.com References: <20231011002814.77527-1-kuniyu@amazon.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== In-Reply-To: <20231011002814.77527-1-kuniyu@amazon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=3.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 11 Oct 2023 08:47:27 -0700 (PDT) X-Spam-Level: ** On 10/10/2023 5:28 PM, Kuniyuki Iwashima wrote: > From: Florian Fainelli > Date: Tue, 10 Oct 2023 15:51:13 -0700 >> On 10/10/23 15:46, Abhinav Singh wrote: >>> There is a double unlock on mutex. This can cause undefined behaviour. >> >> Where is the double unlock of head->lock (which is a spinlock and not a >> mutex, btw)? > > Maybe head is just confused with the preceding head2 as the two are > the same type of struct. They are pointers of different hash tables > though. Suspecting that much as well, though wanted to read it from the submitter. -- Florian