Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp945152rdg; Wed, 11 Oct 2023 09:39:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFR+ro0KFIuV0KpNiy2+TGSuUG2qEfzZUXAzwGYnjUmlw8BRuFwR3DI/p2ju97lPKbtzOu1 X-Received: by 2002:a05:6e02:188f:b0:351:1647:5fa0 with SMTP id o15-20020a056e02188f00b0035116475fa0mr26094545ilu.18.1697042392998; Wed, 11 Oct 2023 09:39:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697042392; cv=none; d=google.com; s=arc-20160816; b=0MhO8hSjS+cW/JVWLAfL5BraEP3amz9gBBwhono1G33dYciy3MZn0Aw2XRMw4elTCg oipsmVXSyNdKgNG4Lh68kIq3U5EXbNa/1X6aCL5EAAXPGM5MCfcsH8L8smOS/0nH8LBQ 9NneW66OjC4h9KuaNZaV/u03tNR8x9+bsNpsiPa7GRkheKWpsQua/l8iG/bRZ0J4TVow S7wwpYRCbU2DjnYnUiNpF2Iv7qQq525jm28OotaXbTkgeNnqYU6ab14lC1uhKcVoI5OJ VXOk8iNTbWj9YMIW66YNkydtocK+sLLzvjg8GhWsHkll3ay2ge3MeXPSM5b5OnLytFRe 5llg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature :dkim-signature:date; bh=czixzo5H9lrjEHVPwiEdlDlSNtg3PpSgksRzgfHxAZM=; fh=/HaE4p/lYjGRA+LUgSNGNAaIH233CGHkq2XSs8PYlDo=; b=V6MvYRSBDf+HonrJlv5UqX/U/VlPpedpgtqi970hJvbuOGpAL5kKmetnOfYxg0o0yJ R4/5DEHEwIyEZptjvw4vKCYCX/7XAyomafqOKjEM/zvta4sOhostFGolFYowE1GFbu63 5igwm4P+QZdIvtCbWo/3QrO3lROrvaX1mhTicP9WG3fcmtt5YzwFSUjJSZcHpFjV0TEC bcevPyDMKMMVBkbI+8BpEUJZLubGriA/tOSSE04Qt5eW9gFFGUb+TKaksHrWwR3FHBgQ WjuoZPywyjEgPbOtSygzeezwB+JXJ3MieyoB4efjlU62JUrCeDNwaJCFWniYdrz3x22U JriQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=eb0gK0lO; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id n5-20020a6563c5000000b005859c221c76si135989pgv.419.2023.10.11.09.39.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 09:39:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=eb0gK0lO; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id B978480613AB; Wed, 11 Oct 2023 09:39:50 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234947AbjJKQjo (ORCPT + 99 others); Wed, 11 Oct 2023 12:39:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232146AbjJKQjn (ORCPT ); Wed, 11 Oct 2023 12:39:43 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 102548F for ; Wed, 11 Oct 2023 09:39:41 -0700 (PDT) Date: Wed, 11 Oct 2023 18:39:37 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1697042379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=czixzo5H9lrjEHVPwiEdlDlSNtg3PpSgksRzgfHxAZM=; b=eb0gK0lO3rROe0IazF7YQ2QFB/Wsv0rWb21m5CPj6GyANhjJUJIGb8FW2Gnh6AhX9vYME5 ERpefIHHy/kkcx/9kX0KLmLydNCf0cNz87UQnMtKDLeaxoNbC6EcyZ8/b+RtZ9rzXT5K5P OXDO9jF1y+XZ3131MwlirKjdkUZB3UL12hnFlWuyWTvLvnZmk4iGDGxkSyeBSQSf9Zq38A k4rz68BhsNDLaE16CzMEKCz3YLXamvqtODn4I7iWymv5fTwpvw3juZzwPrnxmdb7GIluUV 1t8M2nixQvmo1bEVSILOMIr8ay2hWlpeyIENZi4whaB3HE52ioRAYtVimXM16w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1697042379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=czixzo5H9lrjEHVPwiEdlDlSNtg3PpSgksRzgfHxAZM=; b=CSA+MadGLden/zwcuWGafYowEObjjFT66utIWMQqsCT60byJ/kf8vjjE3lWxaYNZykrSIj vBaCiP2fMPbAVbDg== From: Nam Cao To: drosdeck Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs:Fix coding style errors and warning Message-ID: <20231011163937.WfJrCwdP@linutronix.de> References: <20231011164232.28866-1-edson.drosdeck@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231011164232.28866-1-edson.drosdeck@gmail.com> X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 11 Oct 2023 09:39:50 -0700 (PDT) X-Spam-Level: ** On Wed, Oct 11, 2023 at 01:42:32PM -0300, drosdeck wrote: > Warning found by checkpatch.pl script. Fixes warning replacing printk to > pr_crit and fixes conding style. > > Signed-off-by: Edson Juliano Drosdeck You are doing too many different things in a single commit. Try splitting them up: 1 commit change printk -> pr_crit, 1 commit add brackets, etc. Best regards, Nam