Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <6347cb90238ce61fb21a8203da53497663cee60a.camel@surriel.com>
Subject: Re: [PATCH v2] execve.2: execve also returns E2BIG if a string is
 too long
From:   Rik van Riel <riel@surriel.com>
To:     Alejandro Colomar <alx@kernel.org>
Cc:     linux-man@vger.kernel.org, kernel-team@meta.com,
        LKML <linux-kernel@vger.kernel.org>,
        Eric Biederman <ebiederm@xmission.com>,
        Matthew House <mattlloydhouse@gmail.com>
Date:   Wed, 11 Oct 2023 12:43:38 -0400
In-Reply-To: <ZSbD59Y5y3zNGC1h@debian>
References: <20231011101134.709b8089@imladris.surriel.com>
         <ZSbD59Y5y3zNGC1h@debian>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Sender: riel@surriel.com
Precedence: bulk

On Wed, 2023-10-11 at 17:48 +0200, Alejandro Colomar wrote:
> Hi Rik,
> 
> On Wed, Oct 11, 2023 at 10:11:34AM -0400, Rik van Riel wrote:
> > The execve syscall returns -E2BIG in 3 cases:
> > - The total length of the command line arguments and environment is
> > too large.
> > - An argument or environment string is longer than MAX_ARG_STRLEN.
> 
> Please mention that this includes the terminating NUL, as Matthew
> confirmed.  Otherwise, to user-space programmers, this would usually
> be
> interpreted as `strlen(p) > MAX_ARG_STRLEN`.
> 
> An example program that demonstrates the limit would be very
> interesting
> here.

Thank you for the detailed review.

I think all the comments are addressed in version 3.
-- 
All Rights Reversed.