Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Wed, 11 Oct 2023 19:54:55 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Bartosz Golaszewski <brgl@bgdev.pl>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 31/62] pinctrl: remove pinctrl_gpio_request()
Message-ID: <ZSbTXz6aEdMxG4Y/@smile.fi.intel.com>
References: <20231011120830.49324-1-brgl@bgdev.pl>
 <20231011120830.49324-32-brgl@bgdev.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231011120830.49324-32-brgl@bgdev.pl>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Wed, Oct 11, 2023 at 02:07:59PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> There are no more users of pinctrl_gpio_request() so remove it.

My question was and still is why can't we preserve most of the code?
It seems with changing a prototype to a new one and using a temporary variable
will reduce the diff noise quite a lot.

Another question is can we actually derive old functions from _new ones?

Like

foo_new(struct gpio_chip *gc, unsigned int offset)
{
	...real implementation...
}

foo(unsigned gpio)
{
	...something to get gpio chip and offset...
	foo_new(gc, offset);
}

?

-- 
With Best Regards,
Andy Shevchenko